From: Anders Lindgren <andlind@gmail.com>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: 25818@debbugs.gnu.org
Subject: bug#25818: 25.2; frame moved off display does not return (OS X)
Date: Mon, 3 Apr 2017 10:33:04 +0200 [thread overview]
Message-ID: <CABr8ebZNxKUo6057EM0-y4UYyebTaYDBtkUasmv7TSgPBjuk+A@mail.gmail.com> (raw)
In-Reply-To: <m237dq6gmy.fsf@aurox.ch>
[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]
Hi!
I think this is a good start. However, there is a case that your patch
miss. If you have multiple monitors arranged in, say, an L-shape, a frame
might be placed inside "multiscreenRect", without actually being visible on
any screen. (This typically occur when you have a large desktop monitor
connected to a laptop or when you have one monitor placed horizontally and
one vertically.)
Fortunately, it should be easy to fix. What about something like (in
pseudo-code):
BOOL in_any_screen = NO;
for (screen = /* Loop over all screens */ ...)
{
if (overlapping(frame, scree))
{
in_any_screen = YES;
break;
}
}
if ( ! in_any_screen )
{
/* Move the frame in */
}
Anyway, I think that we're on the right track and I appreciate that you
have taken time to work on this!
-- Anders
PS. I just found another, unrelated, problem, when comparing the NS and X11
versions. When passing a negative value to `set-frame-position' it is
supposed to place the frame relative to the right/bottom border of the
display, but in the NS version it doesn't. (The X11 version gets the Y
placement wrong with 48 pixels, but that is another story.)
On Sun, Apr 2, 2017 at 4:14 PM, Charles A. Roelli <charles@aurox.ch> wrote:
> Hi Anders,
>
> Does the attached patch work for you? It's still a bit rough around the
> edges, but seems to do the right thing.
>
> A quick test on 10.6:
>
> (setq ns-auto-hide-menu-bar t)
>
> ;; Places the frame just above the top of the screen.
> (set-frame-position (selected-frame) 0 -20)
>
> ;; Frame would be completely offscreen; so it's constrained and brought
> ;; back.
> (set-frame-position (selected-frame) 0 -10000)
>
> Cheers,
> Charles
>
>
[-- Attachment #2: Type: text/html, Size: 2503 bytes --]
next prev parent reply other threads:[~2017-04-03 8:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 20:04 bug#25818: 25.2; frame moved off display does not return (OS X) Charles A. Roelli
2017-02-23 8:49 ` martin rudalics
2017-02-26 11:26 ` Charles A. Roelli
2017-02-26 15:40 ` Charles A. Roelli
2017-02-26 16:45 ` martin rudalics
2017-02-26 19:42 ` Charles A. Roelli
2017-02-27 8:05 ` martin rudalics
2017-02-27 10:34 ` Charles A. Roelli
2017-02-27 20:47 ` Charles A. Roelli
2017-02-28 10:12 ` Charles A. Roelli
2017-02-28 13:20 ` Anders Lindgren
2017-02-28 15:05 ` Charles A. Roelli
2017-02-28 20:35 ` Anders Lindgren
2017-02-28 22:05 ` Drew Adams
2017-03-01 10:48 ` Anders Lindgren
2017-03-01 16:10 ` Drew Adams
2017-03-19 19:38 ` Charles A. Roelli
2017-03-27 18:22 ` Anders Lindgren
2017-04-02 14:14 ` Charles A. Roelli
2017-04-03 8:33 ` Anders Lindgren [this message]
2017-04-08 20:40 ` Charles A. Roelli
2017-04-09 19:13 ` Anders Lindgren
2017-04-10 19:54 ` Charles A. Roelli
2017-04-11 18:35 ` Anders Lindgren
2017-04-27 19:14 ` Charles A. Roelli
2017-04-27 20:05 ` Alan Third
2017-04-28 17:33 ` Charles A. Roelli
2017-05-02 20:33 ` Alan Third
2017-05-05 18:30 ` Charles A. Roelli
2017-04-29 10:30 ` martin rudalics
2017-04-29 11:15 ` Charles A. Roelli
2017-04-29 14:51 ` Alan Third
2017-04-29 17:23 ` Anders Lindgren
2017-04-30 8:32 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABr8ebZNxKUo6057EM0-y4UYyebTaYDBtkUasmv7TSgPBjuk+A@mail.gmail.com \
--to=andlind@gmail.com \
--cc=25818@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.