From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Mon, 4 Apr 2016 18:58:08 +0200 Message-ID: References: <48066d7c-e4d3-acf5-fdcf-1aa9a108cb90@yandex.ru> <83bn5ttwul.fsf@gnu.org> <83shz4sdi0.fsf@gnu.org> <5a9b5719-ea84-89bc-c0c5-37692fafd23d@yandex.ru> <8c1fc5c4-1f80-b889-3f16-55673836ed13@yandex.ru> <450a8f6d-53a6-89a5-22b0-26859019c34b@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c1246ba1410e4052faba28f X-Trace: ger.gmane.org 1459789161 10195 80.91.229.3 (4 Apr 2016 16:59:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2016 16:59:21 +0000 (UTC) Cc: 23179@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 04 18:59:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1an7qK-0001ov-Iz for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 18:59:12 +0200 Original-Received: from localhost ([::1]:60053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an7qK-00026a-2X for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 12:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an7qE-00023d-KL for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 12:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an7qA-0006Bd-HP for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 12:59:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an7qA-0006BZ-E9 for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 12:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1an7qA-0006K3-8s for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 12:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2016 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.145978909624234 (code B ref 23179); Mon, 04 Apr 2016 16:59:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 4 Apr 2016 16:58:16 +0000 Original-Received: from localhost ([127.0.0.1]:51320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an7pP-0006Io-Py for submit@debbugs.gnu.org; Mon, 04 Apr 2016 12:58:16 -0400 Original-Received: from mail-vk0-f48.google.com ([209.85.213.48]:35171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an7pO-0006Ib-7H for 23179@debbugs.gnu.org; Mon, 04 Apr 2016 12:58:14 -0400 Original-Received: by mail-vk0-f48.google.com with SMTP id e6so188003424vkh.2 for <23179@debbugs.gnu.org>; Mon, 04 Apr 2016 09:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=fqf8F7QN3CuhJv0gjo7OEUPc7gxmQEp7aS2B2RCmr4k=; b=y1BahPwM4JkJO+ujNvrWVbXkA+hXTu/QNL/7IHvIu1avssFyLGuTI7C651yrpiugrp 238NkcQoBUBkWBuDc/CrIBthQ6luhQwuC/U9sxeTS9mWpTuz6VLiE3AcJxb/s1Y3W86N ad21W01DFyJPPy9YWXGhmcxHc7QUTMbOt6muxbWSENyfLy0vEKykqYDoJLxMB3FH2GG9 ou85SF6SgzcZZPNgfZ2hrzz2u8rLk2RMdSpOpEgZ4pC8wltXyuchabqZdRdjDNho30XA BH9l80Utqgyp0n7wzyM2e1PCwC7yz74DS4Jk4aTfh/dE3HHbnTLKPGNuU27YSWSWJFB9 4+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=fqf8F7QN3CuhJv0gjo7OEUPc7gxmQEp7aS2B2RCmr4k=; b=cKMkXJYcSkJQTTKGUGTn7qBVGbMRR7m52J9TAYutM7qbBndpVVz81zui2P3nlWnk9R p6gatFAFdSNOXqOldWXqX0G3gRS0mIadeXhCLt1x/vy3oxJtO7pp4zhxThICa6EBTzRX ZGeN0/IRb/Xuz555bp/TFc80TUeMT2FfvIVzCHrscr2En2KVXatLqA/8YBL7vZ6t/n31 YZo3kZg0EGbEHKeOnYEJLL7u/nX2ofRTiRV364wT/mJZVq8ysbDmTkEdMwmrlEL2EhjD R7bslREIiA7tg7QJTauvZx37LF6Lc3zrK8uuEoJIjaKXLCyhKEBC4f6Mn6s5Ay2LMlFS B2xw== X-Gm-Message-State: AD7BkJKlwOj8HFBBhgqUqX3wrwwxIJqvpGJPphttg9Uy0aPmSMOCqQtkS6qJ5PDZVHN0zBvOP4UCNt+owBdeOA== X-Received: by 10.159.39.71 with SMTP id a65mr4105792uaa.47.1459789088687; Mon, 04 Apr 2016 09:58:08 -0700 (PDT) Original-Received: by 10.31.214.131 with HTTP; Mon, 4 Apr 2016 09:58:08 -0700 (PDT) In-Reply-To: <450a8f6d-53a6-89a5-22b0-26859019c34b@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116030 Archived-At: --94eb2c1246ba1410e4052faba28f Content-Type: text/plain; charset=UTF-8 Hi! > As far as user feedback goes, I need more than "the new key bindings are > different from the old ones". In-depth discussion of new generic commands > and their semantics would be welcome. > I really hope that you see my feedback as the latter and not the former. Apart from that, I'll refrain from commenting. If nobody steps up to implement your incremental search UI soon, though, > we'll most likely release Emacs 25.1 with the current xref UI. If xref doesn't provide something similar to tags-search and tags-query replace, I would say that it's more likely that Emacs 25.1 will be released with M-, bound to tags-loop-continue -- as this will make both the old tags commands and the new xref system work. All we need to do is to find a new binding for xref-pop-marker-stack. Please test the attached patch. I'd like to know if there are cases when > the highlighting overhead is noticeable. > I'll test it when I have a time slot available. You've never used e.g. xref-find-references? > No. I went into this with the eyes of an existing tags user, and reported the problems I saw. > You might check which versions of 'find' and 'grep' you're using, though: does M-x rgrep work all right? I remember there were some older versions of these tools compiled for Windows, with pathological performance. That's probably it. I have some kind of unix commands installed, apparently they are not up to scratch. I'll try the tools Eli suggested. However, most Windows users doesn't even have unix tools installed -- so it's a really bad idea to assume that tools like `find' and `grep' are available when running under Windows (at least until Emacs provide all the tools needed). > Project commands just need a version-controlled directory to be called from. Are you not using version control for the project in question? Yes, of course we use version control. Unfortunately, we use a collection of repositories, so it's not possible to point to a root directory. > You've also never answered the questions about the command's semantics, above. If you want to see xref-find-regexp, I suggest you do that. I think that I have done that. But I'll try again: I would like an incremental, UI-free, free text search (like tags-search and tags-query-replace). It's up to the backend to decide which files should be included in the search. In the tags case, all files referred to the tags file should be included. For other environments, public interfaces to used libraries could be included. -- Anders --94eb2c1246ba1410e4052faba28f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!
=C2=A0
As far as user feedback goes, I= need more than "the new key bindings are different from the old ones&= quot;. In-depth discussion of new generic commands and their semantics woul= d be welcome.

I really hope that you se= e my feedback as the latter and not the former. Apart from that, I'll r= efrain from commenting.


If nobody steps up to implement your incremental search UI soon, though, w= e'll most likely release Emacs 25.1 with the current xref UI.

If xref doesn't provide something similar to tag= s-search and tags-query replace, I would say that it's more likely that= Emacs 25.1 will be released with M-, bound to tags-loop-continue -- as thi= s will make both the old tags commands and the new xref system work. All we= need to do is to find a new binding for=C2=A0xref-pop-marker-stack.
<= div>

Please test the attached patc= h. I'd like to know if there are cases when the highlighting overhead i= s noticeable.

I'll test it when I h= ave a time slot available.


You've never used e.g. xref-find-references?
<= br>
No. I went into this with the eyes of an existing tags user, = and reported the problems I saw.


&g= t;=C2=A0You might check which versions of = 'find' and 'grep' you're using, though: does M-x rgrep = work all right? I remember there were some older versions of these tools co= mpiled for Windows, with pathological performance.

That's probably it. I have some kind of unix commands installed, = apparently they are not up to scratch. I'll try the tools Eli suggested= .

<= span style=3D"font-size:12.8px">However, most Windows users doesn't eve= n have unix tools installed -- so it's a really bad idea to assume that= tools like `find' and `grep' are available when running under Wind= ows (at least until Emacs provide all the tools needed).
<= span style=3D"font-size:12.8px">

>=C2= =A0Project commands just need a ver= sion-controlled directory to be called from. Are you not using version cont= rol for the project in question?

Yes, of course we use version control. Unfortunately= , we use a collection of repositories, so it's not possible to point to= a root directory.


>=C2=A0You've also never answered the questions about the command's se= mantics, above. If you want to see xref-find-regexp, I suggest you do that.=

I think that I have done that. But I'll = try again: I would like an incremental, UI-free, free text search (like tag= s-search and tags-query-replace). It's up to the backend to decide whic= h files should be included in the search. In the tags case, all files refer= red to the tags file should be included. For other environments, public int= erfaces to used libraries could be included.

=C2=A0 =C2=A0 -- Anders

--94eb2c1246ba1410e4052faba28f--