From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#16426: Acknowledgement (24.3.50; Follow-mode broken when window is selected from another buffer, like compile-goto-error (worked in 24.2, broken in 24.3)) Date: Wed, 15 Jan 2014 22:54:15 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=f46d043c80d09e9d2304f0095923 X-Trace: ger.gmane.org 1389822912 29148 80.91.229.3 (15 Jan 2014 21:55:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jan 2014 21:55:12 +0000 (UTC) To: 16426@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 15 22:55:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3YQg-0000Qq-IR for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jan 2014 22:55:18 +0100 Original-Received: from localhost ([::1]:57438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YQg-0006zd-7c for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jan 2014 16:55:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YQY-0006zH-Aw for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 16:55:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3YQS-0003TL-3t for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 16:55:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3YQR-0003Pc-QU for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 16:55:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3YQQ-0004O6-Nt for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 16:55:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2014 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16426-submit@debbugs.gnu.org id=B16426.138982286316813 (code B ref 16426); Wed, 15 Jan 2014 21:55:02 +0000 Original-Received: (at 16426) by debbugs.gnu.org; 15 Jan 2014 21:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:52541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3YPm-0004N7-8k for submit@debbugs.gnu.org; Wed, 15 Jan 2014 16:54:22 -0500 Original-Received: from mail-wg0-f43.google.com ([74.125.82.43]:57819) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3YPj-0004Mv-UE for 16426@debbugs.gnu.org; Wed, 15 Jan 2014 16:54:21 -0500 Original-Received: by mail-wg0-f43.google.com with SMTP id y10so2398159wgg.10 for <16426@debbugs.gnu.org>; Wed, 15 Jan 2014 13:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=ljRDVblFPnNpl4eydOqmloTBHCjwGYgRvZAAi0rYQvo=; b=DtZupmlnGG3ayZWnWHJrlnFz76V5ghYoc8OVoDr064579OSEj/kdNYEF6hxKZnoIiU YfGXKRA6dTCqcDxH7OCzSC8gHeyXTO6b2hnSUsfvly8nFfiyhJWmWPpou0PZUAoOxxHH NTq3+OZNsXMHdvtVvsO9RtGtQHDEj+nuXlFb1XE5/HnbHXaZVp2Rnj7rjGeSSv7T+PfX yP+G2oec17LDemP8WuOb7GXL9im1DbBBhP/kHtuBAOl8HhvJr5oViCP5qtORSXOb+ehH KcT4AFdqvCnGtpPnC/RdT77cmgxs5hXTBjr4G6JxBm4Q85GVCY3oKNC3Hy1xjmVDjK1a 9P1g== X-Received: by 10.181.13.165 with SMTP id ez5mr4619468wid.56.1389822855779; Wed, 15 Jan 2014 13:54:15 -0800 (PST) Original-Received: by 10.216.187.199 with HTTP; Wed, 15 Jan 2014 13:54:15 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83563 Archived-At: --f46d043c80d09e9d2304f0095923 Content-Type: text/plain; charset=ISO-8859-1 Hi, Below is a patch to correct the problem described in the bug report. -- Anders === modified file 'lisp/follow.el' --- lisp/follow.el 2014-01-10 09:30:43 +0000 +++ lisp/follow.el 2014-01-15 21:49:56 +0000 @@ -1119,13 +1119,15 @@ "Ensure that the windows in Follow mode are adjacent after each command." (unless (input-pending-p) (let ((follow-inside-post-command-hook t) - (win (selected-window))) + (win (selected-window)) + dest) ;; Work in the selected window, not in the current buffer. (with-current-buffer (window-buffer win) + (setq dest (point)) (unless (and (symbolp this-command) (get this-command 'follow-mode-use-cache)) (setq follow-windows-start-end-cache nil))) - (follow-adjust-window win (point))))) + (follow-adjust-window win dest)))) On Sun, Jan 12, 2014 at 9:48 PM, GNU bug Tracking System < help-debbugs@gnu.org> wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 16426@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > > -- > 16426: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16426 > GNU Bug Tracking System > Contact help-debbugs@gnu.org with problems > --f46d043c80d09e9d2304f0095923 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi,

Below is a patch to correct the pro= blem described in the bug report.

=A0 =A0 -- Ander= s


=3D=3D=3D modified file 'lisp/follo= w.el'

--- lisp/follow.el 2014-01-10 09:30:4= 3 +0000

+++ lisp/follow.el 2014-01-15 21:49:5= 6 +0000

@@ -1119,13 +1119,15 @@

=A0=A0 "Ensure that the windows in Follow mode are adjac= ent after each command."

=A0=A0 (unless (input-pending-p)

=A0=A0 =A0 (let ((follow-inside-post-command-hook t)

- =A0 (win (selected-window)))

+ =A0 (win (selected-window))

+=A0 =A0 =A0 =A0 =A0 dest)

=A0=A0 =A0 =A0 ;; Work in the selected window, not in the cur= rent buffer.

=A0=A0 =A0 =A0 (with-current-buffer (window-buffer win)

+=A0 =A0 =A0 =A0 (setq dest (point))

=A0 (unless (and (symbolp this-comman= d)

=A0 =A0 =A0= (get this-command 'follow-mode-use-cache))

=A0 =A0 (setq follow-windows-start-en= d-cache nil)))

-=A0 =A0 =A0 (follow-adjust-window win (point)))))

+=A0 =A0 =A0 (follow-adjust-window win dest))))

=A0



On Sun, Jan 12, 2014 at 9:48 PM, GNU bug Tracking Syste= m <help-debbugs@gnu.org> wrote:
Thank you for filing a new bug report with <= a href=3D"http://debbugs.gnu.org" target=3D"_blank">debbugs.gnu.org.
This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
=A0bug-gnu-emacs@gnu.org

If you wish to submit further information on this problem, please
send it to 16426@debbugs.gnu.org.

Please do not send mail to help-deb= bugs@gnu.org unless you wish
to report a problem with the Bug-tracking system.

--
16426: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16426
GNU Bug Tracking System
Contact help-debbugs@gnu.org wi= th problems

--f46d043c80d09e9d2304f0095923--