From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) Date: Tue, 10 Nov 2015 22:39:25 +0100 Message-ID: References: <563F4B17.6090308@porkrind.org> <56424784.2070600@porkrind.org> <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=94eb2c0816083530f30524368bc3 X-Trace: ger.gmane.org 1447191628 7907 80.91.229.3 (10 Nov 2015 21:40:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Nov 2015 21:40:28 +0000 (UTC) Cc: 21862@debbugs.gnu.org, 21862-done@debbugs.gnu.org, David Caldwell To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 10 22:40:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwGeH-0002MR-QC for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Nov 2015 22:40:18 +0100 Original-Received: from localhost ([::1]:35685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwGeH-0004rS-7Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Nov 2015 16:40:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwGe8-0004qr-TD for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 16:40:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwGe4-0002CY-1P for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 16:40:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwGe3-0002CM-Ti for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 16:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZwGe2-0001ZG-SN for bug-gnu-emacs@gnu.org; Tue, 10 Nov 2015 16:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Nov 2015 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21862-submit@debbugs.gnu.org id=B21862.14471915886000 (code B ref 21862); Tue, 10 Nov 2015 21:40:02 +0000 Original-Received: (at 21862) by debbugs.gnu.org; 10 Nov 2015 21:39:48 +0000 Original-Received: from localhost ([127.0.0.1]:60681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwGdn-0001Yd-Gv for submit@debbugs.gnu.org; Tue, 10 Nov 2015 16:39:48 -0500 Original-Received: from mail-yk0-f172.google.com ([209.85.160.172]:36743) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZwGdS-0001Y2-HY; Tue, 10 Nov 2015 16:39:45 -0500 Original-Received: by ykdr82 with SMTP id r82so18028740ykd.3; Tue, 10 Nov 2015 13:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EEhoWb6n+r0nMxvxkxTnGHvPKQwLCszp+6RWEknZMQQ=; b=vhQiSb/9nYpbSo/5Sa3oEnVRnm06gkuv+P6aDDHXHDM723qRO8GzXMmbW4o0p+guA+ mxkSeeZklahOzILfWJZ+h8Bh6uehNYUVgnTHNHr/3dUT1XFM+BrIpl8FqeUyJGWv8p3x FL8bAGi+1Qdy2YkvbUkz1o/1N0xR1+bZNI+viVyIk6lr3OOLSGjm1YsBxgeWsPTl5BOX IvIhk+2ruheF04ngoshHv1cH9hc0VCpNsx5Ob/XD0h0yAR1wSdVofnRYKPbDU2tAQsRX l2G544onTqLrn3EM8UtC0eKGQLB2bGLNiRvmJeBXGj1KyRCrdJykkOXHhRXsRIb8Auax z7yw== X-Received: by 10.129.147.135 with SMTP id k129mr5290780ywg.233.1447191565895; Tue, 10 Nov 2015 13:39:25 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Tue, 10 Nov 2015 13:39:25 -0800 (PST) In-Reply-To: <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108621 Archived-At: --94eb2c0816083530f30524368bc3 Content-Type: multipart/alternative; boundary=94eb2c0816083530ee0524368bc1 --94eb2c0816083530ee0524368bc1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Unfortunately, when I compile on my 10.6.8 machine I get the following warnings: nsterm.m: In function =E2=80=98-[EmacsView windowWillEnterFullScreen:]=E2= =80=99: nsterm.m:6875: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2=80=98-windowWillEnterFullScreen=E2=80=99 nsterm.m:6875: warning: (Messages without a matching method signature nsterm.m:6875: warning: will be assumed to return =E2=80=98id=E2=80=99 and = accept nsterm.m:6875: warning: =E2=80=98...=E2=80=99 as arguments.) nsterm.m: In function =E2=80=98-[EmacsView windowDidEnterFullScreen]=E2=80= =99: nsterm.m:6887: warning: passing argument 1 of =E2=80=98notificationWithName:object:=E2=80=99 from incompatible pointer ty= pe nsterm.m:6887: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2=80=98-windowDidEnterFullScreen:=E2=80=99 nsterm.m: In function =E2=80=98-[EmacsView windowWillExitFullScreen:]=E2=80= =99: nsterm.m:6925: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2=80=98-windowWillExitFullScreen=E2=80=99 nsterm.m: In function =E2=80=98-[EmacsView windowDidExitFullScreen:]=E2=80= =99: nsterm.m:6942: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2= =80=98-windowDid The attached patch eliminate them. Basically, it's declarations of the new (and shadowed) functions and the notification name should be a NSString (i.e. a @ was missing). -- Anders On Tue, Nov 10, 2015 at 10:02 PM, David Reitter wrote: > Hi David (and Anders), > > I have checked in some changes that should allow compilation on 10.6.8. > I do not have a machine to test, so please reopen this bug in case you > encounter a problem. > > - David > > > > On Nov 10, 2015, at 2:37 PM, David Caldwell wrote: > > > > Hi David, I'm pulling you in to this bug report since it is about your > > commit. > > > > I tried reverting the commit in question > > (35cd51814507987b916c4b4e0a7b45e09e454341) and I don't see any warning > > generated with the latest XCode (Version 7.1.1 (7B1005)). Where were yo= u > > seeing these warnings? > > > > -David > > > > > > --94eb2c0816083530ee0524368bc1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Unfortunately, when I compile on my= 10.6.8 machine I get the following warnings:

nsterm.m: In function =E2=80=98-[EmacsView windowWillEnterFullScreen:]=E2= =80=99:
nsterm.m:6875: warning: =E2=80=98EmacsView=E2=80=99 may n= ot respond to =E2=80=98-windowWillEnterFullScreen=E2=80=99
nsterm= .m:6875: warning: (Messages without a matching method signature
n= sterm.m:6875: warning: will be assumed to return =E2=80=98id=E2=80=99 and a= ccept
nsterm.m:6875: warning: =E2=80=98...=E2=80=99 as arguments.= )
nsterm.m: In function =E2=80=98-[EmacsView windowDidEnterFullSc= reen]=E2=80=99:
nsterm.m:6887: warning: passing argument 1 of =E2= =80=98notificationWithName:object:=E2=80=99 from incompatible pointer type<= /div>
nsterm.m:6887: warning: =E2=80=98EmacsView=E2=80=99 may not respo= nd to =E2=80=98-windowDidEnterFullScreen:=E2=80=99
nsterm.m: In f= unction =E2=80=98-[EmacsView windowWillExitFullScreen:]=E2=80=99:
nsterm.m:6925: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2= =80=98-windowWillExitFullScreen=E2=80=99
nsterm.m: In function = =E2=80=98-[EmacsView windowDidExitFullScreen:]=E2=80=99:
nsterm.m= :6942: warning: =E2=80=98EmacsView=E2=80=99 may not respond to =E2=80=98-wi= ndowDid

The attached patch eliminate them. B= asically, it's declarations of the new (and shadowed) functions and the= notification name should be a NSString (i.e. a @ was missing).
<= br>
=C2=A0 =C2=A0 -- Anders
=C2=A0

=

On Tue, Nov= 10, 2015 at 10:02 PM, David Reitter <david.reitter@gmail.com>= ; wrote:
Hi David (and Anders),
I have checked in some changes that should allow compilation on 10.6.8.
I do not have a machine to test, so please reopen this bug in case you enco= unter a problem.

- David


> On Nov 10, 2015, at 2:37 PM, David Caldwell <david@porkrind.org> wrote:
>
> Hi David, I'm pulling you in to this bug report since it is about = your
> commit.
>
> I tried reverting the commit in question
> (35cd51814507987b916c4b4e0a7b45e09e454341) and I don't see any war= ning
> generated with the latest XCode (Version 7.1.1 (7B1005)). Where were y= ou
> seeing these warnings?
>
> -David
>
>


--94eb2c0816083530ee0524368bc1-- --94eb2c0816083530f30524368bc3 Content-Type: text/plain; charset=US-ASCII; name="osx106.diff" Content-Disposition: attachment; filename="osx106.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igtwfram0 ZGlmZiAtLWdpdCBhL3NyYy9uc3Rlcm0uaCBiL3NyYy9uc3Rlcm0uaAppbmRleCAxYjMzMGYwLi5h MmYzNDRlIDEwMDY0NAotLS0gYS9zcmMvbnN0ZXJtLmgKKysrIGIvc3JjL25zdGVybS5oCkBAIC00 MTIsNiArNDEyLDExIEBAIHZvaWQgbnN0cmFjZV9sZWF2ZShpbnQgKik7CiAtICh2b2lkKXdpbmRv d0RpZE1vdmU6IChpZClzZW5kZXI7CiAjZW5kaWYKIC0gKGludClmdWxsc2NyZWVuU3RhdGU7Cist ICh2b2lkKXdpbmRvd1dpbGxFbnRlckZ1bGxTY3JlZW47CistICh2b2lkKXdpbmRvd0RpZEVudGVy RnVsbFNjcmVlbjsKKy0gKHZvaWQpd2luZG93RGlkRW50ZXJGdWxsU2NyZWVuOihOU05vdGlmaWNh dGlvbiAqKW5vdGlmaWNhdGlvbjsKKy0gKHZvaWQpd2luZG93V2lsbEV4aXRGdWxsU2NyZWVuOwor LSAodm9pZCl3aW5kb3dEaWRFeGl0RnVsbFNjcmVlbjsKIEBlbmQKIAogCmRpZmYgLS1naXQgYS9z cmMvbnN0ZXJtLm0gYi9zcmMvbnN0ZXJtLm0KaW5kZXggNWMzOWQ1Yy4uYTJiMThjYyAxMDA2NDQK LS0tIGEvc3JjL25zdGVybS5tCisrKyBiL3NyYy9uc3Rlcm0ubQpAQCAtNjg2Nyw3ICs2ODY3LDcg QEAgbm90X2luX2FyZ3YgKE5TU3RyaW5nICphcmcpCiAjZW5kaWYKIAogI2lmICFkZWZpbmVkIChO U19JTVBMX0NPQ09BKSB8fCBNQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEIDwgTUFDX09TX1hf VkVSU0lPTl8xMF83Ci0jZGVmaW5lIE5TV2luZG93RGlkRW50ZXJGdWxsU2NyZWVuTm90aWZpY2F0 aW9uICJOU1dpbmRvd0RpZEVudGVyRnVsbFNjcmVlbk5vdGlmaWNhdGlvbiIKKyNkZWZpbmUgTlNX aW5kb3dEaWRFbnRlckZ1bGxTY3JlZW5Ob3RpZmljYXRpb24gQCJOU1dpbmRvd0RpZEVudGVyRnVs bFNjcmVlbk5vdGlmaWNhdGlvbiIKICNlbmRpZgogCiAtICh2b2lkKXdpbmRvd1dpbGxFbnRlckZ1 bGxTY3JlZW46KE5TTm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCg== --94eb2c0816083530f30524368bc3--