From: Anders Lindgren <andlind@gmail.com>
To: David Reitter <david.reitter@gmail.com>
Cc: 21862@debbugs.gnu.org, 21862-done@debbugs.gnu.org,
David Caldwell <david@porkrind.org>
Subject: bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6)
Date: Tue, 10 Nov 2015 22:39:25 +0100 [thread overview]
Message-ID: <CABr8ebZByyaNdenXFWvbsD-8tpvr7wF=vgTXTMTqwXZhmAZmQA@mail.gmail.com> (raw)
In-Reply-To: <50B60CF8-CBE3-4DF1-8E44-9C6DD5883C6E@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1971 bytes --]
Hi,
Unfortunately, when I compile on my 10.6.8 machine I get the following
warnings:
nsterm.m: In function ‘-[EmacsView windowWillEnterFullScreen:]’:
nsterm.m:6875: warning: ‘EmacsView’ may not respond to
‘-windowWillEnterFullScreen’
nsterm.m:6875: warning: (Messages without a matching method signature
nsterm.m:6875: warning: will be assumed to return ‘id’ and accept
nsterm.m:6875: warning: ‘...’ as arguments.)
nsterm.m: In function ‘-[EmacsView windowDidEnterFullScreen]’:
nsterm.m:6887: warning: passing argument 1 of
‘notificationWithName:object:’ from incompatible pointer type
nsterm.m:6887: warning: ‘EmacsView’ may not respond to
‘-windowDidEnterFullScreen:’
nsterm.m: In function ‘-[EmacsView windowWillExitFullScreen:]’:
nsterm.m:6925: warning: ‘EmacsView’ may not respond to
‘-windowWillExitFullScreen’
nsterm.m: In function ‘-[EmacsView windowDidExitFullScreen:]’:
nsterm.m:6942: warning: ‘EmacsView’ may not respond to ‘-windowDid
The attached patch eliminate them. Basically, it's declarations of the new
(and shadowed) functions and the notification name should be a NSString
(i.e. a @ was missing).
-- Anders
On Tue, Nov 10, 2015 at 10:02 PM, David Reitter <david.reitter@gmail.com>
wrote:
> Hi David (and Anders),
>
> I have checked in some changes that should allow compilation on 10.6.8.
> I do not have a machine to test, so please reopen this bug in case you
> encounter a problem.
>
> - David
>
>
> > On Nov 10, 2015, at 2:37 PM, David Caldwell <david@porkrind.org> wrote:
> >
> > Hi David, I'm pulling you in to this bug report since it is about your
> > commit.
> >
> > I tried reverting the commit in question
> > (35cd51814507987b916c4b4e0a7b45e09e454341) and I don't see any warning
> > generated with the latest XCode (Version 7.1.1 (7B1005)). Where were you
> > seeing these warnings?
> >
> > -David
> >
> >
>
>
[-- Attachment #1.2: Type: text/html, Size: 2621 bytes --]
[-- Attachment #2: osx106.diff --]
[-- Type: text/plain, Size: 952 bytes --]
diff --git a/src/nsterm.h b/src/nsterm.h
index 1b330f0..a2f344e 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -412,6 +412,11 @@ void nstrace_leave(int *);
- (void)windowDidMove: (id)sender;
#endif
- (int)fullscreenState;
+- (void)windowWillEnterFullScreen;
+- (void)windowDidEnterFullScreen;
+- (void)windowDidEnterFullScreen:(NSNotification *)notification;
+- (void)windowWillExitFullScreen;
+- (void)windowDidExitFullScreen;
@end
diff --git a/src/nsterm.m b/src/nsterm.m
index 5c39d5c..a2b18cc 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6867,7 +6867,7 @@ not_in_argv (NSString *arg)
#endif
#if !defined (NS_IMPL_COCOA) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
-#define NSWindowDidEnterFullScreenNotification "NSWindowDidEnterFullScreenNotification"
+#define NSWindowDidEnterFullScreenNotification @"NSWindowDidEnterFullScreenNotification"
#endif
- (void)windowWillEnterFullScreen:(NSNotification *)notification
next prev parent reply other threads:[~2015-11-10 21:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 13:16 bug#21862: 24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6 David Caldwell
[not found] ` <handler.21862.B.14469886195908.ack@debbugs.gnu.org>
2015-11-10 19:37 ` bug#21862: Acknowledgement (24.5; Commit 35cd5181450 breaks nsterm.m on Mac OS X 10.6) David Caldwell
2015-11-10 19:43 ` David Reitter
2015-11-10 21:02 ` David Reitter
2015-11-10 21:11 ` David Caldwell
2015-11-10 21:39 ` Anders Lindgren [this message]
2015-11-10 22:10 ` David Reitter
2015-11-11 6:56 ` Anders Lindgren
2015-11-14 20:14 ` Anders Lindgren
2015-11-14 20:23 ` David Reitter
2015-11-14 23:23 ` John Wiegley
2015-11-15 7:18 ` Anders Lindgren
2015-11-15 17:57 ` Anders Lindgren
2015-11-10 22:12 ` David Caldwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABr8ebZByyaNdenXFWvbsD-8tpvr7wF=vgTXTMTqwXZhmAZmQA@mail.gmail.com' \
--to=andlind@gmail.com \
--cc=21862-done@debbugs.gnu.org \
--cc=21862@debbugs.gnu.org \
--cc=david.reitter@gmail.com \
--cc=david@porkrind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.