From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame Date: Sat, 14 Nov 2015 20:42:04 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a113feeecddd72b0524855e46 X-Trace: ger.gmane.org 1447597212 18181 80.91.229.3 (15 Nov 2015 14:20:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Nov 2015 14:20:12 +0000 (UTC) Cc: 21415@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 15 15:20:03 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zxy9y-0002Hs-DW for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Nov 2015 15:20:02 +0100 Original-Received: from localhost ([::1]:42732 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxy9x-0000ZE-Hn for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Nov 2015 09:20:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxgj4-0007Dj-3N for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 14:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zxgj0-00083E-Oo for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 14:43:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxgj0-000838-LR for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 14:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zxgj0-0002b9-IX for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2015 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2015 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21415 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21415-submit@debbugs.gnu.org id=B21415.14475301289926 (code B ref 21415); Sat, 14 Nov 2015 19:43:02 +0000 Original-Received: (at 21415) by debbugs.gnu.org; 14 Nov 2015 19:42:08 +0000 Original-Received: from localhost ([127.0.0.1]:38222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zxgi7-0002a1-D2 for submit@debbugs.gnu.org; Sat, 14 Nov 2015 14:42:07 -0500 Original-Received: from mail-vk0-f45.google.com ([209.85.213.45]:32957) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zxgi5-0002Zs-3q for 21415@debbugs.gnu.org; Sat, 14 Nov 2015 14:42:05 -0500 Original-Received: by vkbs1 with SMTP id s1so9338750vkb.0 for <21415@debbugs.gnu.org>; Sat, 14 Nov 2015 11:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2RixTvvHjGlQuzs8VyczGsfE/NMyZk6sTGonH/6ol3o=; b=KxI3T1MToC182dtRVEvSycE+hnXSQBINIFt/XKCCkytfRtS+5xpvqV0gU1/zfemifJ WqoaA9X/c7vdrbt1+6D0OG8FQZscW1gDyWqD+SwA9ZJ+uwTOv911gOtxUFjfQPZ9kz6d EaRexjvumbjxPfo45fxmvXF0JlcfTKTvwuuzAmcD7/eSS6F8Yy7Nw6SmOEkaPoLaMVT7 uevXKov4jy/G1/UuW3q17//ZpDWt7MSg/riAX+teTml5QIDjNlC2Z47tNTv7p/yDK0qi P7pMO3txcViN2gNKm2PL35q9C1VYIzoTm5Lyq+d/78C0lz9TXvxTXOcNRYV6Nn1rcLKf 21Gg== X-Received: by 10.31.60.68 with SMTP id j65mr4695680vka.105.1447530124393; Sat, 14 Nov 2015 11:42:04 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Sat, 14 Nov 2015 11:42:04 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108742 Archived-At: --001a113feeecddd72b0524855e46 Content-Type: multipart/alternative; boundary=001a113feeecddd7240524855e44 --001a113feeecddd7240524855e44 Content-Type: text/plain; charset=UTF-8 Hi, I found some time to look into this. When the frame was maximized and the tool-bar was disabled, the function x_set_window_size was never called. The following patch makes the frame exit the fullheight or maximized states when the tool-bar is disabled, which makes the call x_set_window_size reappear. It does NOT, however, return the frame to the fullheight or maximized states when the toolbar is re-enabled (I don't even know if it should). In addition, it does not support frame-inhibit-implied-resize either (which would require a lot more work). I read in the emacs-devel group that there is a feature-freeze in place -- does this mean that I shouldn't commit this? Also, the current Emacs master branch doesn't build on OS X 10.6.8 after an attempt to David Reitter to eliminate warnings -- I think it's an easy fix (David don't have access to a 10.6.8 machine but fortunately I do). -- Anders On Thu, Oct 29, 2015 at 3:47 AM, Keith David Bershatsky wrote: > The following are results of my tests with `emacs-repository-version` > "ffa41ad2a02dbd1202d71a08bac34831f25662d0" built this evening (October 28, > 2015). > > Starting from Emacs -Q, and then turning off the toolbar using the mouse > by clicking the option in the menubar, the frame shrinks slightly. Clicking > the toolbar option again restores the frame to its original position. > > `M-x toggle-frame-maximized` results in a frame properly maximized. > > The first time I turned off the toolbar from a maximized frame, the frame > shrunk a little. When I turned the toolbar back on again, the frame did > not return to a maximized position -- i.e., it remained a few pixels shy of > full-screen in terms of height. When I turned the toolbar off again, the > main window reduced in size and the height of the echo area increased to > about 3 lines in height -- the frame remained the same size. When I turned > the toolbar on again, the main window returned to its prior size and the > echo area returned to a size of just one line -- the frame stayed the same > size (i.e., a few pixels shy of full-screen in terms of height). > > Keith > --001a113feeecddd7240524855e44 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I found some time to look into this. Whe= n the frame was maximized and the tool-bar was disabled, the function x_set= _window_size was never called.

The following patch makes the frame e= xit the fullheight or maximized states when the tool-bar is disabled, which= makes the call x_set_window_size reappear. It does NOT, however, return th= e frame to the fullheight or maximized states when the toolbar is re-enable= d (I don't even know if it should). In addition, it does not support fr= ame-inhibit-implied-resize either (which would require a lot more work).

I read in the emacs-devel group that there is a= feature-freeze in place -- does this mean that I shouldn't commit this= ?

Also, the current Emacs master branch doesn'= t build on OS X 10.6.8 after an attempt to David Reitter to eliminate warni= ngs -- I think it's an easy fix (David don't have access to a 10.6.= 8 machine but fortunately I do).

=C2=A0 =C2=A0 -- = Anders


On Thu, Oct 29, 2015 at 3:47 AM, Keith David Bershatsky <es= q@lawlist.com> wrote:
The f= ollowing are results of my tests with `emacs-repository-version` "ffa4= 1ad2a02dbd1202d71a08bac34831f25662d0" built this evening (October 28, = 2015).

Starting from Emacs -Q, and then turning off the toolbar using the mouse by= clicking the option in the menubar, the frame shrinks slightly. Clicking t= he toolbar option again restores the frame to its original position.

`M-x toggle-frame-maximized` results in a frame properly maximized.

The first time I turned off the toolbar from a maximized frame, the frame s= hrunk a little.=C2=A0 When I turned the toolbar back on again, the frame di= d not return to a maximized position -- i.e., it remained a few pixels shy = of full-screen in terms of height.=C2=A0 When I turned the toolbar off agai= n, the main window reduced in size and the height of the echo area increase= d to about 3 lines in height -- the frame remained the same size.=C2=A0 Whe= n I turned the toolbar on again, the main window returned to its prior size= and the echo area returned to a size of just one line -- the frame stayed = the same size (i.e., a few pixels shy of full-screen in terms of height).
Keith

--001a113feeecddd7240524855e44-- --001a113feeecddd72b0524855e46 Content-Type: text/plain; charset=US-ASCII; name="toolbar-maximized.diff" Content-Disposition: attachment; filename="toolbar-maximized.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_igzhquke0 ZGlmZiAtLWdpdCBhL3NyYy9uc2Zucy5tIGIvc3JjL25zZm5zLm0KaW5kZXggY2ZmYjU5OS4uODUx MDMyNyAxMDA2NDQKLS0tIGEvc3JjL25zZm5zLm0KKysrIGIvc3JjL25zZm5zLm0KQEAgLTY3MSw2 ICs2NzEsMTggQEAgeF9zZXRfdG9vbF9iYXJfbGluZXMgKHN0cnVjdCBmcmFtZSAqZiwgTGlzcF9P YmplY3QgdmFsdWUsIExpc3BfT2JqZWN0IG9sZHZhbCkKICAgICAgICAgewogICAgICAgICAgIGZy ZWVfZnJhbWVfdG9vbF9iYXIgKGYpOwogICAgICAgICAgIEZSQU1FX0VYVEVSTkFMX1RPT0xfQkFS IChmKSA9IDA7CisKKyAgICAgICAgICB7CisgICAgICAgICAgICBMaXNwX09iamVjdCBmdWxsc2Ny ZWVuID0gZ2V0X2ZyYW1lX3BhcmFtIChmLCBRZnVsbHNjcmVlbik7CisgICAgICAgICAgICBpZiAo RVEgKGZ1bGxzY3JlZW4sIFFtYXhpbWl6ZWQpKQorICAgICAgICAgICAgICB7CisgICAgICAgICAg ICAgICAgc3RvcmVfZnJhbWVfcGFyYW0gKGYsIFFmdWxsc2NyZWVuLCBRZnVsbHdpZHRoKTsKKyAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZSBpZiAoRVEgKGZ1bGxzY3JlZW4sIFFmdWxs aGVpZ2h0KSkKKyAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHN0b3JlX2ZyYW1lX3Bh cmFtIChmLCBRZnVsbHNjcmVlbiwgUW5pbCk7CisgICAgICAgICAgICAgIH0KKyAgICAgICAgICB9 CiAgICAgICAgIH0KICAgICB9CiAK --001a113feeecddd72b0524855e46--