From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#22169: 25.0.50; File name compiletion doesn't work with non-ASCII characters on OS X Date: Mon, 21 Dec 2015 07:52:53 +0100 Message-ID: References: <83y4cw3kie.fsf@gnu.org> <83twnk3fg1.fsf@gnu.org> <83oads2x99.fsf@gnu.org> <83io3z3drh.fsf@gnu.org> <831tan32q2.fsf@gnu.org> <83r3ikxmis.fsf@gnu.org> <83fuyxt35q.fsf@gnu.org> <8337uwucyt.fsf@gnu.org> <83wps8sc6h.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1144f92231b80b052762f0f4 X-Trace: ger.gmane.org 1450680800 21119 80.91.229.3 (21 Dec 2015 06:53:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Dec 2015 06:53:20 +0000 (UTC) Cc: random832@fastmail.com, 22169@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 21 07:53:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aAuLH-0002Hj-QJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Dec 2015 07:53:12 +0100 Original-Received: from localhost ([::1]:43378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAuLG-0006Nc-6m for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Dec 2015 01:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAuLC-0006Me-3W for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2015 01:53:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAuL8-0002Gl-Mk for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2015 01:53:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAuL8-0002Gg-JT for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2015 01:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aAuL8-0004PR-9o for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2015 01:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2015 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22169-submit@debbugs.gnu.org id=B22169.145068078116942 (code B ref 22169); Mon, 21 Dec 2015 06:53:02 +0000 Original-Received: (at 22169) by debbugs.gnu.org; 21 Dec 2015 06:53:01 +0000 Original-Received: from localhost ([127.0.0.1]:58508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAuL6-0004PC-TU for submit@debbugs.gnu.org; Mon, 21 Dec 2015 01:53:01 -0500 Original-Received: from mail-vk0-f49.google.com ([209.85.213.49]:35568) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aAuL5-0004P0-9F for 22169@debbugs.gnu.org; Mon, 21 Dec 2015 01:52:59 -0500 Original-Received: by mail-vk0-f49.google.com with SMTP id a189so95736664vkh.2 for <22169@debbugs.gnu.org>; Sun, 20 Dec 2015 22:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nf8dD55Xjevb8ltEiTH3lzGfZqYsBl/AmfKVLtmpPvY=; b=01ZMFHvvOSY9p7+LWcHaJkuTqO3XIHtwxKUt7f2y/scR9j9feTk9KxV6vxnzR8bQBB GG/eocKd98n/ehagc428XjOVCl4r0ortc2/qsoKvM3vYFikwMRB13ecYslXOjEOfzuXZ p4qmXoO6eeV87to3skics4frZTTJNiywT9+AAn3aVGDGEAsSqAC85BHlf6UJtIQyQE5z +8OPKFP3caIBssr+NA8tFg0uKYIJNc0uCDNrviaj5bP9kAFo9jVA0zejhSeGaGf0bA4a ToX9py9RRR/POBCOdnbJ8TTalvhlvrG09uPbqLMFVd/GT1Nn2Jkfo/+8hmCujUWkimIj Eghg== X-Received: by 10.31.138.20 with SMTP id m20mr11640614vkd.70.1450680773619; Sun, 20 Dec 2015 22:52:53 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Sun, 20 Dec 2015 22:52:53 -0800 (PST) In-Reply-To: <83wps8sc6h.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110232 Archived-At: --001a1144f92231b80b052762f0f4 Content-Type: text/plain; charset=UTF-8 Hi! I did some simple measurements with and without this patch. I ran `(file-name-all-completions "x" "src")' on the Emacs src directory. The timing values were almost identical (varying between 0.001012 and 0.001080). The way I see it, the patch doesn't do any harm in any coding system, and it is fast. Hence, I don't really see that it's worth the effort to make this code conditional. However, please write a patch for this if you still thinks it's necessary. I can test it here to make sure it works under OS X. -- Anders On Mon, Dec 21, 2015 at 4:39 AM, Eli Zaretskii wrote: > > Date: Sun, 20 Dec 2015 23:00:40 +0100 > > From: Anders Lindgren > > Cc: random832@fastmail.com, 22169@debbugs.gnu.org > > > > I managed to get the attached patch to work (when used in conjunction > with my > > previous patch). > > > > I've tested: > > > > * C-x C-f a TAB > > * (find-file-all-competions "a" ".") > > OK, thanks. > > The next step is arrange for this to happen only with those values of > file-name-coding-system that require it. My idea is to put a special > property on the coding-system's symbol, and check that inside > file_name_completion (outside of the loop). Can you add this, or do > you want me to suggest a patch along these lines for you to test? > Note that the property check will have to be done on > file-name-coding-system if it is non-nil, otherwise on > default-file-name-coding-system (if that is non-nil). > > Thanks. > --001a1144f92231b80b052762f0f4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!

I did some simple measurements with= and without this patch. I ran `(file-name-all-completions "x" &q= uot;src")' on the Emacs src directory. The timing values were almo= st identical (varying between 0.001012 and 0.001080).

<= div>The way I see it, the patch doesn't do any harm in any coding syste= m, and it is fast. Hence, I don't really see that it's worth the ef= fort to make this code conditional.

However, pleas= e write a patch for this if you still thinks it's necessary. I can test= it here to make sure it works under OS X.

=C2=A0 = =C2=A0 -- Anders


<= div class=3D"gmail_quote">On Mon, Dec 21, 2015 at 4:39 AM, Eli Zaretskii <eliz@= gnu.org> wrote:
> Date: = Sun, 20 Dec 2015 23:00:40 +0100
> From: Anders Lindgren <andlind@gmail.com>
> Cc: random832@fastmail.com, 22169@debbugs.gnu.org
>
> I managed to get the attached patch to work (w= hen used in conjunction with my
> previous patch).
>
> I've tested:
>
> * C-x C-f a TAB
> * (find-file-all-competions "a" ".")

OK, thanks.

The next step is arrange for this to happen only with those values of
file-name-coding-system that require it.=C2=A0 My idea is to put a special<= br> property on the coding-system's symbol, and check that inside
file_name_completion (outside of the loop).=C2=A0 Can you add this, or do you want me to suggest a patch along these lines for you to test?
Note that the property check will have to be done on
file-name-coding-system if it is non-nil, otherwise on
default-file-name-coding-system (if that is non-nil).

Thanks.

--001a1144f92231b80b052762f0f4--