From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#16856: [PATCH] Prevent cursor from over-drawing the fringe Date: Sat, 21 May 2016 21:07:53 +0200 Message-ID: References: <20160517211415.GA85076@breton.holly.idiocy.org> <20160521073536.GA95517@breton.holly.idiocy.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0b5038a66ae405335eec88 X-Trace: ger.gmane.org 1463857710 1505 80.91.229.3 (21 May 2016 19:08:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 May 2016 19:08:30 +0000 (UTC) Cc: 16856-done@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 21 21:08:21 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b4CG2-0006bU-GO for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 May 2016 21:08:18 +0200 Original-Received: from localhost ([::1]:41015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4CG1-0002k6-GU for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 May 2016 15:08:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4CFs-0002ig-E2 for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 15:08:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4CFo-0003C4-0Z for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 15:08:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4CFn-0003Ao-TJ for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 15:08:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b4CFm-0005D2-Ka for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 15:08:02 -0400 Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 May 2016 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 16856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Mail-Followup-To: 16856@debbugs.gnu.org, andlind@gmail.com, andlind@gmail.com Original-Received: via spool by 16856-done@debbugs.gnu.org id=D16856.146385768120013 (code D ref 16856); Sat, 21 May 2016 19:08:02 +0000 Original-Received: (at 16856-done) by debbugs.gnu.org; 21 May 2016 19:08:01 +0000 Original-Received: from localhost ([127.0.0.1]:60167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4CFl-0005Cj-2p for submit@debbugs.gnu.org; Sat, 21 May 2016 15:08:01 -0400 Original-Received: from mail-vk0-f68.google.com ([209.85.213.68]:34424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4CFj-0005CV-HY for 16856-done@debbugs.gnu.org; Sat, 21 May 2016 15:07:59 -0400 Original-Received: by mail-vk0-f68.google.com with SMTP id v68so21389298vka.1 for <16856-done@debbugs.gnu.org>; Sat, 21 May 2016 12:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=rYgBpwHeYloVZHZCR0GZxhWAxU2eN43Cny4dKudYKeg=; b=Cs4XVnHrQUjxzQErQEgBUkY3DUhokk3ZopwZV//69kXMv1QiTT5wg4inSjRmaPHXfP T5u61pOq+M4OtfIdprOHZ+65+O2BXNEA8ZZC9fi90GCjlPjc2kRlQzHBAiEggBAuZFGP V/a5omIMC/yCn0irUy87Ou/ETxD4faLdcEY1r04CTdG7JPtSVeBd0t2urnc2rMVjhfWu Fl12kt+8w3STq8DqcW66VMyUP3JvTrCy+As8ERv1w1bEOE0pZ/n8Gn+JG5NMSeL6lV2e 0zrgoghdqHlTxWGgf0XHWELR1vlDimsf4PuRvHfMlEDD8KC4TjvPjcAKQKYcf7MkyY7/ n4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=rYgBpwHeYloVZHZCR0GZxhWAxU2eN43Cny4dKudYKeg=; b=fIg1LNEm9T0GbIeqEMI2i5UFTen66e/tCVeqttXZZEFJWhR8qoZWG+21PC5wlcmouQ yForRbgHCRhoGTm8s5xBMpGphXuFQ/2LMwigs3NDVl8OOdp3mdmN6BbYPnt3X/FpX/PG +ii9YJxmCbgEb/yEQ83ITwP/ZUwv2lMR0GEd7Sn8hDJ77UlBD2CsooWqRZ6GDK1Z/eaS p+oX+uyIxb2jerrCWctuU+PHoe0r7TJjOqucHtkE2E4Ph3NLgv6W88QlAWQ5773bGqqz EXFTTj491ac+uBe0s3BzvefM0fgUs79DLTs97AWZNB/8QZFUE1W9yS12En3eDK6GaZ/3 XsrQ== X-Gm-Message-State: AOPr4FXdnXwcNrjK7y/BSkMtl+63M4pg96M8llFiuR8aqQ3hVnvXb9qwsgYQlzBTlHEEIOikaw5RUP2cXZMmyw== X-Received: by 10.176.66.3 with SMTP id i3mr5296992uai.47.1463857673822; Sat, 21 May 2016 12:07:53 -0700 (PDT) Original-Received: by 10.31.216.195 with HTTP; Sat, 21 May 2016 12:07:53 -0700 (PDT) In-Reply-To: <20160521073536.GA95517@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118520 Archived-At: --94eb2c0b5038a66ae405335eec88 Content-Type: text/plain; charset=UTF-8 Closed. Fixed by Alan Third, see the following for details: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e5015c5d9632a0bf685c093249ae4a7d3e825b13 -- Anders On Sat, May 21, 2016 at 9:35 AM, Alan Third wrote: > On Fri, May 20, 2016 at 09:33:52PM +0200, Anders Lindgren wrote: > > Hi! > > > > I gave this patch a try. > > > > It works well, the ns port now behaves like the win32 and gtk+ parts of > > Emacs. > > > > Do you want me to push it to master? > > If you could, thanks. > > > Ps. When the text area doesn't partially overlap a column, the cursor can > > be drawn in the fringe. It's a bit unfortunate that when it do overlap, > > only the part of the cursor in the text area is drawn. A worst case > > scenario is that only a single pixel of the cursor is visible. An ideal > > solution would be to draw the cursor partially in the text area and > > partially in the fringe, but without leaving garbage behind when moved. > > However, this is nothing that we can solve here and now as it would > require > > change to all emacs ports and possibly the core system. > > Yeah, I was thinking about this but couldn't really see much of a way > around it. I checked the gtk+ and windows ports operated this way just > to be sure I wasn't introducing another bug as it does seem wrong. :) > -- > Alan Third > --94eb2c0b5038a66ae405335eec88 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Closed.

Fixed by Alan Third, see the fo= llowing for details:


=C2=A0 =C2=A0 -= - Anders

On Sat, May 21, 2016 at 9:35 AM, Alan Third <alan@idiocy.org> wrote:
On Fri, May 20= , 2016 at 09:33:52PM +0200, Anders Lindgren wrote:
> Hi!
>
> I gave this patch a try.
>
> It works well, the ns port now behaves like the win32 and gtk+ parts o= f
> Emacs.
>
> Do you want me to push it to master?

If you could, thanks.

> Ps. When the text area doesn't partially overlap a column, the cur= sor can
> be drawn in the fringe. It's a bit unfortunate that when it do ove= rlap,
> only the part of the cursor in the text area is drawn. A worst case > scenario is that only a single pixel of the cursor is visible. An idea= l
> solution would be to draw the cursor partially in the text area and > partially in the fringe, but without leaving garbage behind when moved= .
> However, this is nothing that we can solve here and now as it would re= quire
> change to all emacs ports and possibly the core system.

Yeah, I was thinking about this but couldn't really see much of = a way
around it. I checked the gtk+ and windows ports operated this way just
to be sure I wasn't introducing another bug as it does seem wrong. :) --
Alan Third

--94eb2c0b5038a66ae405335eec88--