From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk Date: Tue, 26 Nov 2013 18:03:38 +0100 Message-ID: References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> <5294CA19.7020605@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0102e6da3a212104ec177627 X-Trace: ger.gmane.org 1385485456 1924 80.91.229.3 (26 Nov 2013 17:04:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 17:04:16 +0000 (UTC) Cc: Dmitry Antipov , 15957@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 18:04:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VlM3g-0005AB-H5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2013 18:04:20 +0100 Original-Received: from localhost ([::1]:60110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlM3g-0003PT-1r for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2013 12:04:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlM3X-0003IB-7M for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2013 12:04:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlM3P-0007tW-35 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2013 12:04:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlM3O-0007tB-VV for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2013 12:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VlM3O-0002nK-BA for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2013 12:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2013 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15957-submit@debbugs.gnu.org id=B15957.138548542710716 (code B ref 15957); Tue, 26 Nov 2013 17:04:02 +0000 Original-Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 17:03:47 +0000 Original-Received: from localhost ([127.0.0.1]:46199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlM39-0002ml-Az for submit@debbugs.gnu.org; Tue, 26 Nov 2013 12:03:47 -0500 Original-Received: from mail-wi0-f169.google.com ([209.85.212.169]:55520) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlM36-0002mW-PJ for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 12:03:45 -0500 Original-Received: by mail-wi0-f169.google.com with SMTP id hm6so6169935wib.0 for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 09:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7gl91aiSpkRctQbuyIXt6mQX0ik+vvmzScHyZG8c0s4=; b=e/YjHlltNdtKtrV5NAIHOHWW1+3Bt65JL+CSdVcFZSNSgmYEHrSQHZhhl5/razG1P8 J2vmf96elovB0qJkEQsnTGj7hMuB3K4XMh3qnU6hijxnoZaNZ2BnjcgqvYj9XyipjTO9 XVFO34pJIUiEosGMFsxOckxh21CYTyLmaNyXE/1/NnKloSrwddDh7or+PolHT2GwcpXS P1rMiDMfBBscvKWn4cBwnu2e8SKGnCA89USf2bhRNlMPmSWRmmax7aQIXMqK4RkyVkFN AtydHz+jjNegsjR5Ho1oH33oDVLvEg6ON36zmpgB0WBvsmsD8YmpItvmEJRU6m4a1X9i kvyA== X-Received: by 10.194.109.68 with SMTP id hq4mr27876929wjb.12.1385485418764; Tue, 26 Nov 2013 09:03:38 -0800 (PST) Original-Received: by 10.216.124.76 with HTTP; Tue, 26 Nov 2013 09:03:38 -0800 (PST) In-Reply-To: <5294CA19.7020605@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80995 Archived-At: --089e0102e6da3a212104ec177627 Content-Type: text/plain; charset=ISO-8859-1 YES!!! That did the trick! When it comes to the first patch you sent, I just realized that it do fix another problem I've experienced (but not yet reported). When scrolling with a simple C-v and follow-mode is enabled, the other window only followed every second time the command was issued. In other words, I think that both patches should be applied. Thanks a bunch, I really appreciate it! -- Anders On Tue, Nov 26, 2013 at 5:19 PM, martin rudalics wrote: > Unfortunately, the problem is still there, as far as I can see. >> > > Too bad. And if you applied the below? > > martin > > > > === modified file 'src/window.c' > --- src/window.c 2013-11-06 18:41:31 +0000 > +++ src/window.c 2013-11-26 16:14:03 +0000 > @@ -1574,6 +1574,7 @@ > if (NILP (noforce)) > w->force_start = 1; > w->update_mode_line = 1; > + w->window_end_valid = 0; > if (w != XWINDOW (selected_window)) > /* Enforce full redisplay. FIXME: make it more selective. */ > windows_or_buffers_changed = 26; > @@ -4286,6 +4287,7 @@ > > else > window_scroll_line_based (window, n, whole, noerror); > > + XWINDOW (window)->window_end_valid = 0; > immediate_quit = 0; > } > > > > > --089e0102e6da3a212104ec177627 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
YES!!!

That did the trick!
When it comes to the first patch you sent, I just realized tha= t it do fix another problem I've experienced (but not yet reported). Wh= en scrolling with a simple C-v and follow-mode is enabled, the other window= only followed every second time the command was issued.

In other words, I think that both patches should be app= lied.

Thanks a bunch, I really appreciate it!

=A0 =A0 -- Anders


On Tue, Nov 26, 2013 at 5:19 PM, martin = rudalics <rudalics@gmx.at> wrote:
Unfortunately, the problem is still there, as far as I can see.

Too bad. =A0And if you applied the below?

martin



=3D=3D=3D modified file 'src/window.c'
--- src/window.c =A0 =A0 =A0 =A02013-11-06 18:41:31 +0000
+++ src/window.c =A0 =A0 =A0 =A02013-11-26 16:14:03 +0000
@@ -1574,6 +1574,7 @@
=A0 =A0if (NILP (noforce))
=A0 =A0 =A0w->force_start =3D 1;
=A0 =A0w->update_mode_line =3D 1;
+ =A0w->window_end_valid =3D 0;
=A0 =A0if (w !=3D XWINDOW (selected_window))
=A0 =A0 =A0/* Enforce full redisplay. =A0FIXME: make it more selective. =A0= */
=A0 =A0 =A0windows_or_buffers_changed =3D 26;
@@ -4286,6 +4287,7 @@

=A0 =A0else
=A0 =A0 =A0window_scroll_line_based (window, n, whole, noerror);

+ =A0XWINDOW (window)->window_end_valid =3D 0;
=A0 =A0immediate_quit =3D 0;
=A0}





--089e0102e6da3a212104ec177627--