From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#22169: 25.0.50; File name compiletion doesn't work with non-ASCII characters on OS X Date: Thu, 17 Dec 2015 23:01:01 +0100 Message-ID: References: <83y4cw3kie.fsf@gnu.org> <83twnk3fg1.fsf@gnu.org> <83oads2x99.fsf@gnu.org> <83io3z3drh.fsf@gnu.org> <831tan32q2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1144f9228d29a205271f2885 X-Trace: ger.gmane.org 1450389744 26722 80.91.229.3 (17 Dec 2015 22:02:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Dec 2015 22:02:24 +0000 (UTC) Cc: 22169@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 17 23:02:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a9gco-0006hu-7h for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Dec 2015 23:02:14 +0100 Original-Received: from localhost ([::1]:57393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gcn-00080N-MY for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Dec 2015 17:02:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gcf-0007sg-Rh for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2015 17:02:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9gcc-0003qm-IX for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2015 17:02:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9gcc-0003qi-Fb for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2015 17:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1a9gcc-0002VL-99 for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2015 17:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Dec 2015 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22169 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22169-submit@debbugs.gnu.org id=B22169.14503896699568 (code B ref 22169); Thu, 17 Dec 2015 22:02:02 +0000 Original-Received: (at 22169) by debbugs.gnu.org; 17 Dec 2015 22:01:09 +0000 Original-Received: from localhost ([127.0.0.1]:54811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a9gbk-0002UE-Uv for submit@debbugs.gnu.org; Thu, 17 Dec 2015 17:01:09 -0500 Original-Received: from mail-vk0-f45.google.com ([209.85.213.45]:34761) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a9gbj-0002Tp-42 for 22169@debbugs.gnu.org; Thu, 17 Dec 2015 17:01:07 -0500 Original-Received: by mail-vk0-f45.google.com with SMTP id j66so54884978vkg.1 for <22169@debbugs.gnu.org>; Thu, 17 Dec 2015 14:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=tG+XEexpzyYkmCXBJdjwr61FrRJndpYCHW823hk/uVQ=; b=wIZnORYHJvl+o/3Iwb2FUzc2rL/vd1QaHuW/F3gzP0fBKq2ldTr3H4HamYXvm10Xda RZOIiM5EprPGrOtAx9kPWeoX13lBvbLKi6jz/lr/YDKOxQcsVyw9RNmO2SYPFbOzoby6 i4lDzRd7Tr+PXGPSsR5ngpCUwx34I/EWOiDZF0T2JbvceoFE77L+v212lydp8E34AgBe Xc0Xg0MV8heENa0yVC5PX6m0RvvkLIE9PmE241SIs20n+0FFh1GaH368FL9WI/+I226s iE4FQ9ygemy7xYzTYFLbUpPhtEDhTO0iJg0VpYujt+JLIuyyT064d309UaQaQzkT7z/7 pf4w== X-Received: by 10.31.138.20 with SMTP id m20mr88225vkd.70.1450389661235; Thu, 17 Dec 2015 14:01:01 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Thu, 17 Dec 2015 14:01:01 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110094 Archived-At: --001a1144f9228d29a205271f2885 Content-Type: multipart/alternative; boundary=001a1144f9228d299e05271f2883 --001a1144f9228d299e05271f2883 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi! I think I have solved this. The current coding system defined in ns-win.el didn't work because it only provided a decode but no encode functions. After revisiting the "hfs" encoder, I managed to get it to work, this time. Below is a patch where I have dropped the old encoder and use the new instead. The only thing noteworthy is that `ucs-normalize' is loaded by loadup (when ns is used) and thus included in the dumped Emacs (if I understand correctly). Unless anybody objects, I'll push it in a couple of days. -- Anders On Tue, Dec 15, 2015 at 9:05 PM, Anders Lindgren wrote: > Hi, > > >> Can you write a patch to that effect, for emacs-25 branch? >> > > We have the find the cause of the problem first. But once we do that, thi= s > should be straight forward. > > > > What does this return: >> > >> > M-: (file-name-all-completion "=C3=A5=C3=A4=C3=B6" "/that/empty/di= rectory/") RET >> > >> > It returns nil. >> >> So this is the heart of the problem. I assume that if you do the same >> with an ASCII first argument, the result is non-nil, yes? >> > > Yes. > > > >> Then the next step is to step with a debugger through >> file_name_completion, and see why this returns nil instead of a list >> of files that begin. >> > > Auhm, I'll see what I can do. I'm a family father and have very, very, > limited time, but I can see in I can find a time slot for it. > > -- Anders > > --001a1144f9228d299e05271f2883 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!

I think I have solved this.

The current coding system defined in ns-win.el didn't= work because it only provided a decode but no encode functions.
=
After revisiting the "hfs" encoder, I managed to g= et it to work, this time.

Below is a patch where I= have dropped the old encoder and use the new instead. The only thing notew= orthy is that `ucs-normalize' is loaded by loadup (when ns is used) and= thus included in the dumped Emacs (if I understand correctly). Unless anyb= ody objects, I'll push it in a couple of days.

=C2=A0 =C2=A0 -- Anders

On Tue, Dec 15, 2015 at 9:05 PM, Anders Lindgren <andli= nd@gmail.com> wrote:
Hi,
=C2=A0
Can yo= u write a patch to that effect, for emacs-25 branch?
<= br>
We have the find the cause of the problem first. But o= nce we do that, this should be straight forward.


>=C2=A0 = =C2=A0 =C2=A0What does this return:
>
>=C2=A0 =C2=A0 =C2=A0M-: (file-name-all-completion "=C3=A5=C3=A4=C3= =B6" "/that/empty/directory/") RET
>
> It returns nil.

So this is the heart of the problem.=C2=A0 I assume that if you do t= he same
with an ASCII first argument, the result is non-nil, yes?
<= div>
Yes.=C2=A0

<= div>=C2=A0
Then the next step is to ste= p with a debugger through
file_name_completion, and see why this returns nil instead of a list
of files that begin.

Auhm, I'= ;ll see what I can do. I'm a family father and have very, very, limited= time, but I can see in I can find a time slot for it.

=C2=A0 =C2=A0 -- Anders=


--001a1144f9228d299e05271f2883-- --001a1144f9228d29a205271f2885 Content-Type: text/plain; charset=US-ASCII; name="coding.diff" Content-Disposition: attachment; filename="coding.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iiasj1mk0 ZGlmZiAtLWdpdCBhL2xpc3AvbG9hZHVwLmVsIGIvbGlzcC9sb2FkdXAuZWwKaW5kZXggZjBjYWE4 Yi4uZGRhNDMzZSAxMDA2NDQKLS0tIGEvbGlzcC9sb2FkdXAuZWwKKysrIGIvbGlzcC9sb2FkdXAu ZWwKQEAgLTI3Niw2ICsyNzYsNyBAQAogKGlmIChmZWF0dXJlcCAnbnMpCiAgICAgKHByb2duCiAg ICAgICAobG9hZCAidGVybS9jb21tb24td2luIikKKyAgICAgIChsb2FkICJpbnRlcm5hdGlvbmFs L3Vjcy1ub3JtYWxpemUiKQogICAgICAgKGxvYWQgInRlcm0vbnMtd2luIikpKQogKGlmIChmYm91 bmRwICd4LWNyZWF0ZS1mcmFtZSkKICAgICA7OyBEbyBpdCBhZnRlciBsb2FkaW5nIHRlcm0vZm9v LXdpbi5lbCBzaW5jZSB0aGUgdmFsdWUgb2YgdGhlCmRpZmYgLS1naXQgYS9saXNwL3Rlcm0vbnMt d2luLmVsIGIvbGlzcC90ZXJtL25zLXdpbi5lbAppbmRleCAwYjNlM2JkLi45YmQ1OWZjIDEwMDY0 NAotLS0gYS9saXNwL3Rlcm0vbnMtd2luLmVsCisrKyBiL2xpc3AvdGVybS9ucy13aW4uZWwKQEAg LTUxLDYgKzUxLDcgQEAKIChyZXF1aXJlICdtZW51LWJhcikKIChyZXF1aXJlICdmb250c2V0KQog KHJlcXVpcmUgJ2RuZCkKKyhyZXF1aXJlICd1Y3Mtbm9ybWFsaXplKQogCiAoZGVmZ3JvdXAgbnMg bmlsCiAgICJHTlVzdGVwL01hYyBPUyBYIHNwZWNpZmljIGZlYXR1cmVzLiIKQEAgLTMzNywyOSAr MzM4LDEyIEBAIG5zLWRlbGV0ZS13b3JraW5nLXRleHQKICAgKHNldHEgbnMtd29ya2luZy1vdmVy bGF5IG5pbCkpCiAKIAotKGRlY2xhcmUtZnVuY3Rpb24gbnMtY29udmVydC11dGY4LW5mZC10by1u ZmMgIm5zZm5zLm0iIChzdHIpKQotCi07Ozs7IE9TIFggZmlsZSBzeXN0ZW0gVW5pY29kZSBVVEYt OCBORkQgKGRlY29tcG9zZWQgZm9ybSkgc3VwcG9ydAotOzsgTGlzcCBjb2RlIGJhc2VkIG9uIHV0 Zi04bS5lbCwgYnkgU2VpamkgWmVuaXRhbmksIEVpamkgSG9uam9oLCBhbmQKLTs7IENhcnN0ZW4g Qm9ybWFubi4KKzs7IE9TIFggZmlsZSBzeXN0ZW0gVW5pY29kZSBVVEYtOCBORkQgKGRlY29tcG9z ZWQgZm9ybSkgc3VwcG9ydC4KICh3aGVuIChlcSBzeXN0ZW0tdHlwZSAnZGFyd2luKQotICAoZGVm dW4gbnMtdXRmOC1uZmQtcG9zdC1yZWFkLWNvbnZlcnNpb24gKGxlbmd0aCkKLSAgICAiQ2FsbHMg YG5zLWNvbnZlcnQtdXRmOC1uZmQtdG8tbmZjJyB0byBjb21wb3NlIGNoYXIgc2VxdWVuY2VzLiIK LSAgICAoc2F2ZS1leGN1cnNpb24KLSAgICAgIChzYXZlLXJlc3RyaWN0aW9uCi0gICAgICAgIChu YXJyb3ctdG8tcmVnaW9uIChwb2ludCkgKCsgKHBvaW50KSBsZW5ndGgpKQotICAgICAgICAobGV0 ICgoc3RyIChidWZmZXItc3RyaW5nKSkpCi0gICAgICAgICAgKGRlbGV0ZS1yZWdpb24gKHBvaW50 LW1pbikgKHBvaW50LW1heCkpCi0gICAgICAgICAgKGluc2VydCAobnMtY29udmVydC11dGY4LW5m ZC10by1uZmMgc3RyKSkKLSAgICAgICAgICAoLSAocG9pbnQtbWF4KSAocG9pbnQtbWluKSkpKSkp Ci0KLSAgKGRlZmluZS1jb2Rpbmctc3lzdGVtICd1dGYtOC1uZmQKLSAgICAiVVRGLTggTkZEIChk ZWNvbXBvc2VkKSBlbmNvZGluZy4iCi0gICAgOmNvZGluZy10eXBlICd1dGYtOAotICAgIDptbmVt b25pYyA/VQotICAgIDpjaGFyc2V0LWxpc3QgJyh1bmljb2RlKQotICAgIDpwb3N0LXJlYWQtY29u dmVyc2lvbiAnbnMtdXRmOC1uZmQtcG9zdC1yZWFkLWNvbnZlcnNpb24pCi0gIChzZXQtZmlsZS1u YW1lLWNvZGluZy1zeXN0ZW0gJ3V0Zi04LW5mZCkpCisgIDs7IFVzZWQgcHJpb3IgdG8gRW1hY3Mg MjUuCisgIChkZWZpbmUtY29kaW5nLXN5c3RlbS1hbGlhcyAndXRmLTgtbmZkICd1dGYtOC1oZnMp CisKKyAgKHNldC1maWxlLW5hbWUtY29kaW5nLXN5c3RlbSAndXRmLTgtaGZzKSkKIAogOzs7OyBJ bnRlci1hcHAgY29tbXVuaWNhdGlvbnMgc3VwcG9ydC4KIApkaWZmIC0tZ2l0IGEvc3JjL25zZm5z Lm0gYi9zcmMvbnNmbnMubQppbmRleCBlZGMwMmU4Li41ZmE2OGMwIDEwMDY0NAotLS0gYS9zcmMv bnNmbnMubQorKysgYi9zcmMvbnNmbnMubQpAQCAtMjA5OSwzOSArMjA5OSw2IEBAIHRoZXJlIHdh cyBubyByZXN1bHQuICAqLykKIH0KIAogCi1ERUZVTiAoIm5zLWNvbnZlcnQtdXRmOC1uZmQtdG8t bmZjIiwgRm5zX2NvbnZlcnRfdXRmOF9uZmRfdG9fbmZjLAotICAgICAgIFNuc19jb252ZXJ0X3V0 ZjhfbmZkX3RvX25mYywgMSwgMSwgMCwKLSAgICAgICBkb2M6IC8qIFJldHVybiBhbiBORkMgc3Ry aW5nIHRoYXQgbWF0Y2hlcyB0aGUgVVRGLTggTkZEIHN0cmluZyBTVFIuICAqLykKLSAgICAgKExp c3BfT2JqZWN0IHN0cikKLXsKLS8qIFRPRE86IElmIEdOVXN0ZXAgZXZlciBpbXBsZW1lbnRzIHBy ZWNvbXBvc2VkU3RyaW5nV2l0aENhbm9uaWNhbE1hcHBpbmcsCi0gICAgICAgICByZW1vdmUgdGhp cy4gKi8KLSAgTlNTdHJpbmcgKnV0ZlN0cjsKLSAgTGlzcF9PYmplY3QgcmV0ID0gUW5pbDsKLSAg TlNBdXRvcmVsZWFzZVBvb2wgKnBvb2w7Ci0KLSAgQ0hFQ0tfU1RSSU5HIChzdHIpOwotICBwb29s ID0gW1tOU0F1dG9yZWxlYXNlUG9vbCBhbGxvY10gaW5pdF07Ci0gIHV0ZlN0ciA9IFtOU1N0cmlu ZyBzdHJpbmdXaXRoVVRGOFN0cmluZzogU1NEQVRBIChzdHIpXTsKLSNpZmRlZiBOU19JTVBMX0NP Q09BCi0gIGlmICh1dGZTdHIpCi0gICAgdXRmU3RyID0gW3V0ZlN0ciBwcmVjb21wb3NlZFN0cmlu Z1dpdGhDYW5vbmljYWxNYXBwaW5nXTsKLSNlbmRpZgotICBpZiAodXRmU3RyKQotICAgIHsKLSAg ICAgIGNvbnN0IGNoYXIgKmNzdHIgPSBbdXRmU3RyIFVURjhTdHJpbmddOwotICAgICAgaWYgKGNz dHIpCi0gICAgICAgIHJldCA9IGJ1aWxkX3N0cmluZyAoY3N0cik7Ci0gICAgfQotCi0gIFtwb29s IHJlbGVhc2VdOwotICBpZiAoTklMUCAocmV0KSkKLSAgICBlcnJvciAoIkludmFsaWQgVVRGLTgi KTsKLQotICByZXR1cm4gcmV0OwotfQotCi0KICNpZmRlZiBOU19JTVBMX0NPQ09BCiAKIC8qIENv bXBpbGUgYW5kIGV4ZWN1dGUgdGhlIEFwcGxlU2NyaXB0IFNDUklQVCBhbmQgcmV0dXJuIHRoZSBl cnJvcgpAQCAtMzIwNyw3ICszMTc0LDYgQEAgYmUgdXNlZCBhcyB0aGUgaW1hZ2Ugb2YgdGhlIGlj b24gcmVwcmVzZW50aW5nIHRoZSBmcmFtZS4gICovKTsKICAgZGVmc3ViciAoJlNuc19lbWFjc19p bmZvX3BhbmVsKTsKICAgZGVmc3ViciAoJlNuc19saXN0X3NlcnZpY2VzKTsKICAgZGVmc3ViciAo JlNuc19wZXJmb3JtX3NlcnZpY2UpOwotICBkZWZzdWJyICgmU25zX2NvbnZlcnRfdXRmOF9uZmRf dG9fbmZjKTsKICAgZGVmc3ViciAoJlNuc19wb3B1cF9mb250X3BhbmVsKTsKICAgZGVmc3ViciAo JlNuc19wb3B1cF9jb2xvcl9wYW5lbCk7CiAK --001a1144f9228d29a205271f2885--