From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.bugs Subject: bug#21701: Fwd: cl-typecase broken (was 25.0.50; ert explainer for equal can't handle negative numbers) Date: Sat, 5 Dec 2015 16:08:23 +0100 Message-ID: References: <98d1ul4y9u.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1144f922c532de052627feac X-Trace: ger.gmane.org 1449328162 9162 80.91.229.3 (5 Dec 2015 15:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Dec 2015 15:09:22 +0000 (UTC) Cc: 21701@debbugs.gnu.org, Stefan Monnier To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 05 16:09:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a5ESV-0004YF-Ny for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Dec 2015 16:09:11 +0100 Original-Received: from localhost ([::1]:46801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5ESU-0004o2-HO for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Dec 2015 10:09:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5ESQ-0004nx-M8 for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 10:09:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5ESM-00053y-JD for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 10:09:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5ESM-00053u-Fn for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 10:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a5ESL-0003eK-VW for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2015 10:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Anders Lindgren Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Dec 2015 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21701 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21701-submit@debbugs.gnu.org id=B21701.144932812514005 (code B ref 21701); Sat, 05 Dec 2015 15:09:01 +0000 Original-Received: (at 21701) by debbugs.gnu.org; 5 Dec 2015 15:08:45 +0000 Original-Received: from localhost ([127.0.0.1]:39991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5ES5-0003dp-7n for submit@debbugs.gnu.org; Sat, 05 Dec 2015 10:08:45 -0500 Original-Received: from mail-vk0-f53.google.com ([209.85.213.53]:35042) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5ERj-0003dD-Tj for 21701@debbugs.gnu.org; Sat, 05 Dec 2015 10:08:42 -0500 Original-Received: by vkha189 with SMTP id a189so81331195vkh.2 for <21701@debbugs.gnu.org>; Sat, 05 Dec 2015 07:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LRZpi1Ju4PMMSTHi6rSrRL3FdI33rN6jCbN9Nvugbrg=; b=CEbRc9r1ypADGVw82XzTG/VQdzz16ZXcJFgkSouG8AKlFAj1RVrSQ0290a5HJyvZ26 8y0nE/sYRIIVyblmc44ufEJXAi8kp43tXd0iQE9O+EDgJhhWa/GkQc+Pg0BX7D5iM6aE +SajdR8IPHrufbchpdc9c88CtIPmfSmvLJlu1zuROy+Ml5/YcqLbf/eUqgiMgCWwXT+t I2PPHdA93yk6m5/C38fZ0M94wTrj39zDceJOOa9FV5B9euzl2vqB3H5J2hxsc2JspEab 5Nj48MJOpz/st443foQAceESep0lfUrlh+nqmk0E1+2x9t4u1bxLvo5dTliR8gI7PBW9 fUlQ== X-Received: by 10.31.138.20 with SMTP id m20mr14410515vkd.70.1449328103461; Sat, 05 Dec 2015 07:08:23 -0800 (PST) Original-Received: by 10.31.210.133 with HTTP; Sat, 5 Dec 2015 07:08:23 -0800 (PST) In-Reply-To: <98d1ul4y9u.fsf@fencepost.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109646 Archived-At: --001a1144f922c532de052627feac Content-Type: multipart/alternative; boundary=001a1144f922c532d6052627feaa --001a1144f922c532d6052627feaa Content-Type: text/plain; charset=UTF-8 Hi, Two of the problems can be fixed with the attached patch. The third, `ert-test-record-backtrace' in `ert-tests.el' seems to compare backtrace output -- I haven't looked it as I have no idea what it is supposed to test. -- Anders On Fri, Dec 4, 2015 at 11:58 PM, Glenn Morris wrote: > Stefan Monnier wrote: > > > I installed a patch which makes ERT use pcase over cl-typecase. > > This causes test failures. > > http://hydra.nixos.org/build/28477383 > http://hydra.nixos.org/build/28477383/log/raw > > > FAILED ert-test-equal-including-properties > FAILED ert-test-explain-equal > FAILED ert-test-explain-equal-improper-list > FAILED ert-test-explain-equal-string-properties > FAILED ert-test-plist-difference-explanation > FAILED ert-test-run-tests-interactively > FAILED ert-test-run-tests-interactively-2 > --001a1144f922c532d6052627feaa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Two of the problems can be fixed wi= th the attached patch.

The third, `ert-test-record= -backtrace' in `ert-tests.el' seems to compare backtrace output -- = I haven't looked it as I have no idea what it is supposed to test.

=C2=A0 =C2=A0 -- Anders

On Fri, Dec 4, 2015 at 11:58 PM, Gle= nn Morris <rgm@gnu.org> wrote:
S= tefan Monnier wrote:

> I installed a patch which makes ERT use pcase over cl-typecase.

This causes test failures.

http://hydra.nixos.org/build/28477383
http://hydra.nixos.org/build/28477383/log/raw


=C2=A0 =C2=A0FAILED=C2=A0 ert-test-equal-including-properties
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-explain-equal
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-explain-equal-improper-list
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-explain-equal-string-properties
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-plist-difference-explanation
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-run-tests-interactively
=C2=A0 =C2=A0FAILED=C2=A0 ert-test-run-tests-interactively-2

--001a1144f922c532d6052627feaa-- --001a1144f922c532de052627feac Content-Type: text/plain; charset=US-ASCII; name="ert.diff" Content-Disposition: attachment; filename="ert.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iht8iiua0 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9lcnQuZWwgYi9saXNwL2VtYWNzLWxpc3AvZXJ0 LmVsCmluZGV4IGE3NWIyM2IuLjAyYWU0MWIgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9l cnQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2VydC5lbApAQCAtNTE1LDcgKzUxNSw3IEBAIGVy dC0tZXhwbGFpbi1lcXVhbC1yZWMKICAgICAgICAgICAgICAgICAgIGZvciB4aSA9IChlcnQtLWV4 cGxhaW4tZXF1YWwtcmVjIGFpIGJpKQogICAgICAgICAgICAgICAgICAgZG8gKHdoZW4geGkgKGNs LXJldHVybiBgKGFycmF5LWVsdCAsaSAseGkpKSkKICAgICAgICAgICAgICAgICAgIGZpbmFsbHkg KGNsLWFzc2VydCAoZXF1YWwgYSBiKSB0KSkpKQotICAgICAgKChwcmVkIGF0b21wKQorICAgICAg KChwcmVkIGF0b20pCiAgICAgICAgKGlmIChub3QgKGVxdWFsIGEgYikpCiAgICAgICAgICAgIChp ZiAoYW5kIChzeW1ib2xwIGEpIChzeW1ib2xwIGIpIChzdHJpbmc9IGEgYikpCiAgICAgICAgICAg ICAgICBgKGRpZmZlcmVudC1zeW1ib2xzLXdpdGgtdGhlLXNhbWUtbmFtZSAsYSAsYikKQEAgLTEw NzEsNyArMTA3MSw3IEBAIGVydC0taW5zZXJ0LWh1bWFuLXJlYWRhYmxlLXNlbGVjdG9yCiAgICAg ICAgICAgICAgICAgICAgICAobWFrZS1zeW1ib2wgIjx1bm5hbWVkIHRlc3Q+IikpKQogICAgICAg ICAgICAgICAgICAgKGAoLG9wZXJhdG9yIC4gLG9wZXJhbmRzKQogICAgICAgICAgICAgICAgICAg IChwY2FzZSBvcGVyYXRvcgotICAgICAgICAgICAgICAgICAgICAgKChvciAnZXFsICdhbmQgJ25v dCAnb3IpCisgICAgICAgICAgICAgICAgICAgICAoKG9yICdtZW1iZXIgJ2VxbCAnYW5kICdub3Qg J29yKQogICAgICAgICAgICAgICAgICAgICAgIGAoLG9wZXJhdG9yICxAKG1hcGNhciAjJ3JlYyBv cGVyYW5kcykpKQogICAgICAgICAgICAgICAgICAgICAgKChvciAndGFnICdzYXRpc2ZpZXMpCiAg ICAgICAgICAgICAgICAgICAgICAgc2VsZWN0b3IpKSkpKSkK --001a1144f922c532de052627feac--