all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Anders Lindgren <andlind@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23276@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#23276: 25.0.92; Crash in auto-revert when file no longer present
Date: Sat, 16 Apr 2016 22:56:41 +0200	[thread overview]
Message-ID: <CABr8ebY7S4FLcVSAxcooo7q92Oou4-3ye8FveTjz-N95Km03EQ@mail.gmail.com> (raw)
In-Reply-To: <83fuulbcq7.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

>
> And I still am not convinced that deleting a file under auto-revert
> shouldn't erase its buffer.  Otherwise, it sounds like just
> half-auto-revert to me.  Would we keep the buffer non-empty if the
> file existed but was empty?
>

When I originally wrote auto-revert mode I decided that Emacs should not
clear a buffer when the corresponding file was removed, as a safeguard
against a file accidentally being removed. Today, I still think that is the
correct way to handle this situation.

The current patch handles a special case when the file is removed after it
has been decided that it should be reverted, but right before the actual
revert -- it should be treated just like a normal file delete.

I think disabling auto-revert mode is not correct way to handle this -- the
file might be temporary removed by, say, a version control system and might
reappear a moment later, in which case we want it to be reverted into Emacs.

    -- Anders

[-- Attachment #2: Type: text/html, Size: 1280 bytes --]

  parent reply	other threads:[~2016-04-16 20:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 11:07 bug#23276: 25.0.92; Crash in auto-revert when file no longer present Anders Lindgren
2016-04-12 15:16 ` Eli Zaretskii
2016-04-12 16:14   ` Michael Albinus
2016-04-16 18:44 ` Michael Albinus
2016-04-16 18:55   ` Anders Lindgren
2016-04-16 20:56     ` Michael Albinus
2016-04-16 19:00   ` Eli Zaretskii
2016-04-16 20:35     ` Michael Albinus
2016-04-16 20:56     ` Anders Lindgren [this message]
2016-04-16 21:30       ` Michael Albinus
2016-04-17  1:54     ` John Wiegley
2016-04-17  2:39       ` Eli Zaretskii
2016-04-17  2:53         ` John Wiegley
2016-04-17  2:57         ` John Mastro
2016-04-17  8:52           ` Michael Albinus
2016-04-18  8:26           ` Michael Albinus
2016-04-17 13:20         ` Óscar Fuentes
2016-04-17 15:16           ` Eli Zaretskii
2016-04-17 16:01             ` Óscar Fuentes
2016-04-17 16:10               ` Eli Zaretskii
2016-04-18  8:24       ` Michael Albinus
2020-12-29 20:02 ` bug#23276: autorevert for a deleted dired directory (ref: 23276) Boruch Baum
2020-12-29 20:13   ` Eli Zaretskii
2020-12-29 20:45     ` Boruch Baum
2020-12-29 20:24   ` Drew Adams
2020-12-29 21:18     ` Boruch Baum
2020-12-29 22:07       ` Drew Adams
2022-04-27 14:09   ` bug#23276: 25.0.92; Crash in auto-revert when file no longer present Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABr8ebY7S4FLcVSAxcooo7q92Oou4-3ye8FveTjz-N95Km03EQ@mail.gmail.com \
    --to=andlind@gmail.com \
    --cc=23276@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.