From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Anders Lindgren Newsgroups: gmane.emacs.devel Subject: Re: lisp/term/ns-win.el modification Date: Wed, 3 May 2017 22:40:07 +0200 Message-ID: References: <44D4AA3B-8F87-42B6-A2D2-00487B066183@gmail.com> <74D20593-63B6-46FB-BAC3-D841D0BCD461@gmail.com> <0A49E755-3D18-48E8-81D4-253160F60A16@gmail.com> <40f503a4-49eb-a3ff-fe5f-993c8f346c33@lanl.gov> <15112485-03CC-4FFF-8A9D-BA28D2490A91@gmail.com> <42CDF1D0-015D-4F0D-A8A2-A55776D34FEE@gmail.com> <83inlmkmqq.fsf@gnu.org> <5d3d3f3d-e49e-2b83-0591-14b3e19f8cb0@gmail.com> <834lx5lxz6.fsf@gnu.org> <7A82B268-C40B-4D45-8973-68A2408F7F28@gmail.com> <83r309jdcj.fsf@gnu.org> <00A24BD4-FE6F-4098-A8DD-73240899FA13@gmail.com> <83efw9j6l0.fsf@gnu.org> <0FED46C2-B8D7-40B3-BEF0-1515E7E5DE9F@gmail.com> <83wpa0iold.fsf@gnu.org> <72ADB3FE-F9A6-4030-A4F8-84C60A42040C@gmail.com> <83vapkilx4.fsf@gnu.org> <72EA8A0D-F889-4AC9-8E5E-45C2956E5CAD@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c122dbe74c6d2054ea4a920 X-Trace: blaine.gmane.org 1493844515 6207 195.159.176.226 (3 May 2017 20:48:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 May 2017 20:48:35 +0000 (UTC) Cc: emacs-devel To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 22:48:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d61CH-0001UO-Qg for ged-emacs-devel@m.gmane.org; Wed, 03 May 2017 22:48:30 +0200 Original-Received: from localhost ([::1]:38627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d61CN-0004ls-CO for ged-emacs-devel@m.gmane.org; Wed, 03 May 2017 16:48:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d614F-0005aM-IX for emacs-devel@gnu.org; Wed, 03 May 2017 16:40:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d614E-0005PE-Fw for emacs-devel@gnu.org; Wed, 03 May 2017 16:40:11 -0400 Original-Received: from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e]:33019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d614E-0005Ko-9q for emacs-devel@gnu.org; Wed, 03 May 2017 16:40:10 -0400 Original-Received: by mail-ua0-x22e.google.com with SMTP id j59so704763uad.0 for ; Wed, 03 May 2017 13:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=274YfhkLFuDiEO5sij2ajKYWVi4dumhrLWqMDMKQHU4=; b=b/VLkmPnWMk7wVC8y2pOCaxp1l8NHagCSJBFcSqwXtGPHv7zyjivRuYc9Pvd/N974T 9byhM9EuqLwJ8Jl5wRWzyGteTX5d/2g9o5qsuIwdYIOmse5+kB1PUGbBTL31/NCMIZqF N10jLDOxfgo/uDx6KU3xGrfYbfg/2SxZBxTPKObW8ZS8AVqsk6Cki1+QddcuHbjp4/K9 FlHjLY5IDUV2QN/n809Nn0XeXvX/k0bSmPmDXOGOG/rZMTGRJE8RY/nwoQ8xPrzPNqRQ f0R6y325PcxtLbOTD6RwaHLhDC0EuIqVukkNXV7CKrscHYnecVB87Wxt1AmZalB+sfB6 jBXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=274YfhkLFuDiEO5sij2ajKYWVi4dumhrLWqMDMKQHU4=; b=L0kjJN5nJRC8d5poXdC+K/kBsWyvJ9CUMSMZ7quqlDyNwX1qOzN3bPsW5FBrUbLqGB sZ4PxZ43ZzjWcN7Rzzxi8m+cdo4haXL4St5hpcosTzuFwCRfxeu+UbsoQsk+P7XjMtGw KVNYcRH6LqLxGNXbE0AfMKTgMr97UUzuIjzDW4CVu8g5loNv3kdHmUJ7hd6IJOZp4ls3 jaRfpBaWhwcvu/vuzmTBNw7/97thfllxw8128i56KE2T4oSAdN4bOdxvYHkKjY4ReJ0s mVgpuiTW5X7/vgtSazPSEW+foGieenn9ZLk65nlaTtevdJuxg99WDx8LfTxuwqbxAKx5 l2ng== X-Gm-Message-State: AN3rC/6MRPmjl3tLePwtDJWFBFWh3qum1mq8dIhuNw8CWA3L9Qm5EZKC weIM7jm6nR35VaPC69bV1faOuAGyjQ== X-Received: by 10.159.39.195 with SMTP id b61mr2322645uab.108.1493844008156; Wed, 03 May 2017 13:40:08 -0700 (PDT) Original-Received: by 10.31.64.140 with HTTP; Wed, 3 May 2017 13:40:07 -0700 (PDT) In-Reply-To: <72EA8A0D-F889-4AC9-8E5E-45C2956E5CAD@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214552 Archived-At: --94eb2c122dbe74c6d2054ea4a920 Content-Type: text/plain; charset=UTF-8 Hi! I just tested your latest patch. The code looks much cleaner now when you use `split-string'. (I didn't know it could all those tricks -- it's always good to learn something new!) The patch seems to work perfectly! Some minor details: * You no longer need the `(if (not (equal "" filestring"))' test -- when the OMIT-NULLS argument is non-nil, `split-string' ensures that the list doesn't contain empty strings. * You misspelled "trimmed" as "timmed" in the comment in `ns-open-file-service'. -- Anders On Tue, May 2, 2017 at 2:57 PM, Jean-Christophe Helary < jean.christophe.helary@gmail.com> wrote: > > > On May 2, 2017, at 1:25, Eli Zaretskii wrote: > > > >> From: Jean-Christophe Helary > >> Date: Tue, 2 May 2017 00:58:44 +0900 > >> > >> Ok, everything fixed here. I'll resend the patch when I am done with > the copyright paperwork and when I understand how to write a proper commit > log message (hopefully it will take me less time that it took to write this > patch... :) > > > > This contribution is short enough for us to accept it even without the > > paperwork. (I do encourage you to go on with paperwork, so that your > > future contributions will be accepted as well.) So just send the > > fixed patch with the log message, and someone will commit it for you. > > Ok, I'm not sure how to send the log message so I just copied it here. And > I've further simplified the patch so I'm attaching the newest and hopefully > last version here. > > Jean-Christophe > > Log message: > > =========================== > Multiline support in NS "open-file" service > > * lisp/term/ns-win.el (ns-open-file-service): new function. Wraps the > original call in a (split-string) to create as many calls as there are > lines. (ns-spi-service-call): use it. > =========================== > > --94eb2c122dbe74c6d2054ea4a920 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi!

I just tested your latest patch. Th= e code looks much cleaner now when you use `split-string'. (I didn'= t know it could all those tricks -- it's always good to learn something= new!)

The patch seems to work perfectly!

Some minor details:

* You no long= er need the `(if (not (equal "" filestring"))' test -- w= hen the OMIT-NULLS argument is non-nil, `split-string' ensures that the= list doesn't contain empty strings.

* You mis= spelled "trimmed" as "timmed" in the comment in `ns-ope= n-file-service'.

=C2=A0 =C2=A0 -- Anders
=

On Tue, May= 2, 2017 at 2:57 PM, Jean-Christophe Helary <jean.christo= phe.helary@gmail.com> wrote:

> On May 2, 2017, at 1:25, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Jean-Christophe Helary <jean.christophe.helary@gmail.com>
>> Date: Tue, 2 May 2017 00:58:44 +0900
>>
>> Ok, everything fixed here. I'll resend the patch when I am don= e with the copyright paperwork and when I understand how to write a proper = commit log message (hopefully it will take me less time that it took to wri= te this patch... :)
>
> This contribution is short enough for us to accept it even without the=
> paperwork.=C2=A0 (I do encourage you to go on with paperwork, so that = your
> future contributions will be accepted as well.)=C2=A0 So just send the=
> fixed patch with the log message, and someone will commit it for you.<= br>
Ok, I'm not sure how to send the log message so I just copied it= here. And I've further simplified the patch so I'm attaching the n= ewest and hopefully last version here.

Jean-Christophe

Log message:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D
Multiline support in NS "open-file" service

* lisp/term/ns-win.el (ns-open-file-service): new function. Wraps the origi= nal call in a (split-string) to create as many calls as there are lines. (n= s-spi-service-call): use it.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D


--94eb2c122dbe74c6d2054ea4a920--