From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#20664: 25.0.50; Customize: Link option or face name to the source definition Date: Thu, 17 Sep 2020 17:16:09 -0300 Message-ID: References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c6546c05af880e65" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Oleh Krehel , 20664@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 22:18:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJ0Mh-0004xt-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 22:18:47 +0200 Original-Received: from localhost ([::1]:56854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJ0Mg-0006Ks-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 16:18:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJ0L1-0005Vv-98 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJ0L0-0000Nn-8L for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJ0L0-0007eo-3v for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:17:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20664 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20664-submit@debbugs.gnu.org id=B20664.160037378829388 (code B ref 20664); Thu, 17 Sep 2020 20:17:02 +0000 Original-Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 20:16:28 +0000 Original-Received: from localhost ([127.0.0.1]:39205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0KS-0007dv-KB for submit@debbugs.gnu.org; Thu, 17 Sep 2020 16:16:28 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:52064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0KR-0007dk-Md for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 16:16:28 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id w2so3171513wmi.1 for <20664@debbugs.gnu.org>; Thu, 17 Sep 2020 13:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=pHDWb7C5mVnh/1pVRUislQAcdwedCB2SyYaNW0WIFGw=; b=ubaFnvXSSjZr5LngdLzKJi7Xl0S/HH4ZBiav7NWofDfv8VRc8Yw5R5lDtTZLdXovc9 vvO5kjwAIGq1htP4Kqh3wRz08MeVlq9u7aH/gbnp/t6Jb+sTvnwFPT7FOnsLkdv6hjH/ VJ/mCWWwh3D+T9KTcdx+VFHIPrksu217ZbhEbz+Hm9RzthSpCPTaAQvheShoqXvHPbI5 ulhgKQw28JKm/5EtC4q7EJfQBb3q24j4VqXWowuNL5gfMP39MAjvHIhPiEFNxlOHKAOO JbQnVRT+32GR4KF9J9vnCP8KOYaOcyrP3xqLAHcMyBKPWTU41pYhzzCw7YhihDwpghvP Ny1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=pHDWb7C5mVnh/1pVRUislQAcdwedCB2SyYaNW0WIFGw=; b=AvoFybAstGomdyIDeLTLvU9F9U2A01vshqCLMe5elGRaNxtoK3dK8m949Hcyb/GeUM Z6Wyh8jHZRXuu6hrCDQB69RRJ/KClcFxhir7mjz1vgDS4Vp8HXzJ/EIOhGYNo1u38CmY d5Yj49aivjspCHfh6DgcyRKooo+GXNTlINWUcvUD9dr/sAreoM2T0aOwKz5Pxj+ORn8z FONRpRv7Ayl2H8DeydlGMn468bhwkeNYJCDjj/JUptm8alMA+E51pkc2qB2AVu1HJ6kK OCYEE1RjsdEsHjn3KJYcj9mRjV7TGTyMuxe1yrfYkNgk+HUaD6KyTnUGImSR6ue2kfig z7vA== X-Gm-Message-State: AOAM533j1+R39FASAi9MHAiIOju23X+AI34AWMX9ObsnQyETABrPDFsy QzrI1W5lrqcZ4k997K2tAcbfxOJamDbXZi922PQ= X-Google-Smtp-Source: ABdhPJznP9KJjz9TFd3hme7LNRdtLTn+A3D9pqc9xOHMwmzxiShUb2ROxjkRalvPIOHNnZBZoH7HBWbyCqXu+zG/Hv0= X-Received: by 2002:a1c:23c9:: with SMTP id j192mr12261261wmj.6.1600373781843; Thu, 17 Sep 2020 13:16:21 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188252 Archived-At: --000000000000c6546c05af880e65 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Oleh Krehel writes: > >> * lisp/cus-edit.el (custom-face-value-create): Make the face name into >> a button that calls `find-face-definition'. > > [...] > >> + (setq opoint (point)) >> + ;; Face name (tag). >> + (insert " " tag) >> + (make-button opoint (point) >> + 'follow-link t >> + 'action (lambda (&rest _x) (find-face-definition symbol)))) > > Makes sense to me. I tweaked it a bit before applying, though -- used > insert-text-button for convenience. > Why a button.el button, and not a link widget? Using a button.el button makes it look like TAB is inconsistent, because it skips the button, so you can't get to the button by just pressing TAB. And given there are links to which you can get to by pressing TAB, not being able to reach this one makes it feel like something is wrong. --000000000000c6546c05af880e65 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>>= ; * lisp/cus-edit.el (custom-face-value-create): Make the face name into>> =C2=A0 a button that calls `find-face-definition'.
>> [...]
>
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq opoint (= point))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Face name (tag).
>= ;> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(insert " " tag)
>> += =C2=A0 =C2=A0 =C2=A0 =C2=A0(make-button opoint (point)
>> + =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'fol= low-link t
>> + 'action (lambda (&rest _x) (find-face-defi= nition symbol))))
>
> Makes sense to me.=C2=A0 I tweaked it a b= it before applying, though -- used
> insert-text-button for convenien= ce.
>

Why a button.el button, and not a link widget? Using a b= utton.el button
makes it look like TAB is inconsistent, because it skips= the button, so
you can't get to the button by just pressing TA= B.

And given there are links to which you can get = to by pressing TAB, not
being able to reach this one makes it feel like = something is wrong.
--000000000000c6546c05af880e65--