From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#976: 23.0.60; incorrect code for filesets-get-filelist Date: Tue, 24 Nov 2020 08:05:40 -0300 Message-ID: References: <002901c915bf$811df210$0200a8c0@us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000040fd8705b4d84b1e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16512"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 976@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 24 12:10:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khWDV-00048s-IP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 12:10:37 +0100 Original-Received: from localhost ([::1]:41262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khWDU-00024S-LA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 24 Nov 2020 06:10:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khW94-000752-Ks for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 06:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khW94-0008M9-Do for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 06:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1khW94-0004Hs-5g for bug-gnu-emacs@gnu.org; Tue, 24 Nov 2020 06:06:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <002901c915bf$811df210$0200a8c0@us.oracle.com> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Nov 2020 11:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 976-submit@debbugs.gnu.org id=B976.160621596016473 (code B ref 976); Tue, 24 Nov 2020 11:06:02 +0000 Original-Received: (at 976) by debbugs.gnu.org; 24 Nov 2020 11:06:00 +0000 Original-Received: from localhost ([127.0.0.1]:57801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khW92-0004HX-1w for submit@debbugs.gnu.org; Tue, 24 Nov 2020 06:06:00 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:36433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khW8z-0004HC-Px for 976@debbugs.gnu.org; Tue, 24 Nov 2020 06:05:58 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id a65so2431643wme.1 for <976@debbugs.gnu.org>; Tue, 24 Nov 2020 03:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=wWrEuT+gNDwDmYLaKkzWJD5ObVcRjarkpgTA/ggPlKk=; b=Lc9rsSiX1KJQ5rOJwmZpSMJebBz0X83VCXJ2xkAzrtRgQijLzOCURxskH0hHw+mzHj 5OEsBbLtXjolpHF0ogXJTQOz3caYJalIjIxzvKvV9GBz1blOsl6rGqdJHv/S+83pC6vQ ctx1O6DceEc6DNv0wQ8KapDzKCVhGopbXNMT1DGKbySJXGXDuGJU/FHxD611ua6I5P+k OEppH3hgCmNPbbauk7ztq/Yelz1gGIKSKbiOHCT1+NnwgAuLmB+SB9vCQi2s9EI9OMLj XyM86n+hm0PiLuHWbUnl6WwXSiD9MmxrniPYR3fjq+Rsy+81qrxNlUCK4s1GNEeqjGYG C99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=wWrEuT+gNDwDmYLaKkzWJD5ObVcRjarkpgTA/ggPlKk=; b=eFb2Dg9xhH2inWkRMWkHdFp1c50J1rb7SkQdrLE8zm9/+Vrj4Yn7+ojzOX0UUBw/S5 yrs6bNa5SP72p275hGyTTt1gswH17uAcLZ20jdJj2cUs8QOwMuTMVotA6WJO4vI6jzi0 dzSbbQlsY5SLh35gAEzWauv0D9nmfbQaQI/h2i06L8W6vmDPyUtQypCUtEPcp54aZ2Uu Pq6yleP3qFW1O5YHwdweZmTDPvT/26ctEJc84GaDps4utqljW/80WCxT+m1RFedZbSKY oHPygmLSrvP8dgKGlRZ8s8hCkHdrBVw9A3TLyTpkwbhFJ8rGOJ/HdEx5hKOUp+PInYlJ 38Qw== X-Gm-Message-State: AOAM530OUNOTP6Yw6qkb4pPG2x8NiCf/RJZv1nQlOZ9XQCISW9JcrqcQ vLtDT/y5lJoCgAGII1QteJXUlh4TDrmMLrojK14= X-Google-Smtp-Source: ABdhPJzw+VlQbwcZ11KK7tYCOmo5Cm6sNwGVeB8OMZ0QjPUBqiF+Q2JkCV+MBDpgKFAXcfW2hArCpnvI7UXeDKdYL5Q= X-Received: by 2002:a1c:7f81:: with SMTP id a123mr3981981wmd.6.1606215952037; Tue, 24 Nov 2020 03:05:52 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194065 Archived-At: --00000000000040fd8705b4d84b1e Content-Type: text/plain; charset="UTF-8" tags 976 fixed close 976 28.1 quit Drew Adams wrote: > > tags 976 patch > > quit > > > > Hi Drew, > > > > It's been a long time, but your fix looks right to me, and of course > > you're right that the current code is broken. I created a :tree fileset > > for testing: without your fix I get wrong-type-argument errors, while > > with your fix it works just fine. > > > > I've recreated your fix below, added a commit message and formatted it > > with `git format-patch'. Could you please take a look and see if it > > is OK to push it? Or maybe you would like to provide a different commit > > message for your change? > > Hi Mauro. Thanks for working on this. > > It's been so long since I filed this bug that I'm > not really any help on this. And I really don't > have any time now to help with it or much else wrt > Emacs. OK, no problem. I pushed your fix. > I have complete confidence that whatever you come > up with will be an improvement (and it will likely > be a complete fix). Please do whatever you think > is needed. Thx. Thanks to you. --00000000000040fd8705b4d84b1e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 976 fixed
close 976 28.1
quit


Drew A= dams <drew.adams@oracle.com= > wrote:

> > tags 976 patch
> > quit
> ><= br>> > Hi Drew,
> >
> > It's been a long time, = but your fix looks right to me, and of course
> > you're right= that the current code is broken.=C2=A0 I created a :tree fileset
> &= gt; for testing: without your fix I get wrong-type-argument errors, while> > with your fix it works just fine.
> >
> > I&#= 39;ve recreated your fix below, added a commit message and formatted it
= > > with `git format-patch'.=C2=A0 Could you please take a look a= nd see if it
> > is OK to push it? Or maybe you would like to prov= ide a different commit
> > message for your change?
>
&g= t; Hi Mauro.=C2=A0 Thanks for working on this.
>
> It's be= en so long since I filed this bug that I'm
> not really any help = on this.=C2=A0 And I really don't
> have any time now to help wit= h it or much else wrt
> Emacs.

OK, no problem.=C2=A0 I pushed = your fix.

> I have complete confidence that whatever you come
= > up with will be an improvement (and it will likely
> be a comple= te fix).=C2=A0 Please do whatever you think
> is needed.=C2=A0 Thx.
Thanks to you.
--00000000000040fd8705b4d84b1e--