From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#43612: 28.0.50; Unable to dehighlight region in Customize Date: Fri, 25 Sep 2020 12:14:24 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000054c23605b024c6f9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25271"; mail-complaints-to="usenet@ciao.gmane.io" To: 43612@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 25 17:15:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLpRa-0006Pe-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 17:15:30 +0200 Original-Received: from localhost ([::1]:52766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLpRZ-0005Ke-0R for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 11:15:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLpR8-0005GR-OK for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 11:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33553) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLpR8-0004fC-BD for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 11:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLpR8-0001Tn-6x for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 11:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Sep 2020 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43612 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.16010468865647 (code B ref -1); Fri, 25 Sep 2020 15:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Sep 2020 15:14:46 +0000 Original-Received: from localhost ([127.0.0.1]:45099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLpQs-0001T0-5D for submit@debbugs.gnu.org; Fri, 25 Sep 2020 11:14:46 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLpQq-0001Ss-Ot for submit@debbugs.gnu.org; Fri, 25 Sep 2020 11:14:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLpQm-0004mW-Oi for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 11:14:44 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:37922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLpQk-0004dI-Dp for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 11:14:40 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id v12so3688046wmh.3 for ; Fri, 25 Sep 2020 08:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=NE0HF09Nsx0xtkJRR+YKUkDxJs9DRbE5YuExTatdTcY=; b=myXdUQ122ednJN9Nbe+LozMX+Ccpd8QKke6EPpAvDVwlQNxZ6+rM10eyI1lfAHuJT8 8aIsvWk/mM+Kuk+l3X55FZlE/BB9htqm4CxpulIM60LUqX0tw3FLEzt89Z1ezkIFvyJj litBHbL5GqSa7NRXJhIiDBi0tQ7iuz9p10kEHcr98qULPwekG8Td1tapcSfzXazTClda YIL2iLbqVHW/M6TIjyuLm3onNA7lb4qjKxUgvf5m2i/5Ww3CNwTPsGZ5GrreliIVUS8O DtrQF5v0nDWEtUfau01X0bXHXOjva9gWQVtekeAv5Lo7K1JilAjZR0oje5SZ6P/xEXrg r/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NE0HF09Nsx0xtkJRR+YKUkDxJs9DRbE5YuExTatdTcY=; b=VN2JgO3hRyeNJ5yYcI6ruFlq9KxudfEVysbsCkoj32fx6MqJgwqkNZYCSUalfDsxAJ +gomIa8Q738gN3AtJi2MbF8ZsExPSRGRUcMskxKdWSNZDITRdsR/UeLyzYAaVKJB2/ZC bPck2h5U/BBbb/cgeqy7qfwMqckIkAsZ3yZ7FgOnvPKtogLqNE4qHulnvgyTfPyQvdfz Ks0YtBKeF9LwWueB5XBEHpX3IYWoo7ZGRvQ9axhXj6htOczlskXOx81rmub3DFuSyMHv MpSKNy0mPGfRaGQNG5+l9IAWkZ8VM2gjofllWgk43R3dg+9Zzw5tsnxXO+vvoJOylShM dHoA== X-Gm-Message-State: AOAM533twf0EkHN7I0v9Y/V1GCkbxas3UHXKBRUCJUKlOBlwxqZ48UoM lHDCOqx7CZ4C2mhvu2wxSHdggIyUt9uYcT0fOv2h2u3SEeYrmg== X-Google-Smtp-Source: ABdhPJwxUQciBBKr9IOFSstJ0Y+dpGuPTiFgq5A2vkJfLj+KfTAO/nHJeqsbAcWB6L2Zj2ZeLfeFFTIvmPc61BILXBQ= X-Received: by 2002:a1c:e40b:: with SMTP id b11mr3794010wmh.100.1601046876306; Fri, 25 Sep 2020 08:14:36 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=maurooaranda@gmail.com; helo=mail-wm1-x335.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188979 Archived-At: --00000000000054c23605b024c6f9 Content-Type: text/plain; charset="UTF-8" emacs -Q M-x customize Press mouse-1 somewhere in the buffer where there is plain text and drag. While dragging, observe that there is no highlighting of the region. The region used to be highlighted immeadiately. Release mouse-1: now the region is highlighted. Click somewhere else in the buffer. Observe that Emacs highlights the new region. Before, a mouse-1 event would dehighlight it and just set point where the click happened. This started happening after the refactor in widget-button-click in 8b61e20e4edb9d2f67134bc9f3739f936aafb01c The reason is that the condition for the when form is evaluating to nil, skipping all the dispatch of the click when not inside a widget button. That is, (widget-get button :button-overlay) returns nil here. I don't understand why that extra check was added, but this behavior seems undesirable to me. In GNU Emacs 28.0.50 (build 71, x86_64-pc-linux-gnu, cairo version 1.15.10) of 2020-09-25 built on tbb-desktop Repository revision: 499848d8407855d8ca24f0c175c602a0f24da074 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 18.04.5 LTS Configured using: 'configure --with-x-toolkit=no' Configured features: XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB OLDXMENU X11 XDBE XIM MODULES THREADS PDUMPER Important settings: value of $LC_MONETARY: es_AR.UTF-8 value of $LC_NUMERIC: es_AR.UTF-8 value of $LC_TIME: es_AR.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Custom Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: (only . t) Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cus-edit easymenu cus-start cus-load wid-edit cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x multi-tty make-network-process emacs) Memory information: ((conses 16 72461 7061) (symbols 48 8192 1) (strings 32 21338 1726) (string-bytes 1 670850) (vectors 16 12778) (vector-slots 8 167810 9017) (floats 8 32 53) (intervals 56 359 4) (buffers 992 12)) --00000000000054c23605b024c6f9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
emacs -Q
M-x customize
Press mouse-1 somewhere in th= e buffer where there is plain text and
drag.
While dragging, observe = that there is no highlighting of the region.
The region used to be highl= ighted immeadiately.

Release mouse-1: now the region is highlighted.=

Click somewhere else in the buffer.=C2=A0 Observe that Emacs highli= ghts the
new region.=C2=A0 Before, a mouse-1 event would dehighlight it = and just set
point where the click happened.

This started happeni= ng after the refactor in widget-button-click in
8b61e20e4edb9d2f67134bc9= f3739f936aafb01c

The reason is that the condition for the when form = is evaluating to nil,
skipping all the dispatch of the click when not in= side a widget button.
That is, (widget-get button :button-overlay) retur= ns nil here.=C2=A0 I don't
understand why that extra check was added= , but this behavior seems
undesirable to me.


In GNU Emacs 28.= 0.50 (build 71, x86_64-pc-linux-gnu, cairo version 1.15.10)
=C2=A0of 202= 0-09-25 built on tbb-desktop
Repository revision: 499848d8407855d8ca24f0= c175c602a0f24da074
Repository branch: master
Windowing system distrib= utor 'The X.Org Foundation', version 11.0.12008000
System Descri= ption: Ubuntu 18.04.5 LTS

Configured using:
=C2=A0'configure = --with-x-toolkit=3Dno'

Configured features:
XPM JPEG TIFF GIF= PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
GNUTLS LIBXML2 FREET= YPE HARFBUZZ ZLIB OLDXMENU X11 XDBE XIM MODULES
THREADS PDUMPER

I= mportant settings:
=C2=A0 value of $LC_MONETARY: es_AR.UTF-8
=C2=A0 v= alue of $LC_NUMERIC: es_AR.UTF-8
=C2=A0 value of $LC_TIME: es_AR.UTF-8=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-system: utf-8-= unix

Major mode: Custom

Minor modes in effect:
=C2=A0 tool= tip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: = t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-b= ar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mo= de: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 = auto-composition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-c= ompression-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-mark-m= ode: (only . t)

Load-path shadows:
None found.

Features:(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
= rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-load= defs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password= -cache json map text-property-search seq byte-opt
gv bytecomp byte-compi= le cconv mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm= -utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr= mail-utils time-date subr-x cus-edit
easymenu cus-start cus-load wid-ed= it cl-loaddefs cl-lib tooltip eldoc
electric uniquify ediff-hook vc-hook= s lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar= dnd fontset image regexp-opt fringe
tabulated-list replace newcomment t= ext-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar r= fn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock synt= ax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham g= eorgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean= japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european e= thiopic indian
cyrillic chinese composite charscript charprop case-table= epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice = button
loaddefs faces cus-face macroexp files window text-properties ove= rlay
sha1 md5 base64 format env code-pages mule custom widget
hashtab= le-print-readable backquote threads dbusbind inotify
dynamic-setting sys= tem-font-setting font-render-setting cairo x
multi-tty make-network-proc= ess emacs)

Memory information:
((conses 16 72461 7061)
=C2=A0(= symbols 48 8192 1)
=C2=A0(strings 32 21338 1726)
=C2=A0(string-bytes = 1 670850)
=C2=A0(vectors 16 12778)
=C2=A0(vector-slots 8 167810 9017)=
=C2=A0(floats 8 32 53)
=C2=A0(intervals 56 359 4)
=C2=A0(buffers = 992 12))
--00000000000054c23605b024c6f9--