From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#43977: 28.0.50; customize-face, default, checkboxes not aligned with fields Date: Wed, 14 Oct 2020 14:55:42 -0300 Message-ID: References: <83h7qwzvs2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000037e6c205b1a53e9a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31954"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43977@debbugs.gnu.org, Lars Ingebrigtsen , schwab@linux-m68k.org, bugs@gnu.support To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 19:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSl1T-0008Bj-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 19:57:11 +0200 Original-Received: from localhost ([::1]:56656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSl1S-0004p5-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 13:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSl1K-0004nv-Vr for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 13:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSl1K-0007VM-GC for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 13:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSl1K-0001q1-GS for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43977 X-GNU-PR-Package: emacs Original-Received: via spool by 43977-submit@debbugs.gnu.org id=B43977.16026981636993 (code B ref 43977); Wed, 14 Oct 2020 17:57:02 +0000 Original-Received: (at 43977) by debbugs.gnu.org; 14 Oct 2020 17:56:03 +0000 Original-Received: from localhost ([127.0.0.1]:52958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSl0N-0001oj-5T for submit@debbugs.gnu.org; Wed, 14 Oct 2020 13:56:03 -0400 Original-Received: from mail-wr1-f67.google.com ([209.85.221.67]:42705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSl0L-0001oC-8M for 43977@debbugs.gnu.org; Wed, 14 Oct 2020 13:56:01 -0400 Original-Received: by mail-wr1-f67.google.com with SMTP id e18so103726wrw.9 for <43977@debbugs.gnu.org>; Wed, 14 Oct 2020 10:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=haFjvuqSnfHmJwTFjuKxMsbk5uxZzicICWnGTd/aDkU=; b=S0SnTAd0H/JgnazHb4Gb0ZY0Tff41lVS47Zd325OqTJ/hfMhAbfifqVe8xZf5+YIz8 Ocapvkei3PN6zo+RTHsMfUsuODmlvQF0ZkAIjiRy+2MQ5R4cfHETI+b9bnfWVaQowI4/ tx3cLYpon/I9DOQ2llFd6DwQaAw4/IVpHZo7l3zhD0ZujvCelob2xMImG3ee43KHCFQE sRsLqbO7a9m9qywGG6g19IiVnXUXifZAa+/KqtmP8iypKf2Guc9fUAVKDUhfnppeI8/q cQwouTkUNTeALsxNhx43FIUdNc2vISZwM2K+FlSDPsRUbrjevmAF8UB/QqJQ0b+fO/dW uCJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=haFjvuqSnfHmJwTFjuKxMsbk5uxZzicICWnGTd/aDkU=; b=PMJVi7fH7DXUFIWPMeLFt6dMTbw5AagRy2NUbb/9WiKqEvbsFg1+/bXW5xpNs6NKcV qpDLp/2mNkPt10krEb/mv4WopiuBVslblorKF9E2Hvo/+AUd2nUqPzGd+CvCp+d41r/v 9ssrl/qjlvRhpJO+crMwJg7s5X++01GFo/78onzVVmDBXsmrWqWR8jzGTYU16KGQjX4o AgI6Eq4GYF1mTwgYI1ltcKTOw5vh4HLoBHyLn85gkcuuOSVxMqPtf72Hmbdzw+qpwo7D ZbAriYhS7v187/l6WxN+45Ko3W2ZnhyOUwzj2zsEb5bR/TOsvTtMlwBFxGW/HXKKegzI Er1Q== X-Gm-Message-State: AOAM531e37s4/N8JznNLMTPnRwIOkzckklgFJmrcT7FOlOfESj7k/T1H B14UBueJYX7cjjTh4dGrXFSbXgdcMenzhlySCIw= X-Google-Smtp-Source: ABdhPJxNk7B+cM1SX5LDe3c91brAv9byuIhWjgRiOrOWC8sAjPTs3XhjM5KBoBtYc4z2NEkHX88q2woOaTXEJ+yHPyI= X-Received: by 2002:adf:f48c:: with SMTP id l12mr71951wro.77.1602698155123; Wed, 14 Oct 2020 10:55:55 -0700 (PDT) In-Reply-To: <83h7qwzvs2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190516 Archived-At: --00000000000037e6c205b1a53e9a Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Wed, 14 Oct 2020 09:00:27 -0300 >> Cc: 43977@debbugs.gnu.org, schwab@linux-m68k.org, >> Lars Ingebrigtsen , bugs@gnu.support >> >> > See also bug#33566, which is what caused this issue. >> >> Andreas patch looks correct to me. > > I didn't say it wasn't. I didn't mean to imply you said it wasn't correct. Sorry about any confusion. > I just pointed to that bug report, so that > people could (a) see if there were other solutions to consider (e.g., > maybe to solve the original issue in some other way); and (b) so that > the use case in that bug could be retested to make sure this proposed > change doesn't adversely affect it in any way. I think that: (a) The group widget was misdocumented as a possible composite type in the first place: that's why custom-variable-value-create was rejecting it, because it didn't have the format spec it requires. But it was documented, and later the group widget's :format adapted, so maybe it is better to just leave that as it is now. (b) While the change in Bug#33566 is what caused this issue, using "%v" as the format for the group widget is perfectly fine here, and doesn't affect any other uses of the group widget. There is no call to custom-variable-value-create here, so no reason to worry about overriding the :format spec to "%v" at all. --00000000000037e6c205b1a53e9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date:= Wed, 14 Oct 2020 09:00:27 -0300
>> Cc: 43977@debbugs.gnu.org, schwab@linux-m68k.org,
>> Lars Ingebrigtsen <larsi@gnus.org>, bugs@gnu.support
&= gt;>
>> > See also bug#33566, which is what caused this iss= ue.
>>
>> Andreas patch looks correct to me.
>
= > I didn't say it wasn't.

I didn't mean to imply you = said it wasn't correct.=C2=A0 Sorry about any
confusion.

>= I just pointed to that bug report, so that
> people could (a) see if= there were other solutions to consider (e.g.,
> maybe to solve the o= riginal issue in some other way); and (b) so that
> the use case in t= hat bug could be retested to make sure this proposed
> change doesn&#= 39;t adversely affect it in any way.

I think that:
(a) The group = widget was misdocumented as a possible composite type in
the first place= : that's why custom-variable-value-create was rejecting
it, because = it didn't have the format spec it requires.=C2=A0 But it was
documen= ted, and later the group widget's :format adapted, so maybe it is
be= tter to just leave that as it is now.

(b) While the change in Bug#33= 566 is what caused this issue, using "%v"
as the format for th= e group widget is perfectly fine here, and doesn't
affect any other = uses of the group widget.=C2=A0 There is no call to
custom-variable-valu= e-create here, so no reason to worry about
overriding the :format spec t= o "%v" at all.
--00000000000037e6c205b1a53e9a--