From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: master 6924320: Take care of a FIXME in cus-edit-tests.el Date: Fri, 20 Nov 2020 19:16:43 -0300 Message-ID: References: <20201120213804.8196.42565@vcs0.savannah.gnu.org> <20201120213806.0C179209DE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c4ad7805b4913312" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 20 23:19:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgEkN-00022k-33 for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 23:19:15 +0100 Original-Received: from localhost ([::1]:43134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgEkM-0001Js-6H for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Nov 2020 17:19:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgEiB-0007Ds-1n for emacs-devel@gnu.org; Fri, 20 Nov 2020 17:16:59 -0500 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:39714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgEi9-0002BK-7T for emacs-devel@gnu.org; Fri, 20 Nov 2020 17:16:58 -0500 Original-Received: by mail-wr1-x42b.google.com with SMTP id o15so12230786wru.6 for ; Fri, 20 Nov 2020 14:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5J1I5qNBWWWixTsIlprQa4j73INe+qwcYacX5mkkVT4=; b=DKakWZHoeBATc8+/lThVAPk6W6FtUAkIumlRCIIG87TvXNFl2gqyc9gw/dNwu8isY/ geMvtBwQvT7FmDmWDaAz7PcDE1+mH6prI08GHYZEMMAigwTFxbAu/RM0xNBAWr+GEGZh wbL2HjdcKoMPfvsvibUGdxhAGEXRR2ZfD4nMTYCU84Hw8e9RQuz39bF+6F7jzNLTKvuc SKSra6wLJbQICYcZuuziT9REJDQZrg4i3fdZXryafovI+o4cJzErtTlaCfuM5wxtT7PY K4CXikacCdm0BHfETT6bcty90+j+ltpVOGf5QWeEgJw2CK5vj4i5HTlzCKtNYewZqWv1 O++w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5J1I5qNBWWWixTsIlprQa4j73INe+qwcYacX5mkkVT4=; b=h7BE2c2tKC75L9njX2QR4ZkTJ2l8+cNj+1zh0xBsfyMGliTXJ47JbQpU84qvuNYeER eUdz0bWYot9JfjxzuN6+9W4UdZ8ySnduk/TYLjLI46Ssx0dJTHWriauSQGj4RksoFa8y WA9lfHH9GGiiPHxlx8ShYeB8N/Yj/jwSYgSZViHGqSW+aAx7NCsjZD5VKpyK1phP7VQU 0HBi8yKE/E4yS9wpu9MvX/PPe6alenH2mxWatqJBMdt3Pbn3VEYzy1McP2XnM9bwz7Lw d4a16/VXSactUt+7uzOw4B81iDPm2utBJuuRDFdxT8bqD22qTgybN7k8KLIdWjIS/MEg jAUw== X-Gm-Message-State: AOAM5320i73+o6xGh3+x8AJuHRBF3YHB3fsNEaU4QqKFSymuJRZS4D9W HKm2cSnLn7jBZ2okF0Ou32wfHd5eNta0GCpPC3xqnAg1iU8= X-Google-Smtp-Source: ABdhPJy307UQAnEIHQ2XSti7DgdMjCGPoJRlqIAL20q2R33JnaKPnMyfuG9ukR/si2Vko35JBd52hmrjBE+wxm12rNM= X-Received: by 2002:a5d:4e87:: with SMTP id e7mr120091wru.70.1605910615337; Fri, 20 Nov 2020 14:16:55 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=maurooaranda@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259507 Archived-At: --000000000000c4ad7805b4913312 Content-Type: text/plain; charset="UTF-8" > > - (customize-saved) > > - (should (search-forward cus-edit-tests--obsolete-option-tag nil t)))) > > + (unwind-protect > > + (progn > > + (put 'cus-edit-tests--obsolete-option-tag 'saved-value '(t)) > > + (customize-saved) > > + (should (search-forward cus-edit-tests--obsolete-option-tag nil t))) > > + (put 'cus-edit-tests--obsolete-option-tag 'saved-value nil)))) > > These are (fairly rare) good use-cases for `cl-letf`: > > (cl-letf (((get 'cus-edit-tests--obsolete-option-tag 'saved-value) '(t))) > (customize-saved) > (should (search-forward cus-edit-tests--obsolete-option-tag nil t))) Indeed. I didn't know about cl-letf, thanks. BTW, C-h f cl-letf RET shows a link to the info node (cl) Function Bindings. Maybe a better link is (cl) Modify Macros. --000000000000c4ad7805b4913312 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> > - =C2=A0 =C2=A0(customize-saved)
> > - = =C2=A0 =C2=A0(should (search-forward cus-edit-tests--obsolete-option-tag ni= l t))))
> > + =C2=A0 =C2=A0(unwind-protect
> > + =C2=A0 = =C2=A0 =C2=A0 =C2=A0(progn
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(put 'cus-edit-tests--obsolete-option-tag 'saved-value '(t))=
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(customize-saved)
>= > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(should (search-forward cus-edit-= tests--obsolete-option-tag nil t)))
> > + =C2=A0 =C2=A0 =C2=A0(put= 'cus-edit-tests--obsolete-option-tag 'saved-value nil))))
> =
> These are (fairly rare) good use-cases for `cl-letf`:
>
= > =C2=A0 =C2=A0 (cl-letf (((get 'cus-edit-tests--obsolete-option-tag= 'saved-value) '(t)))
> =C2=A0 =C2=A0 =C2=A0 (customize-saved= )
> =C2=A0 =C2=A0 =C2=A0 (should (search-forward cus-edit-tests--obso= lete-option-tag nil t)))

Indeed.=C2=A0 I didn't know about cl-le= tf, thanks.

BTW, C-h f cl-letf RET
shows a link to the info node = (cl) Function Bindings.=C2=A0 Maybe a better
link is (cl) Modify Macros.=
--000000000000c4ad7805b4913312--