From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#44764: 28.0.50; Wrong menu binding for file in tree fileset Date: Fri, 20 Nov 2020 12:56:04 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000790d0305b48be2d3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25681"; mail-complaints-to="usenet@ciao.gmane.io" To: 44764@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 20 17:01:40 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kg8qx-0006bP-MT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 17:01:39 +0100 Original-Received: from localhost ([::1]:53964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg8qw-0005aj-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 11:01:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg8mU-0001GI-RM for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 10:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kg8mU-0006xo-If for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kg8mU-0003Hf-Hp for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 10:57:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Nov 2020 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44764 X-GNU-PR-Package: emacs Original-Received: via spool by 44764-submit@debbugs.gnu.org id=B44764.160588778312568 (code B ref 44764); Fri, 20 Nov 2020 15:57:02 +0000 Original-Received: (at 44764) by debbugs.gnu.org; 20 Nov 2020 15:56:23 +0000 Original-Received: from localhost ([127.0.0.1]:44179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg8lr-0003Gd-BD for submit@debbugs.gnu.org; Fri, 20 Nov 2020 10:56:23 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:39086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg8lq-0003GL-IK for 44764@debbugs.gnu.org; Fri, 20 Nov 2020 10:56:23 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id o15so10527508wru.6 for <44764@debbugs.gnu.org>; Fri, 20 Nov 2020 07:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=GD+efoq6lyXUT4dM3BJ5XS6LCJW79S9Ha6WNlx5vy8s=; b=UaNc4Mry4jvo+MErTFe+G/CBiLhR8jPDwcaKv/dAP9FxAhy70Z9iOhrVCruc0lEYbe Zanf0KDkNPN15Sob3TMpO64mxABJI8br5y5Sr5sQTbmmgI5E8QGppmM/mm6GwM4x88VO PRi5X6iJygguumNoZCmqNbS+SUeaIr8sBBRnfQqeoD1Dim3tdDUMctfjua2uxVkJb8Zz RhT6KQCk9W4uSovlO4OF/kSIaYQ53P8n33qk2rullX8CMg8VY8HCnN3cVlNT7eURdr3j T5C6NgtdMOezaORozR7EKgRi27hfJKUd/g83UV9DfhLFsNjB7Ybtvclsc+W8Jpy8GKEy I1WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=GD+efoq6lyXUT4dM3BJ5XS6LCJW79S9Ha6WNlx5vy8s=; b=toySp19YsH0NUl9TBs1D6TovRCknuaC81Aq0xobkYXUPbEG12R631Nu5hNrwrHN9CD c+sLCPd2YL6HlZyT+a5y4XhRpxwOELx20cOZxFLWhPexMrXxCpcXqjt2c6gz2aus7OZ9 x2GPoCM84cqIiCmL0hq3wldxrGxSI69eYS5Sl5vfL4+axnPEvk0d2pijoIP4pmrGBp/M 4nyEzHx3TJKYK7Fw1hulagcxW9Fp/GSqFyvHotRRgQjK1+jSfr9OBfIoD5m31jPbeuJQ 4G6ET1kkPEsbgHVngLCruuRwaGxE/gFEju7gpVP9gnn68qtiYYvkpXQaZ4P2LbMTV6Kq XJZw== X-Gm-Message-State: AOAM533rr1a5KYC6zT0NABwnOwuG73Rzlg+4YONXAUT9QygJhcW8KsE7 wf5AhU5qjIYzksLMajUdcpiI7YcPlrPW0CiBuorsrMZvn4E= X-Google-Smtp-Source: ABdhPJzGEMIXmYRnOefYDfSBImtnpPTUrhP7eLvU+Ti7marU47fF4SRebipE1OxNo24/zSi2Dxb2pP0ydXPkNdU3Ehw= X-Received: by 2002:a5d:4d02:: with SMTP id z2mr16930507wrt.109.1605887776530; Fri, 20 Nov 2020 07:56:16 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193788 Archived-At: --000000000000790d0305b48be2d3 Content-Type: multipart/alternative; boundary="000000000000790d0205b48be2d1" --000000000000790d0205b48be2d1 Content-Type: text/plain; charset="UTF-8" tags 44764 patch quit Mauro Aranda writes: > To reproduce: > 0) Setup a directory with subdirectories and files, for later definition > of a tree fileset: > mkdir fileset-test > cd fileset-test > touch file.el > mkdir subdir > cd subdir > touch file1.el file2.el file3.el file4.el file5.el > > 5 files seems kinda arbitrary, but it's needed so that one of the files > is left alone as a menu item. > > 1) Start Emacs: emacs -Q > > 2) Eval: (filesets-init) > > 3) M-x set-variable RET filesets-max-submenu-length RET 3 > > This is so I don't bore you with creating more than 25 files. > > 4) M-x filesets-edit > > Add a new entry to filesets-data, like so: > Name: test > In Data, select the Directory Tree option and then: > Dir: /path/to/fileset-test > Pattern: ^.+\.el$ > > Set for current session. > > Now data should look like this: > (("test (:tree "path/to/fileset-test" "^.+\\.el$"))) > > 5) Click the File menu, and follow the Filesets entry, then the test > entry and finally the subdir entry. > > You should see that file1.el and file2.el are grouped. Also, file3.el > and file4.el got grouped, while file5.el is left alone. This is OK. > > Clicking any file but file5.el works fine. But clicking file5.el raises > an error: > Invalid function: (filesets-file-open nil '"/path/to/fileset-test/subdir/file5.el" '"test") > > The menu entry for file5.el is wrong. The attached patch should fix it. OK to install? --000000000000790d0205b48be2d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 44764 patch
quit

Mauro Aranda <maurooar= anda@gmail.com> writes:

> To reproduce:
> 0) Setup= a directory with subdirectories and files, for later definition
> of= a tree fileset:
> mkdir fileset-test
> cd fileset-test
>= touch file.el
> mkdir subdir
> cd subdir
> touch file1.e= l file2.el file3.el file4.el file5.el
>
> 5 files seems kinda a= rbitrary, but it's needed so that one of the files
> is left alon= e as a menu item.
>
> 1) Start Emacs: emacs -Q
>
> = 2) Eval: (filesets-init)
>
> 3) M-x set-variable RET filesets-m= ax-submenu-length RET 3
>
> This is so I don't bore you wit= h creating more than 25 files.
>
> 4) M-x filesets-edit
>=
> Add a new entry to filesets-data, like so:
> Name: test
&= gt; In Data, select the Directory Tree option and then:
> Dir: /path/= to/fileset-test
> Pattern: ^.+\.el$
>
> Set for current s= ession.
>
> Now data should look like this:
> (("tes= t (:tree "path/to/fileset-test" "^.+\\.el$")))
><= br>> 5) Click the File menu, and follow the Filesets entry, then the tes= t
> entry and finally the subdir entry.
>
> You should se= e that file1.el and file2.el are grouped.=C2=A0 Also, file3.el
> and = file4.el got grouped, while file5.el is left alone.=C2=A0 This is OK.
&g= t;
> Clicking any file but file5.el works fine.=C2=A0 But clicking fi= le5.el raises
> an error:
> Invalid function: (filesets-file-op= en nil '"/path/to/fileset-test/subdir/file5.el" '"te= st")
>
> The menu entry for file5.el is wrong.

The = attached patch should fix it.=C2=A0 OK to install?
--000000000000790d0205b48be2d1-- --000000000000790d0305b48be2d3 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-menu-binding-for-files-in-fileset.patch" Content-Disposition: attachment; filename="0001-Fix-menu-binding-for-files-in-fileset.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_khqg1qh60 RnJvbSA2ZjUwMTJkN2NjN2NiMWJmM2U2NTAzNjZiMTRmYzM2NzI2MWMxODZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgMjAgTm92IDIwMjAgMTI6NTI6NTYgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggbWVudSBiaW5kaW5nIGZvciBmaWxlcyBpbiBmaWxlc2V0CgoqIGxpc3AvZmlsZXNldHMuZWwg KGZpbGVzZXRzLXJlbWFrZS1zaG9ydGN1dCk6IFdlIHdhbnQgdGhlIGNhbGxiYWNrIG9mCnRoZSBt ZW51IGl0ZW0sIG5vdCBhIGxpc3QgdGhhdCBjb250YWlucyB0aGUgY2FsbGJhY2suICAoQnVnIzQ0 NzY0KQotLS0KIGxpc3AvZmlsZXNldHMuZWwgfCAzICstLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXNldHMuZWwg Yi9saXNwL2ZpbGVzZXRzLmVsCmluZGV4IGM3ZWMzZjc3ZjQuLmNkZGFjY2JiMmEgMTAwNjQ0Ci0t LSBhL2xpc3AvZmlsZXNldHMuZWwKKysrIGIvbGlzcC9maWxlc2V0cy5lbApAQCAtMTg3OCw4ICsx ODc4LDcgQEAgZmlsZXNldHMtcmVtYWtlLXNob3J0Y3V0CiAJCSAgICAgICAoc3Vic3RyaW5nIChl bHQgc3VibWVudSAwKSAyKSkpKQogICAgIChpZiAobGlzdHAgc3VibWVudSkKIAkoY29ucyBuYW1l IChjZHIgc3VibWVudSkpCi0gICAgICAoYXBwbHkgJ3ZlY3RvciAobGlzdCBuYW1lIChjZHIgKGFw cGVuZCBzdWJtZW51IG5pbCkpKSkpKSkKLTsgICAgICAodmNvbmNhdCBgWyxuYW1lXSAoc3Vic2Vx IHN1Ym1lbnUgMSkpKSkpCisgICAgICAoYXBwbHkgJ3ZlY3RvciAobGlzdCBuYW1lIChjYWRyIChh cHBlbmQgc3VibWVudSBuaWwpKSkpKSkpCiAKIChkZWZ1biBmaWxlc2V0cy13cmFwLXN1Ym1lbnUg KHN1Ym1lbnUtYm9keSkKICAgIlNwbGl0IGxvbmcgc3VibWVudXMuIgotLSAKMi4yOS4yCgo= --000000000000790d0305b48be2d3--