From: Mauro Aranda <maurooaranda@gmail.com>
To: 36557@debbugs.gnu.org
Subject: bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support
Date: Mon, 8 Jul 2019 20:00:34 -0300 [thread overview]
Message-ID: <CABczVwcUy03RwpQQH8xQjS=sxZqTG6500j-0Y_duR8qGugojDg@mail.gmail.com> (raw)
In-Reply-To: <CABczVwdqBzU_XbBhEhHwDgoWXHpv7o_kjTeGaOh18H4X0faZ7Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 29 bytes --]
Tags: patch
Patch attached.
[-- Attachment #1.2: Type: text/html, Size: 85 bytes --]
[-- Attachment #2: 0001-Remove-duplicated-code-in-octave-eldoc-function.patch --]
[-- Type: text/x-patch, Size: 1457 bytes --]
From 3283696088d4881b06185ed8fa8b74f94e2cbaeb Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Mon, 8 Jul 2019 19:22:20 -0300
Subject: [PATCH] Remove duplicated code in octave-eldoc-function
* lisp/progmodes/octave.el (octave-eldoc-function): The position of
the opening parenthesis in the inferior-octave-process was
duplicated. Remove one of the checks. (Bug#36557)
---
lisp/progmodes/octave.el | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lisp/progmodes/octave.el b/lisp/progmodes/octave.el
index 8a7e24e..6e59401 100644
--- a/lisp/progmodes/octave.el
+++ b/lisp/progmodes/octave.el
@@ -1630,12 +1630,7 @@ octave-eldoc-function
(paren-pos (cadr ppss))
(fn (save-excursion
(if (and paren-pos
- ;; PAREN-POS must be after the prompt
- (>= paren-pos
- (if (eq (get-buffer-process (current-buffer))
- inferior-octave-process)
- (process-mark inferior-octave-process)
- (point-min)))
+ ;; PAREN-POS must be after the prompt.
(or (not (eq (get-buffer-process (current-buffer))
inferior-octave-process))
(< (process-mark inferior-octave-process)
--
2.7.4
next prev parent reply other threads:[~2019-07-08 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 22:33 bug#36557: 27.0.50; Duplicated check in octave-mode ElDoc support Mauro Aranda
2019-07-08 23:00 ` Mauro Aranda [this message]
2019-07-20 9:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABczVwcUy03RwpQQH8xQjS=sxZqTG6500j-0Y_duR8qGugojDg@mail.gmail.com' \
--to=maurooaranda@gmail.com \
--cc=36557@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.