From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#44154: 26.3; Customize Face buffer: be able to click an inherited face, to customize it Date: Tue, 27 Oct 2020 12:32:58 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ae980d05b2a8c36b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28876"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44154@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 27 16:36:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXR1H-0007Ou-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 16:36:19 +0100 Original-Received: from localhost ([::1]:41002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXR1G-0003pA-BH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 11:36:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXQz4-0000yg-FQ for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 11:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXQz4-00026V-3f for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 11:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXQz4-0005k5-1K for bug-gnu-emacs@gnu.org; Tue, 27 Oct 2020 11:34:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Oct 2020 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44154-submit@debbugs.gnu.org id=B44154.160381279822005 (code B ref 44154); Tue, 27 Oct 2020 15:34:01 +0000 Original-Received: (at 44154) by debbugs.gnu.org; 27 Oct 2020 15:33:18 +0000 Original-Received: from localhost ([127.0.0.1]:45491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXQyM-0005ir-Hb for submit@debbugs.gnu.org; Tue, 27 Oct 2020 11:33:18 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:52420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXQyK-0005ib-No for 44154@debbugs.gnu.org; Tue, 27 Oct 2020 11:33:17 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id c194so1787339wme.2 for <44154@debbugs.gnu.org>; Tue, 27 Oct 2020 08:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=8v0ri9N6nJ8SbtfBwiMVy4DR17HkG4pN73msb7f2+3k=; b=EUgzY7uG8cO38McnZgnGZ6qFOgp+TesjC/M0jvdCAUJ0G+RbPVQCiymrwcXO24lvlL uwJY59W+rGI082d6N6tU7Mgq/tyPS5UzpkW+3kdx7qNqShby5I8q9Y/+V+2ufInl3C/v Gl46EuLSCv30YzWoaaKwdx3xf2hb2QUvVme9eWBLUdgFnxg0Z3FJI4MkPXJvCui9edWo gS6coG1wq1Doyd26XTY7bOhJkUDesjUMqntqB8ykSk1frn2P3LbYlRfqlf7odjUdI70C tzWOfff8sDfb8Kz5hQQrKdSYFYkKKGp7KrJ1d7PzBZvDctgc650GDePRIcfD0otf5OeZ uGVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=8v0ri9N6nJ8SbtfBwiMVy4DR17HkG4pN73msb7f2+3k=; b=gDYlt7AFh2nCsnIJuH0HIUsprfWIjVr/IGNi72Zri7oX/ZDgN+AMa94m/KyJJx/q9m T72vIGWDCikaVxzuBBxNsfo02GyhtCt+IL77zuEdo3+T3sAcKjgBFcQhU7XfOezNyFm6 2iuylD+8zv4RevL6ARJWM1U8ab4ZuiReYGqLy3kZBfbJTL1x7RBGKQrqdiJliDh0EKUH Bn1DZVwxund4NP90dxMVH0UCSJl9fINaodlkYf9Yu7AXVZm1z2mADXsKgxULwKo+SwfK meZ1IFQJ8U/4N5hKhZmwseu3jXQMdKrg+gWNfNaqRAIP0qmWExlR/QfPuS1C8OgZJ9Me xBTQ== X-Gm-Message-State: AOAM533e+IDeFmy91l2am7xhkTPWB9l8kxbI9LQgXGcgXvqDKmazI4ij RPQOr+Z0i1nKij9p6mv2K3/QbVnbm9vMVYPLw6g= X-Google-Smtp-Source: ABdhPJw4aJbeEYFWpIr2BNDKzDGSGICYFe4fWe/O2tTEw5f6hKjsgwPlH9PXYb+pc9ViNaUphnfLf7iiHdhXxzwIA3c= X-Received: by 2002:a7b:c20e:: with SMTP id x14mr3207617wmi.76.1603812790792; Tue, 27 Oct 2020 08:33:10 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191746 Archived-At: --000000000000ae980d05b2a8c36b Content-Type: multipart/alternative; boundary="000000000000ae980b05b2a8c369" --000000000000ae980b05b2a8c369 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Drew Adams writes: > >> In Customize Face, if attribute Inherit is checked then be able to click >> the name of an inherited face, to customize it, or at least to see its >> attributes/definition. >> >> That is, have a link on it, which invokes either `customize-face' or >> `describe-face' for it. > > Makes sense. I've now added this to Emacs 28. > +(defun cus--face-link (widget _format) > + (let ((face (intern (widget-get widget :value)))) > + (widget-create-child-and-convert > + widget 'face-link > + :button-face 'link > + :tag "link" > + :action (lambda (&rest _x) > + (customize-face face))))) > + I think this could become confusing if one edits the value of the inherited face, because the link always points to the widget's value at creation time. I suggest making the link always point to the widget's current value, like in the attached patch. --000000000000ae980b05b2a8c369 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Drew Adams <drew.adams@oracle.com> writes:
>
>= > In Customize Face, if attribute Inherit is checked then be able to cli= ck
>> the name of an inherited face, to customize it, or at least = to see its
>> attributes/definition. =C2=A0
>>
>>= ; That is, have a link on it, which invokes either `customize-face' or<= br>>> `describe-face' for it.
>
> Makes sense.=C2=A0 = I've now added this to Emacs 28.

> +(defun cus--face-link (wi= dget _format)
> + =C2=A0(let ((face (intern (widget-get widget :value= ))))
> + =C2=A0 =C2=A0(widget-create-child-and-convert
> + =C2= =A0 =C2=A0 widget 'face-link
> + =C2=A0 =C2=A0 :button-face '= link
> + =C2=A0 =C2=A0 :tag "link"
> + =C2=A0 =C2=A0 = :action (lambda (&rest _x)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (customize-face face)))))
> +

I think this coul= d become confusing if one edits the value of the
inherited face, because= the link always points to the widget's value at
creation time.
<= br>I suggest making the link always point to the widget's current value= ,
like in the attached patch.
--000000000000ae980b05b2a8c369-- --000000000000ae980d05b2a8c36b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Small-fix-to-the-new-link-for-inherited-faces-in-Cus.patch" Content-Disposition: attachment; filename="0001-Small-fix-to-the-new-link-for-inherited-faces-in-Cus.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgs4peil0 RnJvbSAyOWEzODY3OWI2YjEzNWIxNmRkYjcxMTI4ZjFkYTVmY2YzZjQwNTE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFR1ZSwgMjcgT2N0IDIwMjAgMTI6MjQ6MjcgLTAzMDAKU3ViamVjdDogW1BBVENIXSBT bWFsbCBmaXggdG8gdGhlIG5ldyBsaW5rIGZvciBpbmhlcml0ZWQgZmFjZXMgaW4gQ3VzdG9taXpl CgoqIGxpc3AvY3VzLWVkaXQuZWwgKGN1cy0tZmFjZS1saW5rKTogTGluayB0byB0aGUgY3VycmVu dCB2YWx1ZSBvZiB0aGUKd2lkZ2V0LCByYXRoZXIgdGhhbiB0byB0aGUgd2lkZ2V0J3MgdmFsdWUg dXBvbiBjcmVhdGlvbi4gIChCdWcjNDQxNTQpCi0tLQogbGlzcC9jdXMtZWRpdC5lbCB8IDEzICsr KysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQuZWwKaW5k ZXggZWQwMTE3ZTA2Ny4uNzY5YTY5YTUwZiAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5lbAor KysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC0zNzQwLDEzICszNzQwLDEyIEBAIGN1c3RvbS1mYWNl LXZhbHVlLWNyZWF0ZQogCSAgKGN1c3RvbS1mYWNlLXN0YXRlLXNldCB3aWRnZXQpKSkpKSkKIAog KGRlZnVuIGN1cy0tZmFjZS1saW5rICh3aWRnZXQgX2Zvcm1hdCkKLSAgKGxldCAoKGZhY2UgKGlu dGVybiAod2lkZ2V0LWdldCB3aWRnZXQgOnZhbHVlKSkpKQotICAgICh3aWRnZXQtY3JlYXRlLWNo aWxkLWFuZC1jb252ZXJ0Ci0gICAgIHdpZGdldCAnZmFjZS1saW5rCi0gICAgIDpidXR0b24tZmFj ZSAnbGluawotICAgICA6dGFnICJsaW5rIgotICAgICA6YWN0aW9uIChsYW1iZGEgKCZyZXN0IF94 KQotICAgICAgICAgICAgICAgKGN1c3RvbWl6ZS1mYWNlIGZhY2UpKSkpKQorICAod2lkZ2V0LWNy ZWF0ZS1jaGlsZC1hbmQtY29udmVydAorICAgd2lkZ2V0ICdmYWNlLWxpbmsKKyAgIDpidXR0b24t ZmFjZSAnbGluaworICAgOnRhZyAibGluayIKKyAgIDphY3Rpb24gKGxhbWJkYSAoJnJlc3QgX3gp CisgICAgICAgICAgICAgKGN1c3RvbWl6ZS1mYWNlICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkpKSkK IAogKGRlZnZhciBjdXN0b20tZmFjZS1tZW51IG5pbAogICAiSWYgbm9uLW5pbCwgYW4gYWxpc3Qg b2YgYWN0aW9ucyBmb3IgdGhlIGBjdXN0b20tZmFjZScgd2lkZ2V0LgotLSAKMi4yOS4wCgo= --000000000000ae980d05b2a8c36b--