From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: master 527413f: Go back to not using custom-push-theme when enabling a theme Date: Sat, 7 Nov 2020 10:01:14 -0300 Message-ID: References: <20201106123610.24601.8123@vcs0.savannah.gnu.org> <20201106123612.2172F20B2C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004d5dbd05b383ed01" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="971"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 07 14:02:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbNr7-00007R-Bu for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Nov 2020 14:02:09 +0100 Original-Received: from localhost ([::1]:53336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbNr6-0001sF-Di for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Nov 2020 08:02:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbNqU-0001Os-LT for emacs-devel@gnu.org; Sat, 07 Nov 2020 08:01:30 -0500 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:45179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbNqT-0007K1-2Z for emacs-devel@gnu.org; Sat, 07 Nov 2020 08:01:30 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id p1so4045298wrf.12 for ; Sat, 07 Nov 2020 05:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oh4zTSrwGq8kxx6rpoYNkAOZj1uOxbu5y7mnjFpwpQQ=; b=pjG4jN0Af1JfZemYCFbIdwkmsD/k19V+5zax5aHqFrsqh+dyggXBFpN1ry95fRSAjA 9pZb5vkrv8D1dvPLKCYsyafHaHdDauZ/6VoU0C/Zm9IlQPXHVptX9ojym2XIGahrX8/t M5DV/r0/Y6msq47lGcKtVDbG47Wz9SH6ZqFivwkbCHuVBPAGOdESeare4g3onrlrZA2Z OwGonX/t5fOq3klGmMgeIkUrwkx8fXnvur2wYqcC5lZk5uXbrPrm/W/vb9iOAEQ2H06P Rxmqq81FP3ldlVrKkMv63YpTz7LBsTMo8S9kUnGTnShvsGcgOBGrGDQ2WhIvJwGhqosZ ++Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oh4zTSrwGq8kxx6rpoYNkAOZj1uOxbu5y7mnjFpwpQQ=; b=LO9RNDAb5/2AqNTMdox6Qq6fU+C2OZ4Yy0sJUya7gkQ3V8B6BGTmzsa+s316ZMWUCC QS9Uj51IW4kIbBPHQhh4zm8BDIp6VoZB+KGfpArqzjVtIR/8Kke2oHSdNpoUSRpcWyQx uQLYyLIh2vnqEI5WzCyLrP+LJ7OdXqLEvsuEhf7uZGrum7J93qvXxQJysuz1KZjWaZJd nu1XbX3m3+Tt0rBdyAexcL5DWtRpvjhToU9ilPDI2AaMO3n4FwVPrxMy+EWMIOcU5aI8 pzm0n5FQJiHsnf5P0zWJc6sCpT1AuEROD5MSRn8H1TANw45EL3xPqoaukXt9+p5G3rKL qjGQ== X-Gm-Message-State: AOAM530i+6srOv2xgAYFZJ7JQy54S2JVL4JHr1Tm4yPjwTfdHi9MiFHx xCCToFAAQ2MTOiEorsoIxB0TGlz1/GOGOEj40O7vrg4WkLAU3g== X-Google-Smtp-Source: ABdhPJwBkfryvlXOMavf/Rg8kmCLP9wSvdmCusfTKhOqmGYnQMnMlSbQduYmr+sJD9pnYdc6DtfBzheHc8ZwPXQpsiQ= X-Received: by 2002:a5d:4cd1:: with SMTP id c17mr7928110wrt.109.1604754086910; Sat, 07 Nov 2020 05:01:26 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=maurooaranda@gmail.com; helo=mail-wr1-x42c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258870 Archived-At: --0000000000004d5dbd05b383ed01 Content-Type: text/plain; charset="UTF-8" >> Since the test for Bug#34027, custom--test-theme-variables, still pass >> after the change, I didn't consider adding a test for this. But sure, >> it should be easy to add one. > That would be very appreciated. No problem; done in commit 423b6b62296df0558cf16f286dd268e0b49b3bce. --0000000000004d5dbd05b383ed01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>> Since the test for Bug#34027, custom--test-theme-= variables, still pass
>> after the change, I didn't consider a= dding a test for this.=C2=A0 But sure,
>> it should be easy to add= one.
=C2=A0
> That would be very appreciated.

No problem; = done in commit 423b6b62296df0558cf16f286dd268e0b49b3bce.
--0000000000004d5dbd05b383ed01--