From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Trey Jackson Newsgroups: gmane.emacs.devel Subject: Re: Emacs 24.4 and advice Date: Fri, 31 Oct 2014 12:26:19 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6dc85ab1fd090506bcf8a7 X-Trace: ger.gmane.org 1414789064 19476 80.91.229.3 (31 Oct 2014 20:57:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2014 20:57:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 31 21:57:42 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XkJGA-0007ii-9g for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2014 21:57:26 +0100 Original-Received: from localhost ([::1]:43321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkJ1P-0003nc-Fx for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2014 16:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkHq2-00042R-2w for emacs-devel@gnu.org; Fri, 31 Oct 2014 15:26:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XkHq1-0003Dj-5c for emacs-devel@gnu.org; Fri, 31 Oct 2014 15:26:22 -0400 Original-Received: from mail-pd0-x22f.google.com ([2607:f8b0:400e:c02::22f]:53519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkHq0-0003DZ-Ux for emacs-devel@gnu.org; Fri, 31 Oct 2014 15:26:21 -0400 Original-Received: by mail-pd0-f175.google.com with SMTP id y13so7786629pdi.6 for ; Fri, 31 Oct 2014 12:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+/pF94OaHrm1RgfbOZYPmur26ERbcmU0flUtkYS/GtU=; b=nqV3R/8uVfqGOSBpNlN3JmzAmawgEMOLabfKwC8VdxBeQQOm361KQJ89H9uIQ89NG1 mSy1J/UC55bsi40lQmOi1bWw4aKUi1yx5bHbkKiYvb2+kIw90IFVhh3DVPA1ttit8D38 OjxfleXywkMzdzp+zfKcYsbE9gQFcoYqD1FUNdmXKChNQ9HTr5spWf9STEWsQ2GrzBff DZiAopmhdQjhgkLCVkQAyBRN6CZKW7fXz9R9a7o4MKnbbaMb73QNPZNSHkKL8hNq2tnE J5/9T6P/I2yhbCvdvmjVk8OerSM4xoKpPcAhQhSvrSd1yWdx6DKVhDDYbexlSvXNY6UJ OrFw== X-Received: by 10.68.92.66 with SMTP id ck2mr26836187pbb.72.1414783579583; Fri, 31 Oct 2014 12:26:19 -0700 (PDT) Original-Received: by 10.70.123.230 with HTTP; Fri, 31 Oct 2014 12:26:19 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176167 Archived-At: --047d7b6dc85ab1fd090506bcf8a7 Content-Type: text/plain; charset=ISO-8859-1 Thanks! I was just a bit surprised by no mention of it anywhere in the mailing list or NEWS. It's an easy fix and no big deal. Next time I'll have to start perusing the commit logs... On Fri, Oct 31, 2014 at 12:02 PM, Stefan Monnier wrote: > >> What do you use them for? > > It's left over code, I presume they were there because, upon first read > of > > the documentation, it looked as though you needed to call > (ad-start-advice) > > to get things going. > > Right, and I think this documentation was a left from Emacs-18. > > Calling ad-start-advice has been unnecessary since at least Emacs-19.28 > (the first "official" Emacs-19 release), i.e. about 20 years now ;-) > > If more people bump into it, we'll have to add an obsolete dummy > ad-start-advice for people who followed the tutorial. > > >> Which tutorial are you referring to? > > ;; @ Foo games: An advice tutorial > > Oh, indeed, the advice.el Commentary: includes a tutorial. Sorry, > I didn't remember. > > > Stefan > -- Trey Jackson bigfaceworm@gmail.com "Like any truly useful program, `hello' contains a built-in mail reader." -- GNU's Bulletin, July 1996 --047d7b6dc85ab1fd090506bcf8a7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks!

I was just a bit surprised by n= o mention of it anywhere in the mailing list or NEWS.=A0 It's an easy f= ix and no big deal.=A0 Next time I'll have to start perusing the commit= logs...

On Fri, Oct 31, 2014 at 12:02 PM, Stefan Monnier <<= a href=3D"mailto:monnier@iro.umontreal.ca" target=3D"_blank">monnier@iro.um= ontreal.ca> wrote:
>> What do you use them for?
> It's left over code, I presume they were there because, upon first= read of
> the documentation, it looked as though you needed to call (ad-start-ad= vice)
> to get things going.

Right, and I think this documentation was a left from Emacs-18.

Calling ad-start-advice has been unnecessary since at least Emacs-19.28
(the first "official" Emacs-19 release), i.e. about 20 years now = ;-)

If more people bump into it, we'll have to add an obsolete dummy
ad-start-advice for people who followed the tutorial.

>> Which tutorial are you referring to?
> ;; @ Foo games: An advice tutorial

Oh, indeed, the advice.el Commentary: includes a tutorial.=A0 Sorry,=
I didn't remember.


=A0 =A0 =A0 =A0 Stefan



--
Trey Jackson
bigfaceworm@gmail.com

"Lik= e any truly useful program, `hello' contains a built-in mail reader.&qu= ot;
-- GNU's Bulletin, July 1996

--047d7b6dc85ab1fd090506bcf8a7--