From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simon Law Newsgroups: gmane.emacs.bugs Subject: bug#11520: 24.1.50; delete-selection-mode conflicts with electric-pair-mode Date: Sun, 15 Jul 2012 12:33:37 -0400 Message-ID: References: <87ipdqx6e4.fsf@gnu.org> <87a9z19jgj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1342370060 9733 80.91.229.3 (15 Jul 2012 16:34:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 15 Jul 2012 16:34:20 +0000 (UTC) Cc: 11520@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 15 18:34:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SqRlx-0003Mw-HU for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jul 2012 18:34:17 +0200 Original-Received: from localhost ([::1]:55955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqRlw-0007He-Sf for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jul 2012 12:34:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqRlu-0007HN-5w for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 12:34:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqRlt-0003ds-1H for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 12:34:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqRls-0003dm-Ty for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 12:34:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SqRrV-0000G2-TJ for bug-gnu-emacs@gnu.org; Sun, 15 Jul 2012 12:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simon Law Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jul 2012 16:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11520-submit@debbugs.gnu.org id=B11520.1342370390969 (code B ref 11520); Sun, 15 Jul 2012 16:40:01 +0000 Original-Received: (at 11520) by debbugs.gnu.org; 15 Jul 2012 16:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:42986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqRrK-0000Fa-9a for submit@debbugs.gnu.org; Sun, 15 Jul 2012 12:39:50 -0400 Original-Received: from mail-bk0-f44.google.com ([209.85.214.44]:43143) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqRrI-0000FT-JK for 11520@debbugs.gnu.org; Sun, 15 Jul 2012 12:39:49 -0400 Original-Received: by bkty7 with SMTP id y7so3461339bkt.3 for <11520@debbugs.gnu.org>; Sun, 15 Jul 2012 09:33:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:x-gm-message-state; bh=eTalOmpGAkYaLUxShiE+NiecdxVKy1g5fq/zCu9ROzU=; b=k1kiNvJU4B8cX2xDgSQqTbiUgj812RBs0vK37qqvMzUsE75+Vb7Fv7UJ4deFyI1FXi jCwtOwFkTlafWn8p8bJc0LHVvXn0Sn473GZRzYfM34Vjsd2ML+Qf02+IBdL16m2LN24E 22WNbHt4EJ0rLD0MB12wWwFkpCrFEIB6ScgGUfN8kClS04ZvMWOzhRE9VCkLNTmiyi/t CJzeuB11P37sFo/jisE+Ptij6e7NUjO0piii0tA5DTsMfmHw4lDPkBBZFFLoF9dhdb5S aHqBDpV2Zvy/Yb7IegThhAgMYhzsva51nVazI5ilfCTEn/TPMs9kZ+qY4eapw2EMPuMB Mv4g== Original-Received: by 10.204.128.214 with SMTP id l22mr3558866bks.86.1342370037852; Sun, 15 Jul 2012 09:33:57 -0700 (PDT) Original-Received: by 10.204.187.208 with HTTP; Sun, 15 Jul 2012 09:33:37 -0700 (PDT) X-Originating-IP: [69.196.162.212] In-Reply-To: <87a9z19jgj.fsf@gnu.org> X-Gm-Message-State: ALoCoQnhgQCMmmoHYDhgrxijYgPvt4amBb0RAne7/dLU61VFKYjl9IF6BYGu2J6W2yt7TuEVgBep X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61964 Archived-At: On Sun, Jul 15, 2012 at 10:39 AM, Chong Yidong wrote: > Simon Law writes: > >> I tested your fix and it makes electric-pair-mode insert pairs in the >> right order now. >> >> But the bug is that delete-selection-mode destroys >> electric-pair-mode's auto-wrapping ability. Unfortunately, your fix >> does not address that. > > Hmm, I guess I misunderstood the bug. I'll re-open it. > > Trying to work up a patch that does the right thing is not so > straightforward, though, as electric-pair-post-self-insert-function does > not have a simple triggering condition. I proposed making delete-selection-pre-hook understand a function as one of the legitimate types. If it were a function, it gets called and its results would be interpreted as type, either: 'yank, 'kill, 'supersede, t, or nil. That way, electric-pair-mode can override the (put 'self-insert-command 'delete-selection ...) with its own function that understands the triggering condition. The triggering condition would be extracted from electric-pair-post-self-insert-function so it could be used in two places. Sound good? P.S. I don't have an bzr checkout of Emacs right now. Would this be something useful to target against Emacs 24 as a bugfix? -- Cheers, Simon - http://ca.linkedin.com/in/sfllaw/