From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#16856: [PATCH] Prevent bar cursor overwriting next glyph (bug#16856) Date: Mon, 18 Jul 2016 15:26:57 +0100 Message-ID: References: <20160717084232.GA3426@breton.holly.idiocy.org> <20160717135131.GA4810@breton.holly.idiocy.org> <58701B24-4BAC-4B03-B173-AE6F1D3468F3@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1468852119 23931 80.91.229.3 (18 Jul 2016 14:28:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2016 14:28:39 +0000 (UTC) Cc: 16856@debbugs.gnu.org To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 18 16:28:30 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bP9X3-0005im-3Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 16:28:29 +0200 Original-Received: from localhost ([::1]:47870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9X2-0001iJ-G3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 10:28:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9Wi-0001Me-Hw for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 10:28:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP9Wc-0005se-NO for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 10:28:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9Wc-0005sY-JY for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 10:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bP9Wc-0007tN-8Y for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 16856-submit@debbugs.gnu.org id=B16856.146885202430267 (code B ref 16856); Mon, 18 Jul 2016 14:28:02 +0000 Original-Received: (at 16856) by debbugs.gnu.org; 18 Jul 2016 14:27:04 +0000 Original-Received: from localhost ([127.0.0.1]:55866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9Vg-0007s7-BH for submit@debbugs.gnu.org; Mon, 18 Jul 2016 10:27:04 -0400 Original-Received: from mail-vk0-f41.google.com ([209.85.213.41]:35378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9Vf-0007rd-9Q for 16856@debbugs.gnu.org; Mon, 18 Jul 2016 10:27:03 -0400 Original-Received: by mail-vk0-f41.google.com with SMTP id w127so182368488vkh.2 for <16856@debbugs.gnu.org>; Mon, 18 Jul 2016 07:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Va2MhWxD1zdYrylDjlbOQtoVqg3wCbvKDocRxGLgz9E=; b=NHeIi/GFqiMKadt3ZInvjWGX6HIecJ0bHNXQieZmnsIoZfdJvn5mOxZ70VrpDr3RMw acpQ12wdUh9CSjjs0oXzieQVD2r23j/QEXk4+SkgZZmJK4SYwslZ9Xp4J+Y6vYs0yGQN x2RPTXFUXwU6tAjpx/rFGOI/lcKMV1QrT+5HGNCyiS6gbfAY8ff9kWjwb478/oI3V30b 6nOQklzMI2ggoHP/B/X+rAV/zg9pX3WEKlEBtekAczrSUu0HLuLtE3LFfN2F+kOTdfYf 0t25xBwm9PXfyMkcfn8hwNmx5ihGYHfA79IswtGvxt2iAajm1apA8WF5e+EJZhsI5tpe bHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Va2MhWxD1zdYrylDjlbOQtoVqg3wCbvKDocRxGLgz9E=; b=OErEEz+scnnlpqhr8rFdimW0IDk69PEpu3RLW1NyGdQvlEhKljr98FyDNCJF372qaE dK8xcVkQNR3Ir9FcSkvLe9x3YeHClUaKFGLocra3UHOi5fdVIjxVjyq5Be7wInpImppf gKK6GDV2QZZzSzQQgfcq5UQW8fd/XdENhU1ebHwn5AIIKoy7vJ+MZuSazUeyBxRsnXLh J3tUbLyEXcFhcyX8IZ7mfjFAl8k+SKsKZKwLpg25ojHc/K2VpXpuHWOX52i8wIsSs/Xc ZBKkdkhceFAcogWvO7/4mKRGMhhgTRPMyvyjDCIQPJndyLnd8k+v9PrwV2Cp66PHBLay 904A== X-Gm-Message-State: ALyK8tI+SxhB8lmnaZc7N5A4HL4nLE7rS4YVOyRNPauhOm+NhhEPLlZjx7Zaop+x/hMWcxAQKwz39wlEeOtaMQ== X-Received: by 10.31.4.4 with SMTP id 4mr18311326vke.121.1468852017857; Mon, 18 Jul 2016 07:26:57 -0700 (PDT) Original-Received: by 10.176.65.41 with HTTP; Mon, 18 Jul 2016 07:26:57 -0700 (PDT) In-Reply-To: <58701B24-4BAC-4B03-B173-AE6F1D3468F3@gmail.com> X-Google-Sender-Auth: Rwiqt_913OlG9dyBHzw0WWxVS20 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121218 Archived-At: On 17 July 2016 at 23:54, David Reitter wrote: > No ill effects with that. What is the glyph at the end of the line? I don't know how the end-of-line is displayed. On the Windows Emacs I've got here it's a narrow glyph (same as space, I think), so the bar isn't displayed at it's full width if it's set to be wide. I expect it'll be the same on the Mac, I can check later if you want. > Also, about your patch, it seems like w->phys_cursor_width will then just be whatever it was before. No, w->phys_cursor_width appears to hold the glyph width by default, so we should end up with the smaller of cursor_width or the glyph width. I realise it might be more desirable to have the bar cursor be a consistent width, but that would make the NS port different from all the others, afaics. -- Alan Third