* Re: Documenting NEWS features for 25.1 @ 2016-01-11 12:02 Shakthi Kannan 2016-01-11 18:20 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2016-01-11 12:02 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 128 bytes --] Hi, Attached patch on "Documenting new js.el option 'js-indent-first-init'. SK -- Shakthi Kannan http://www.shakthimaan.com [-- Attachment #2: 0001-Document-new-js.el-option-js-indent-first-init.patch --] [-- Type: text/x-patch, Size: 870 bytes --] From b45642e5980596e91bbe26c0686e9a1d201c0e92 Mon Sep 17 00:00:00 2001 From: Shakthi Kannan <author@shakthimaan.com> Date: Mon, 11 Jan 2016 17:26:00 +0530 Subject: [PATCH] Document new js.el option 'js-indent-first-init' * progmodes/js.el (js-indent-first-init): Rename from js-indent-first-initialiser, to avoid worrying about American vs British spelling. --- etc/NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 06cd38e..d1fbc4d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -724,7 +724,10 @@ If the output of ERT tests in batch mode execution can be saved to a log file, then it can be passed as an argument to the above function to produce a neat summary. +--- ** New js.el option `js-indent-first-init'. +Renamed from js-indent-first-initialiser, to avoid worrying about +American vs British spelling. ** Info -- 2.1.4 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-11 12:02 Documenting NEWS features for 25.1 Shakthi Kannan @ 2016-01-11 18:20 ` Eli Zaretskii 2016-01-12 4:28 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2016-01-11 18:20 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Mon, 11 Jan 2016 17:32:11 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > Attached patch on "Documenting new js.el option 'js-indent-first-init'. Thanks, pushed. 2 minor nits: > From b45642e5980596e91bbe26c0686e9a1d201c0e92 Mon Sep 17 00:00:00 2001 > From: Shakthi Kannan <author@shakthimaan.com> Could you please use the same address as the one that appears on your assignment? > Subject: [PATCH] Document new js.el option 'js-indent-first-init' > > * progmodes/js.el (js-indent-first-init): Rename from > js-indent-first-initialiser, to avoid worrying about American vs British > spelling. The log message should describe the changes in the patch, not the original changes for which the NEWS entry was written. Thanks again for working on this. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-11 18:20 ` Eli Zaretskii @ 2016-01-12 4:28 ` Shakthi Kannan 2016-01-12 15:45 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2016-01-12 4:28 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Hi Eli, --- On Mon, Jan 11, 2016 at 11:50 PM, Eli Zaretskii <eliz@gnu.org> wrote: | Could you please use the same address as the one that appears on your | assignment? \-- Actually, I have just got SSL certificates for my personal domain which uses the copyright assignment e-mail address. So, I will soon start using it for sending patches. --- | The log message should describe the changes in the patch, not the | original changes for which the NEWS entry was written. \-- Oops! My bad. Will remember in future. Thanks for patiently correcting my mistakes. SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-12 4:28 ` Shakthi Kannan @ 2016-01-12 15:45 ` Eli Zaretskii 2016-01-12 15:55 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2016-01-12 15:45 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Tue, 12 Jan 2016 09:58:28 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > --- On Mon, Jan 11, 2016 at 11:50 PM, Eli Zaretskii <eliz@gnu.org> wrote: > | Could you please use the same address as the one that appears on your > | assignment? > \-- > > Actually, I have just got SSL certificates for my personal domain > which uses the copyright assignment e-mail address. So, I will soon > start using it for sending patches. Could you please write to assign@gnu.org and ask them to update your email address in the your assignment they keep on file? ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-12 15:45 ` Eli Zaretskii @ 2016-01-12 15:55 ` Shakthi Kannan 2016-01-12 16:08 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2016-01-12 15:55 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Hi, --- On Tue, Jan 12, 2016 at 9:15 PM, Eli Zaretskii <eliz@gnu.org> wrote: | Could you please write to assign@gnu.org and ask them to update your | email address in the your assignment they keep on file? \-- The assignment paper has the correct e-mail address, author@shakthimaan.com. Just that I have been sending patches using my Gmail account. Should I still inform them? SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-12 15:55 ` Shakthi Kannan @ 2016-01-12 16:08 ` Eli Zaretskii 0 siblings, 0 replies; 23+ messages in thread From: Eli Zaretskii @ 2016-01-12 16:08 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Tue, 12 Jan 2016 21:25:02 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > --- On Tue, Jan 12, 2016 at 9:15 PM, Eli Zaretskii <eliz@gnu.org> wrote: > | Could you please write to assign@gnu.org and ask them to update your > | email address in the your assignment they keep on file? > \-- > > The assignment paper has the correct e-mail address, > author@shakthimaan.com. Not the list I see, it has shakthimaan@gmail.com. I just checked. > Should I still inform them? Yes, please. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 @ 2016-01-19 16:49 Shakthi Kannan 2016-01-19 18:39 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2016-01-19 16:49 UTC (permalink / raw) To: emacs-devel; +Cc: eliz [-- Attachment #1: Type: text/plain, Size: 306 bytes --] Hi, I have attached a patch marking cl-generic.el and system-name indicating that they do not require any changes in the manual. The documentation of pcase, following the long discussion in the mailing list, is the only one left unmarked. Regards, SK -- Shakthi Kannan http://www.shakthimaan.com [-- Attachment #2: 0001-etc-NEWS-No-change-for-cl-generic.el-and-system-name.patch --] [-- Type: text/x-patch, Size: 1040 bytes --] From eef29be74881ccdd90a81d6cf682ffda9bd603f0 Mon Sep 17 00:00:00 2001 From: Shakthi Kannan <author@shakthimaan.com> Date: Tue, 19 Jan 2016 22:09:13 +0530 Subject: [PATCH] ; * etc/NEWS: No change for cl-generic.el and system-name --- etc/NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index e9b539a..361f8dd 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1156,6 +1156,7 @@ command is called from Emacs (i.e., INSIDE_EMACS environment variable is set). This feature requires newer versions of GnuPG (2.1.5 or later) and Pinentry (0.9.5 or later). +--- ** cl-generic.el provides CLOS-style multiple-dispatch generic functions. --- @@ -1520,6 +1521,7 @@ permissions set to temporary values (e.g., for creating private files). +++ ** Function `sort' can deal with vectors. +--- ** Function `system-name' now returns an updated value if the current system's name has changed or if the Emacs process has changed systems, and to avoid long waits it no longer consults DNS to canonicalize the -- 2.1.4 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2016-01-19 16:49 Shakthi Kannan @ 2016-01-19 18:39 ` Eli Zaretskii 0 siblings, 0 replies; 23+ messages in thread From: Eli Zaretskii @ 2016-01-19 18:39 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Tue, 19 Jan 2016 11:49:17 -0500 > From: Shakthi Kannan <author@shakthimaan.com> > Cc: eliz@gnu.org > > I have attached a patch marking cl-generic.el and system-name > indicating that they do not require any changes in the manual. Thanks. I pushed the 'system-name' part, but not the other one: I think cl-generic.el facilities should be documented in the ELisp manual. See bug#22336. Thank you for helping out with this job, which is now almost done. ^ permalink raw reply [flat|nested] 23+ messages in thread
[parent not found: <20151212115202.16784.72345@vcs.savannah.gnu.org>]
[parent not found: <E1a7iiY-0004NK-Ky@vcs.savannah.gnu.org>]
* Re: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode [not found] ` <E1a7iiY-0004NK-Ky@vcs.savannah.gnu.org> @ 2015-12-15 1:36 ` John Wiegley 2015-12-15 3:39 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: John Wiegley @ 2015-12-15 1:36 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 613 bytes --] >>>>> Eli Zaretskii <eliz@gnu.org> writes: > Document the new bindings of <UP> and <DOWN> in the minibuffer > Document new features of Ido > Document the change in interactive shell mode > Document new features of package.el > Update and document new features of xterm support > Document new features of Prettify Mode > Document multi-mode indentation facilities > Document 'vc-refresh-state' Eli, much respect. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 629 bytes --] ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode 2015-12-15 1:36 ` [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode John Wiegley @ 2015-12-15 3:39 ` Eli Zaretskii 2015-12-15 6:10 ` John Wiegley 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-15 3:39 UTC (permalink / raw) To: John Wiegley; +Cc: emacs-devel > From: John Wiegley <jwiegley@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > Date: Mon, 14 Dec 2015 17:36:28 -0800 > > >>>>> Eli Zaretskii <eliz@gnu.org> writes: > > > Document the new bindings of <UP> and <DOWN> in the minibuffer > > Document new features of Ido > > Document the change in interactive shell mode > > Document new features of package.el > > Update and document new features of xterm support > > Document new features of Prettify Mode > > Document multi-mode indentation facilities > > Document 'vc-refresh-state' > > Eli, much respect. Thanks, I'm still only 35% into NEWS, and no one else seems to care. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode 2015-12-15 3:39 ` Eli Zaretskii @ 2015-12-15 6:10 ` John Wiegley 2015-12-15 17:51 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: John Wiegley @ 2015-12-15 6:10 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel >>>>> Eli Zaretskii <eliz@gnu.org> writes: > Thanks, I'm still only 35% into NEWS, and no one else seems to care. Would anyone else like to help out Eli with documenting the new features that will be coming into 25.1? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode 2015-12-15 6:10 ` John Wiegley @ 2015-12-15 17:51 ` Shakthi Kannan 2015-12-15 17:58 ` Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) John Wiegley 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-15 17:51 UTC (permalink / raw) To: Eli Zaretskii, Emacs developers Hi Eli, --- On Tue, Dec 15, 2015 at 11:40 AM, John Wiegley <jwiegley@gmail.com> wrote: | Would anyone else like to help out Eli with documenting the new features that | will be coming into 25.1? \-- I shall pick this up. SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) 2015-12-15 17:51 ` Shakthi Kannan @ 2015-12-15 17:58 ` John Wiegley 2015-12-15 18:34 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: John Wiegley @ 2015-12-15 17:58 UTC (permalink / raw) To: Shakthi Kannan; +Cc: Eli Zaretskii, Emacs developers [-- Attachment #1: Type: text/plain, Size: 481 bytes --] >>>>> Shakthi Kannan <shakthimaan@gmail.com> writes: > I shall pick this up. Eli, would you be willing to identify the list of features in NEWS still needing work? I'm going to speak to more developers at an Emacs user's group meeting in about an hour, and will mention to them also that you need help in this area. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 629 bytes --] ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) 2015-12-15 17:58 ` Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) John Wiegley @ 2015-12-15 18:34 ` Eli Zaretskii 2015-12-16 6:09 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-15 18:34 UTC (permalink / raw) To: John Wiegley; +Cc: shakthimaan, emacs-devel > From: John Wiegley <jwiegley@gmail.com> > Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org> > Date: Tue, 15 Dec 2015 09:58:56 -0800 > > >>>>> Shakthi Kannan <shakthimaan@gmail.com> writes: > > > I shall pick this up. > > Eli, would you be willing to identify the list of features in NEWS still > needing work? Each entry that is not already marked needs either to be documented, or a decision should be made that it doesn't need to be. See the beginning of NEWS for the legend. I'd prefer that people who never did this kind of job before in Emacs ask here each time whether a certain entry should be reflected in documentation or not, and then documenting those that should. Please note that the doc strings of the code corresponding to each entry should also be reviewed, to see if they are clear enough and complete. Bonus points for trying the feature and reporting any unusual findings. > I'm going to speak to more developers at an Emacs user's group > meeting in about an hour, and will mention to them also that you > need help in this area. Thanks. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) 2015-12-15 18:34 ` Eli Zaretskii @ 2015-12-16 6:09 ` Shakthi Kannan 2015-12-16 6:44 ` Documenting NEWS features for 25.1 John Wiegley 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-16 6:09 UTC (permalink / raw) To: Eli Zaretskii; +Cc: John Wiegley, Emacs developers Eli, --- On Wed, Dec 16, 2015 at 12:04 AM, Eli Zaretskii <eliz@gnu.org> wrote: | I'd prefer that people who never did this kind of job before in Emacs | ask here each time whether a certain entry should be reflected in | documentation or not, and then documenting those that should. \-- For "Document the change in interactive shell mode", I already see a commit "4b0e4213740ef32938063e1dd79f8462112ca33c" with the same subject in emacs-25 branch. So, this is done? Which among the following needs to be documented? Document the new bindings of <UP> and <DOWN> in the minibuffer Document new features of Ido Document the change in interactive shell mode Document new features of package.el Update and document new features of xterm support Document new features of Prettify Mode Document multi-mode indentation facilities Document 'vc-refresh-state' Would it be possible to use a TODO list in the NEWS file to indicate which parts need to be documented, and are in a pending state? Thanks! SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 6:09 ` Shakthi Kannan @ 2015-12-16 6:44 ` John Wiegley 2015-12-16 7:59 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: John Wiegley @ 2015-12-16 6:44 UTC (permalink / raw) To: Shakthi Kannan; +Cc: Eli Zaretskii, Emacs developers >>>>> Shakthi Kannan <shakthimaan@gmail.com> writes: > Which among the following needs to be documented? [...] The list I gave there was what Eli had documented just yesterday! > Would it be possible to use a TODO list in the NEWS file to indicate which > parts need to be documented, and are in a pending state? Check the NEWS file itself. I believe that entries lacking a +++ or --- marker need attention. For each of those, ask here about what is needed to proceed. That should generate the TODO list that you're looking for. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 6:44 ` Documenting NEWS features for 25.1 John Wiegley @ 2015-12-16 7:59 ` Shakthi Kannan 2015-12-16 10:20 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-16 7:59 UTC (permalink / raw) To: Shakthi Kannan, Eli Zaretskii, Emacs developers Hi, --- On Wed, Dec 16, 2015 at 12:14 PM, John Wiegley <jwiegley@gmail.com> wrote: | Check the NEWS file itself. I believe that entries lacking a +++ or --- marker | need attention. For each of those, ask here about what is needed to proceed. | That should generate the TODO list that you're looking for. \-- Got it. Can I write one for the following, and send a patch to this thread? ** Lisp mode *** Strings after `:documentation' are highlighted as docstrings. SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 7:59 ` Shakthi Kannan @ 2015-12-16 10:20 ` Eli Zaretskii 2015-12-16 10:36 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-16 10:20 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Wed, 16 Dec 2015 13:29:13 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > > Got it. Can I write one for the following, and send a patch to this thread? > > ** Lisp mode > *** Strings after `:documentation' are highlighted as docstrings. Yes, thanks. Please send patches to bug-gnu-emacs@gnu.org, though. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 10:20 ` Eli Zaretskii @ 2015-12-16 10:36 ` Shakthi Kannan 2015-12-16 11:11 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-16 10:36 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Eli, --- | *** Strings after `:documentation' are highlighted as docstrings. \-- Is there a sample function that demonstrates the above that I can test and verify? (defun test nil "echo Hello, World!" (message "Hello, World")) Where does :documentation fit in the above example? SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 10:36 ` Shakthi Kannan @ 2015-12-16 11:11 ` Eli Zaretskii 2015-12-16 12:29 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-16 11:11 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Wed, 16 Dec 2015 16:06:34 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > Eli, > > --- > | *** Strings after `:documentation' are highlighted as docstrings. > \-- > > Is there a sample function that demonstrates the above that I can test > and verify? > > (defun test nil > "echo Hello, World!" > (message "Hello, World")) > > Where does :documentation fit in the above example? I don't know, sorry. Some NEWS entries turn out to be small research projects. What I usually do is use "git annotate" on NEWS to find what commit added the entry, then look at the commit itself, and if necessary also at discussions or bug reports it points to (or any related discussions on the 2 mailing lists around the date of the commit). If none of this gets you the answer, I guess contacting the author of the commit is yet another way to find out. Thanks. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 11:11 ` Eli Zaretskii @ 2015-12-16 12:29 ` Shakthi Kannan 2015-12-21 17:09 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-16 12:29 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Hi, --- On Wed, Dec 16, 2015 at 4:41 PM, Eli Zaretskii <eliz@gnu.org> wrote: | Some NEWS entries turn out to be small research projects. What I | usually do is use "git annotate" on NEWS to find what commit added the | entry, then look at the commit itself, and if necessary also at | discussions or bug reports it points to (or any related discussions on | the 2 mailing lists around the date of the commit). \-- Got it. Thanks! Found the bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=9130 Will send the patch soon. SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-16 12:29 ` Shakthi Kannan @ 2015-12-21 17:09 ` Shakthi Kannan 2015-12-21 17:28 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-21 17:09 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Hi Eli, For the entry in etc/NEWS that contains: **** Macro `calendar-for-loop'. I found that this macro has been removed in lisp/calendar/calendar.el in commit ("3f65970414538063e38ada2a47cb4ef4f35b630e") and has been mentioned in ChangeLog.17 by "2014-10-06 Glenn Morris <rgm@gnu.org>". Can the news entry be the following? === BEGIN === --- **** Macro `calendar-for-loop'. The calendar-for-loop macro in lisp/calendar/calendar.el has been made obsolete. === END === SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-21 17:09 ` Shakthi Kannan @ 2015-12-21 17:28 ` Eli Zaretskii 2015-12-24 16:49 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-21 17:28 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Mon, 21 Dec 2015 22:39:15 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > For the entry in etc/NEWS that contains: > > **** Macro `calendar-for-loop'. > > I found that this macro has been removed in lisp/calendar/calendar.el > in commit ("3f65970414538063e38ada2a47cb4ef4f35b630e") and has been > mentioned in ChangeLog.17 by "2014-10-06 Glenn Morris <rgm@gnu.org>". > Can the news entry be the following? > > === BEGIN === > > --- > **** Macro `calendar-for-loop'. > The calendar-for-loop macro in lisp/calendar/calendar.el has been made obsolete. > > === END === There's a header above that which says: *** Many items obsolete since at least version 23.1 have been removed. And it is already marked with "---", which covers this entry as well. So I think this entry (and all its siblings) is already taken care of. Thanks. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-21 17:28 ` Eli Zaretskii @ 2015-12-24 16:49 ` Shakthi Kannan 2015-12-25 14:24 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-24 16:49 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 783 bytes --] Hi, NEWS entry: ** New ERT function `ert-summarize-tests-batch-and-exit'. I have verified the function by creating a sample test.el file whose contents are as follows: (ert-deftest example-test () (should (= (+ 9 2) 11))) I was able to run the test, and capture the output using: $ emacs -batch -l ert -l test.el -f ert-run-tests-batch > test.log I compiled emacs-25, and ran the following to produce the expected summary result as shown below: $ ./src/emacs -batch -l ert -f ert-summarize-tests-batch-and-exit test.log SUMMARY OF TEST RESULTS ----------------------- Files examined: 1 Ran 1 tests, 1 results as expected Is the attached documentation change fine? I can then send you an actual patch. Regards, SK -- Shakthi Kannan http://www.shakthimaan.com [-- Attachment #2: ert-summarize.patch --] [-- Type: text/x-patch, Size: 1270 bytes --] diff --git a/doc/misc/ert.texi b/doc/misc/ert.texi index 35d315c..d29c1d8 100644 --- a/doc/misc/ert.texi +++ b/doc/misc/ert.texi @@ -283,6 +283,15 @@ Running Tests in Batch Mode failed or if anything else went wrong. It will also print progress messages and error diagnostics to standard output. +You can also redirect the above output to a log file, say +@code{output.log}, and use the +@code{ert-summarize-tests-batch-and-exit} function to produce a neat +summary as shown below: + +@example +emacs -batch -l ert -f ert-summarize-tests-batch-and-exit output.log +@end example + If ERT is not part of your Emacs distribution, you may need to use @code{-L /path/to/ert/} so that Emacs can find it. You may need additional @code{-L} flags to ensure that @code{my-tests.el} and all the diff --git a/etc/NEWS b/etc/NEWS index 19c9858..f1ba79f 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -696,7 +696,11 @@ The remainder were: **** The nil and list forms of `diary-display-function'. ++++ ** New ERT function `ert-summarize-tests-batch-and-exit'. +If the output of ERT tests in batch mode execution can be saved to a +log file, then it can be passed as an argument to the above function +to produce a neat summary. ** New js.el option `js-indent-first-init'. ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-24 16:49 ` Shakthi Kannan @ 2015-12-25 14:24 ` Eli Zaretskii 2015-12-28 17:25 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-25 14:24 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Thu, 24 Dec 2015 22:19:33 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > Is the attached documentation change fine? Yes, with one minor comment: > +You can also redirect the above output to a log file, say > +@code{output.log}, and use the ^^^^^^^^^^^^^^^^^ Please use the @file markup for file names, not @code. Other than that, LGTM. Thanks! ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-25 14:24 ` Eli Zaretskii @ 2015-12-28 17:25 ` Shakthi Kannan 2015-12-29 16:59 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-28 17:25 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 249 bytes --] Hi, Attached is a patch for "Document TeX mode custom variable and prettify symbols". Please let me know if this is fine or if you need changes, and I can then submit it to bug-gnu-emacs. Thanks! SK -- Shakthi Kannan http://www.shakthimaan.com [-- Attachment #2: 0001-Document-TeX-mode-custom-variable-and-prettify-symbo.patch --] [-- Type: text/x-patch, Size: 3834 bytes --] From 5d3f64033b73022553f30e842a564924bf00a456 Mon Sep 17 00:00:00 2001 From: Shakthi Kannan <author@shakthimaan.com> Date: Mon, 28 Dec 2015 22:49:53 +0530 Subject: [PATCH] Document TeX mode custom variable and prettify symbols --- doc/emacs/programs.texi | 18 ++++++++++-------- doc/emacs/text.texi | 8 +++++++- etc/NEWS | 2 ++ 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi index 8423b70..f485983 100644 --- a/doc/emacs/programs.texi +++ b/doc/emacs/programs.texi @@ -1530,14 +1530,16 @@ Misc for Programs Prettify Symbols mode is a buffer-local minor mode that replaces certain strings with more attractive versions for display purposes. For example, in Emacs Lisp mode, it replaces the string @samp{lambda} -with the Greek lambda character @samp{λ}. You may wish to use this in -non-programming modes as well. You can customize the mode by adding -more entries to @code{prettify-symbols-alist}. More elaborate -customization is available via customizing -@code{prettify-symbols-compose-predicate} if its default value -@code{prettify-symbols-default-compose-p} is not appropriate. There -is also a global version, @code{global-prettify-symbols-mode}, which -enables the mode in all buffers that support it. +with the Greek lambda character @samp{λ}. In a TeX buffer, it will +replace @samp{\alpha} ... @samp{\omega} and other math macros with +their unicode characters. You may wish to use this in non-programming +modes as well. You can customize the mode by adding more entries to +@code{prettify-symbols-alist}. More elaborate customization is +available via customizing @code{prettify-symbols-compose-predicate} if +its default value @code{prettify-symbols-default-compose-p} is not +appropriate. There is also a global version, +@code{global-prettify-symbols-mode}, which enables the mode in all +buffers that support it. The symbol at point can be shown in its original form. This is controlled by the variable @code{prettify-symbols-unprettify-at-point}: diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi index bab660e..c91b26c 100644 --- a/doc/emacs/text.texi +++ b/doc/emacs/text.texi @@ -1717,6 +1717,7 @@ TeX Print @vindex latex-run-command @vindex tex-dvi-view-command @vindex tex-dvi-print-command +@vindex tex-print-file-extension The buffer's @TeX{} variant determines what shell command @kbd{C-c C-b} actually runs. In Plain @TeX{} mode, it is specified by the variable @code{tex-run-command}, which defaults to @code{"tex"}. In @@ -1725,7 +1726,12 @@ TeX Print to view the @file{.dvi} output is determined by the variable @code{tex-dvi-view-command}, regardless of the @TeX{} variant. The shell command that @kbd{C-c C-p} runs to print the output is -determined by the variable @code{tex-dvi-print-command}. +determined by the variable @code{tex-dvi-print-command}. The variable +@code{tex-print-file-extension} can be set to the required file +extension for viewing and printing Tex-compiled files. For example, +you can set it to @code{".pdf"}, and update +@code{tex-dvi-view-command} and @code{tex-dvi-print-command} +accordingly. Normally, Emacs automatically appends the output file name to the shell command strings described in the preceding paragraph. For diff --git a/etc/NEWS b/etc/NEWS index 1aeab35..76d6df2 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -879,9 +879,11 @@ name patterns (e.g. all "FOR_DOXYGEN_ONLY_*") to be excluded. ** TeX mode ++++ *** New custom variable `tex-print-file-extension' to help users who use PDF instead of DVI. ++++ *** TeX mode now supports Prettify Symbols mode. When enabling `prettify-symbols-mode' in a tex-mode buffer, \alpha ... \omega, and many other math macros are displayed using unicode characters. -- 2.1.4 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-28 17:25 ` Shakthi Kannan @ 2015-12-29 16:59 ` Eli Zaretskii 2015-12-30 5:40 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-29 16:59 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Mon, 28 Dec 2015 22:55:50 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > Attached is a patch for "Document TeX mode custom variable and > prettify symbols". Thanks. A few comments below. > +with the Greek lambda character @samp{λ}. In a TeX buffer, it will ^^ ^^^ Two spaces between sentences, please (we use the US English conventions). Also, please use @TeX{} for "TeX", the result looks prettier in the printed manual and in PDF. > +replace @samp{\alpha} ... @samp{\omega} and other math macros with ^^^ Please use @dots{} for "...", the result looks prettier in print. > +their unicode characters. You may wish to use this in non-programming ^^^^^^^ ^^ "Unicode", capitalized. And 2 spaces after the sentence again. > @@ -1725,7 +1726,12 @@ TeX Print > to view the @file{.dvi} output is determined by the variable > @code{tex-dvi-view-command}, regardless of the @TeX{} variant. The > shell command that @kbd{C-c C-p} runs to print the output is > -determined by the variable @code{tex-dvi-print-command}. > +determined by the variable @code{tex-dvi-print-command}. The variable ^^ Two spaces. > +@code{tex-print-file-extension} can be set to the required file > +extension for viewing and printing Tex-compiled files. For example, ^^^ ^^ @TeX{} and 2 spaces. > +you can set it to @code{".pdf"}, and update The correct markup for file names and their parts is @file{.pdf} (no quotes are necessary, as @file will supply them). Thanks again for working on this. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-29 16:59 ` Eli Zaretskii @ 2015-12-30 5:40 ` Shakthi Kannan 2015-12-30 17:49 ` Eli Zaretskii 0 siblings, 1 reply; 23+ messages in thread From: Shakthi Kannan @ 2015-12-30 5:40 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers [-- Attachment #1: Type: text/plain, Size: 359 bytes --] Hi, --- On Tue, Dec 29, 2015 at 10:29 PM, Eli Zaretskii <eliz@gnu.org> wrote: | Thanks. A few comments below. \-- I have made the following changes, and re-attached the patch: * Two spaces between sentences. * Used @TeX{}. * Use @dots{} for "...". * "Unicode" is capitalized. * Used @file{.pdf} Regards, SK -- Shakthi Kannan http://www.shakthimaan.com [-- Attachment #2: 0001-Document-TeX-mode-custom-variable-and-prettify-symbo.patch --] [-- Type: text/x-patch, Size: 3846 bytes --] From f71133addf24182b7e88ebc374b635d30632df36 Mon Sep 17 00:00:00 2001 From: Shakthi Kannan <author@shakthimaan.com> Date: Wed, 30 Dec 2015 11:07:57 +0530 Subject: [PATCH] Document TeX mode custom variable and prettify symbols --- doc/emacs/programs.texi | 18 ++++++++++-------- doc/emacs/text.texi | 8 +++++++- etc/NEWS | 2 ++ 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi index 8423b70..83695b1 100644 --- a/doc/emacs/programs.texi +++ b/doc/emacs/programs.texi @@ -1530,14 +1530,16 @@ Misc for Programs Prettify Symbols mode is a buffer-local minor mode that replaces certain strings with more attractive versions for display purposes. For example, in Emacs Lisp mode, it replaces the string @samp{lambda} -with the Greek lambda character @samp{λ}. You may wish to use this in -non-programming modes as well. You can customize the mode by adding -more entries to @code{prettify-symbols-alist}. More elaborate -customization is available via customizing -@code{prettify-symbols-compose-predicate} if its default value -@code{prettify-symbols-default-compose-p} is not appropriate. There -is also a global version, @code{global-prettify-symbols-mode}, which -enables the mode in all buffers that support it. +with the Greek lambda character @samp{λ}. In a @TeX{} buffer, it will +replace @samp{\alpha} @dots{} @samp{\omega} and other math macros with +their Unicode characters. You may wish to use this in non-programming +modes as well. You can customize the mode by adding more entries to +@code{prettify-symbols-alist}. More elaborate customization is +available via customizing @code{prettify-symbols-compose-predicate} if +its default value @code{prettify-symbols-default-compose-p} is not +appropriate. There is also a global version, +@code{global-prettify-symbols-mode}, which enables the mode in all +buffers that support it. The symbol at point can be shown in its original form. This is controlled by the variable @code{prettify-symbols-unprettify-at-point}: diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi index bab660e..d18c3c7 100644 --- a/doc/emacs/text.texi +++ b/doc/emacs/text.texi @@ -1717,6 +1717,7 @@ TeX Print @vindex latex-run-command @vindex tex-dvi-view-command @vindex tex-dvi-print-command +@vindex tex-print-file-extension The buffer's @TeX{} variant determines what shell command @kbd{C-c C-b} actually runs. In Plain @TeX{} mode, it is specified by the variable @code{tex-run-command}, which defaults to @code{"tex"}. In @@ -1725,7 +1726,12 @@ TeX Print to view the @file{.dvi} output is determined by the variable @code{tex-dvi-view-command}, regardless of the @TeX{} variant. The shell command that @kbd{C-c C-p} runs to print the output is -determined by the variable @code{tex-dvi-print-command}. +determined by the variable @code{tex-dvi-print-command}. The variable +@code{tex-print-file-extension} can be set to the required file +extension for viewing and printing @Tex{}-compiled files. For +example, you can set it to @file{.pdf}, and update +@code{tex-dvi-view-command} and @code{tex-dvi-print-command} +accordingly. Normally, Emacs automatically appends the output file name to the shell command strings described in the preceding paragraph. For diff --git a/etc/NEWS b/etc/NEWS index 1aeab35..76d6df2 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -879,9 +879,11 @@ name patterns (e.g. all "FOR_DOXYGEN_ONLY_*") to be excluded. ** TeX mode ++++ *** New custom variable `tex-print-file-extension' to help users who use PDF instead of DVI. ++++ *** TeX mode now supports Prettify Symbols mode. When enabling `prettify-symbols-mode' in a tex-mode buffer, \alpha ... \omega, and many other math macros are displayed using unicode characters. -- 2.1.4 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-30 5:40 ` Shakthi Kannan @ 2015-12-30 17:49 ` Eli Zaretskii 2015-12-31 5:33 ` Shakthi Kannan 0 siblings, 1 reply; 23+ messages in thread From: Eli Zaretskii @ 2015-12-30 17:49 UTC (permalink / raw) To: Shakthi Kannan; +Cc: emacs-devel > Date: Wed, 30 Dec 2015 11:10:22 +0530 > From: Shakthi Kannan <shakthimaan@gmail.com> > Cc: Emacs developers <emacs-devel@gnu.org> > > I have made the following changes, and re-attached the patch: > > * Two spaces between sentences. > * Used @TeX{}. > * Use @dots{} for "...". > * "Unicode" is capitalized. > * Used @file{.pdf} Thanks, pushed. Please in the future include ChangeLog-style commit log message, and also make sure to build the documentation you change (your patch had one typo -- @Tex{} instead of @TeX{} -- which prevented the manual from building). ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: Documenting NEWS features for 25.1 2015-12-30 17:49 ` Eli Zaretskii @ 2015-12-31 5:33 ` Shakthi Kannan 0 siblings, 0 replies; 23+ messages in thread From: Shakthi Kannan @ 2015-12-31 5:33 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Emacs developers Hi, --- On Wed, Dec 30, 2015 at 11:19 PM, Eli Zaretskii <eliz@gnu.org> wrote: | Thanks, pushed. | | Please in the future include ChangeLog-style commit log message | ... | also make sure to build the documentation you change (your patch had | one typo -- @Tex{} instead of @TeX{} \-- Will remember in future. Thanks again for patiently reviewing my patches. SK -- Shakthi Kannan http://www.shakthimaan.com ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2016-01-19 18:39 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-11 12:02 Documenting NEWS features for 25.1 Shakthi Kannan 2016-01-11 18:20 ` Eli Zaretskii 2016-01-12 4:28 ` Shakthi Kannan 2016-01-12 15:45 ` Eli Zaretskii 2016-01-12 15:55 ` Shakthi Kannan 2016-01-12 16:08 ` Eli Zaretskii -- strict thread matches above, loose matches on Subject: below -- 2016-01-19 16:49 Shakthi Kannan 2016-01-19 18:39 ` Eli Zaretskii [not found] <20151212115202.16784.72345@vcs.savannah.gnu.org> [not found] ` <E1a7iiY-0004NK-Ky@vcs.savannah.gnu.org> 2015-12-15 1:36 ` [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode John Wiegley 2015-12-15 3:39 ` Eli Zaretskii 2015-12-15 6:10 ` John Wiegley 2015-12-15 17:51 ` Shakthi Kannan 2015-12-15 17:58 ` Documenting NEWS features for 25.1 (was: [Emacs-diffs] emacs-25 3e14bad: Document new features of Prettify Mode) John Wiegley 2015-12-15 18:34 ` Eli Zaretskii 2015-12-16 6:09 ` Shakthi Kannan 2015-12-16 6:44 ` Documenting NEWS features for 25.1 John Wiegley 2015-12-16 7:59 ` Shakthi Kannan 2015-12-16 10:20 ` Eli Zaretskii 2015-12-16 10:36 ` Shakthi Kannan 2015-12-16 11:11 ` Eli Zaretskii 2015-12-16 12:29 ` Shakthi Kannan 2015-12-21 17:09 ` Shakthi Kannan 2015-12-21 17:28 ` Eli Zaretskii 2015-12-24 16:49 ` Shakthi Kannan 2015-12-25 14:24 ` Eli Zaretskii 2015-12-28 17:25 ` Shakthi Kannan 2015-12-29 16:59 ` Eli Zaretskii 2015-12-30 5:40 ` Shakthi Kannan 2015-12-30 17:49 ` Eli Zaretskii 2015-12-31 5:33 ` Shakthi Kannan
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.