From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lin Sun Newsgroups: gmane.emacs.bugs Subject: bug#70691: 30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default Date: Wed, 1 May 2024 06:40:25 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a4cb1f06175ec34b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17485"; mail-complaints-to="usenet@ciao.gmane.io" To: 70691@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 01 08:42:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s23fN-0004Kl-2N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 May 2024 08:42:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s23ex-0004nw-Ri; Wed, 01 May 2024 02:41:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s23ev-0004nZ-QF for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 02:41:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s23ev-0001yf-IK for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 02:41:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s23fG-0001tt-94 for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 02:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2024 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17145456777282 (code B ref -1); Wed, 01 May 2024 06:42:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 May 2024 06:41:17 +0000 Original-Received: from localhost ([127.0.0.1]:35669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s23eX-0001tO-27 for submit@debbugs.gnu.org; Wed, 01 May 2024 02:41:17 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:35984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s23eR-0001t6-8o for submit@debbugs.gnu.org; Wed, 01 May 2024 02:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s23dw-0004iu-UP for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 02:40:42 -0400 Original-Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s23dv-0001up-2F for bug-gnu-emacs@gnu.org; Wed, 01 May 2024 02:40:40 -0400 Original-Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a51a80b190bso419387966b.3 for ; Tue, 30 Apr 2024 23:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714545637; x=1715150437; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=1kVkLu2ycqv+NhfWRuItdRObq/mHxsWOZ+S+llSB0mI=; b=lV4woNP0U3XriPGihAsKUTS8mN1Lcr1te6x0SLoxQs/ku+e8WN5bje+4MW9i95ghML wzUlrl/0m77FYvP1S/sZ1dBH20+lCf4MIQUt8xrvKs3qsM7sk2cw/V+nZW0triSIZzIY 0MvseAb7YpbmE1Yn6SqUZL+gkjaGclGvjfrvuOFSyr8NYYBfs1ghX2vjW0dVh1JwM2j3 xQDtrTHZU/SbrGqtD3LKh23SU9Y0JT8TnzUMO8oQT/0y/bsyXQfmXdAecg7Toa7xpP9j V0koD2/xkRew6ZkBd4TuaWC/cjPpSiVnX4mc6HKnYKsrBzBCNQRhIPwdYdamZh0T/eyw os0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714545637; x=1715150437; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1kVkLu2ycqv+NhfWRuItdRObq/mHxsWOZ+S+llSB0mI=; b=KJyoilUAzuBERYn3hapZgYasfnczn2Tyh+0wRdoAbDzUlcF9uPcegVgQwKGh3w4zZg E/1boxJFskhjmBIS7eClX+CmgEM7ks8oTzMEYwjdzKHUvwGO8tiOFiFD6m+XxBkdtN1n OVHEMGM0QPPsEcVBHMwnsoQzIj13p5LaOSA3odyRZwhOlKiKbVb0KmFAQ82TvRThgJkP db7+cUutAKQX8HesqchpDmWjTAb80O+g9hEuu8hT71/hpdB87T1SvcNGWlGfrVVekSK0 jcXE83qerR7n6xnxS+YZ4VAyzzIzGhS1xfcAj1dr6mx6tCc/KuDo2sPYlGQWVZ0qkJsW kAeQ== X-Gm-Message-State: AOJu0Yx2OhM6vj399JmYY7kL/oE00yoaX+lsM98+FKbsap8/OfsJBtQY RvmSAk1xZ+W4YOhofEp5BdOElGfWj4dhiTsH9zImXMZG0lItxcE7ekZTT56V2KOaqKueCKQILXf lMt+8Ldvzduqtkd9SCm0R1z0X2SkR8x+G X-Google-Smtp-Source: AGHT+IEagIDIygcrsiyYbVLQwrp50DUxMyy9Og7/FSUBHekj3gfsWBwIb3NKxP1urpSJ3EcMnevZ5kO2tzqcGinYNt0= X-Received: by 2002:a50:9549:0:b0:572:5630:d8d6 with SMTP id v9-20020a509549000000b005725630d8d6mr1182035eda.22.1714545636972; Tue, 30 Apr 2024 23:40:36 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=sunlin7.mail@gmail.com; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284233 Archived-At: --000000000000a4cb1f06175ec34b Content-Type: text/plain; charset="UTF-8" Hi, Since emacs-29 the Eshell has been enhanced for the ansi-color a lot. And the function `eshell-exec-visual` can support the executables with colors, eg VIM, tmux... I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ... and other executables in Eshell with "export TERM=eshell-color", they all work great. So we can safely export eshell's "TERM" with `eshell-term-name` to support executables with colors. I attached the patch, please help review it. Thanks. --000000000000a4cb1f06175ec34b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eshell-s-TERM-env-varible-use-eshell-term-name-as-de.patch" Content-Disposition: attachment; filename="0001-Eshell-s-TERM-env-varible-use-eshell-term-name-as-de.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvng71r30 RnJvbSA1YTQzNDMwZTg4ZTQxNGE3OTg5MjNkODgyZWZmN2MzYjdjYjg2YzFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBX ZWQsIDEgTWF5IDIwMjQgMDY6NTU6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBFc2hlbGwncyBU RVJNIGVudiB2YXJpYmxlIHVzZSBlc2hlbGwtdGVybS1uYW1lIGFzIGRlZmF1bHQKCiogbGlzcC9l c2hlbGwvZXNoLXZhci5lbCAoZXNoZWxsLXZhcmlhYmxlLWFsaWFzZXMtbGlzdCk6CiAgSW5pdGlh bGl6ZSB0aGUgVEVSTSBlbnZpcm9ubWVudCB2YXJpYWJsZSB3aXRoIGVzaGVsbC10ZXJtLW5hbWUu CiogZG9jL21pc2MvZXNoZWxsLnRleGk6IERvY3VtZW50IGZvciBURVJNIGVudmlyb25tZW50IHZh cmlhYmxlLgoqIGV0Yy9ORVdTOiBBZGQgZW50cnkgaW4gTkVXUyBmaWxlLgotLS0KIGRvYy9taXNj L2VzaGVsbC50ZXhpICAgfCA1ICsrKysrCiBldGMvTkVXUyAgICAgICAgICAgICAgIHwgNCArKysr CiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIHwgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy9lc2hlbGwudGV4aSBiL2RvYy9taXNjL2Vz aGVsbC50ZXhpCmluZGV4IDMwYzg1ZGE3OTUuLjA3NjExYzQ5ZWYgMTAwNjQ0Ci0tLSBhL2RvYy9t aXNjL2VzaGVsbC50ZXhpCisrKyBiL2RvYy9taXNjL2VzaGVsbC50ZXhpCkBAIC0xNDU2LDYgKzE0 NTYsMTEgQEAgVmFyaWFibGVzCiBAY29kZXtjb21pbnQtcGFnZXJ9IGlmIG5vbi1AY29kZXtuaWx9 OyBvdGhlcndpc2UsIGl0IHVzZXMgdGhlIHZhbHVlIG9mCiBAY29kZXskUEFHRVJ9IGZyb20gdGhl IEBjb2Rle3Byb2Nlc3MtZW52aXJvbm1lbnR9LgogCitAdmluZGV4ICRURVJNCitAaXRlbSAkVEVS TQorVGhpcyB2YXJpYWJsZSBpbmRpY2F0ZXMgdGhlIHRlcm1pbmFsIHR5cGUgb2YgdGhlIGVzaGVs bC4gIEl0cyBkZWZhdWx0Cit2YWx1ZSBpcyBAY29kZXtlc2hlbGwtdGVybS1uYW1lfS4KKwogQGVu ZCB0YWJsZQogCiBAeHJlZntBbGlhc2VzfSwgZm9yIHRoZSBidWlsdC1pbiB2YXJpYWJsZXMgQHNh bXB7JCp9LCBAc2FtcHskMX0sCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4 IDRiMDEwNmZjYjAuLjVlYmM1MTcyZjYgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9O RVdTCkBAIC04NjQsNiArODY0LDEwIEBAIGNvbW1hbmQgcGFzc2VkIGFzIGFyZ3VtZW50cyB0byAn ZW52Jy4gIElmIHlvdSBwYXNzIGFueSBpbml0aWFsCiBhcmd1bWVudHMgb2YgdGhlIGZvcm0gJ1ZB Uj1WQUxVRScsICdlbnYnIHdpbGwgZmlyc3Qgc2V0ICdWQVInIHRvCiAnVkFMVUUnIGJlZm9yZSBy dW5uaW5nIHRoZSBjb21tYW5kLgogCisrKysKKyoqKiBFc2hlbGwncyAnVEVSTScgZW52IHZhciB1 c2VzICdlc2hlbGwtdGVybS1uYW1lJyBhcyBkZWZhdWx0LgorVGhlIGVzaGVsbCdzICdURVJNJyBl bnZpcm9ubWVudCB2YXJpYWJsZSB1c2VzICdlc2hlbGwtdGVybS1uYW1lJyBhcyBkZWZhdWx0Lgor CiAtLS0KICoqKiBFc2hlbGwncyAndW1hc2snIGNvbW1hbmQgbm93IHN1cHBvcnRzIHNldHRpbmcg dGhlIG1hc2sgc3ltYm9saWNhbGx5LgogTm93LCB5b3UgY2FuIHBhc3MgYW4gYXJndW1lbnQgbGlr ZSAidSt3LG8tciIgdG8gRXNoZWxsJ3MgJ3VtYXNrJwpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwv ZXNoLXZhci5lbCBiL2xpc3AvZXNoZWxsL2VzaC12YXIuZWwKaW5kZXggMDJiNWM3ODU2Mi4uOGRk OGE4NGRhOCAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAorKysgYi9saXNwL2Vz aGVsbC9lc2gtdmFyLmVsCkBAIC0xNjEsNiArMTYxLDcgQEAgZXNoZWxsLXZhcmlhYmxlLWFsaWFz ZXMtbGlzdAogICBgKDs7IGZvciBlc2hlbGwuZWwKICAgICAoIkNPTFVNTlMiICwobGFtYmRhICgp ICh3aW5kb3ctYm9keS13aWR0aCBuaWwgJ3JlbWFwKSkgdCB0KQogICAgICgiTElORVMiICwobGFt YmRhICgpICh3aW5kb3ctYm9keS1oZWlnaHQgbmlsICdyZW1hcCkpIHQgdCkKKyAgICAoIlRFUk0i IGVzaGVsbC10ZXJtLW5hbWUgdCkKICAgICAoIklOU0lERV9FTUFDUyIgZXNoZWxsLWluc2lkZS1l bWFjcyB0KQogICAgICgiUEFHRVIiICgsKGxhbWJkYSAoKSAob3IgY29taW50LXBhZ2VyIChnZXRl bnYgIlBBR0VSIikpKQogICAgICAgICAgICAgICAuICwobGFtYmRhIChfIHZhbHVlKQotLSAKMi4y MC41Cgo= --000000000000a4cb1f06175ec34b--