bug#16936: 24.3; lexical-let does not take function arguments into account when creating closures

bug#16936: 24.3; lexical-let does not take function arguments into account when creating closures

[Jordon Biondo]

[-- Attachment #1: Type: text/plain, Size: 3940 bytes --]

;; here is code to test by, description in comments
(require 'cl)

;; lexical let is supposed to use fake lexical binding
;; to imitate closure behavior in CL
;; so, this in emacs lisp:
(apply (lexical-let ((x 3) (y 4))
    (lambda (x) (+ x y))) '(1)) ;; in EL returns 7

;; should behave like this in CL
(apply (let ((x 3) (y 4))
 (lambda (x) (+ x y))) '(1)) ;; in CL returns 5 (SBCL)

;; however in emacs lisp, the lambda arg x is forgetton and
;; the lexical-let bound x is used in the lambda, not the arg.

I assume this is not the desired behavior.


In GNU Emacs 24.3.1 (i386-mingw-nt6.2.9200)
 of 2013-03-17 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.2.9200
Configured using:
 `configure --with-gcc (4.7) --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
d SPC b a h a <backspace> <backspace> <backspace> e
h a v e SPC l i k e SPC t h i s SPC i n SPC C : <backspace>
l <backspace> L C-n C-n C-e <return> <return> ; ; SPC
h o w e v e r SPC i n SPC e m a c s SPC l i s p , SPC
t h e SPC l a m b d a SPC a r e <backspace> g SPC x
SPC i s SPC f o r g e t t o n SPC a n d <return> <tab>
; ; SPC t h e SPC l e x i c a l - l e t SPC b o u n
d SPC x SPC i s SPC u s e d SPC i n SPC t h e SPC l
a m b d a . C-p C-p C-e C-p C-e SPC ; ; SPC i n SPC
C L S-SPC r e t u r n s SPC 5 C-p C-p C-p C-p C-p C-n
C-e SPC ; ; SPC i n SPC E L SPC r e t u r n s SPC 7
C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-n C-p C-e <backspace> SPC n o t SPC t h e
SPC a r g . C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b
C-b C-b C-b , C-e M-x C-g C-p C-p C-p C-e SPC ( S B
C L ) C-n C-n C-n C-n C-e M-x e m a c s - b u <tab>
<tab> <backspace> <backspace> r e <tab> <tab> <tab>
<backspace> <backspace> <tab> <tab> <tab> C-a C-k r
e p o <tab> <tab> r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit
Entering debugger...
Back to top level.
Mark set [3 times]
Quit
Making completion list... [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils cl-macs gv cl cl-lib help-mode easymenu debug
time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32
ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process w32 multi-tty emacs)

[-- Attachment #2: Type: text/html, Size: 5433 bytes --]

bug#16936: 24.3; lexical-let does not take function arguments into account when creating closures

[Stefan Monnier]

> I assume this is not the desired behavior.

Indeed.  If you use `lexical-binding' instead of `lexical-let' you won't
suffer from those problems.

`lexical-let' is on the way to deprecation and the problem you describe
has affected `lexical-let' "for ever", so I don't think anyone will
care to fix it.


        Stefan