bug#36475: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el

[Nicholas Drozd <nicholasdrozd@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

I came across some `abbr` tags in the wild: check out the first
paragraph of http://mindprod.com/jgloss/unmainobfuscation.html. EWW
doesn't handle those, so here is a patch for that.

My understanding is that there is also an `acronym` tag which has been
deprecated in favor of `abbr`. I figured we might as well cover that
one too just in case.

I picked the `diary` face for abbreviations, but that choice didn't
have a lot of thought put into it. Whoever commits can choose
something else.

Let's try to get this merged <abbr title="as soon as possible">ASAP</abbr>.

[-- Attachment #2: 0001-Handle-abbr-and-acronym-tags-in-shr.el.patch --]
[-- Type: text/x-patch, Size: 1506 bytes --]

From a720473ad1001d3a72f9b3f3155f5488726cabde Mon Sep 17 00:00:00 2001
From: Nick Drozd <nicholasdrozd@gmail.com>
Date: Mon, 1 Jul 2019 23:46:10 -0500
Subject: [PATCH] Handle 'abbr' and 'acronym' tags in shr.el

* lisp/net/shr.el: Add 'abbr' and 'acronym' tag handling.
* etc/NEWS: Announce change in shr behavrior.
---
 etc/NEWS        |  3 +++
 lisp/net/shr.el | 15 +++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/etc/NEWS b/etc/NEWS
index abbece374a..464dae2454 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -989,6 +989,9 @@ This attribute is meant to tell screen readers to ignore a tag.
 ---
 *** The <code ...> tag is now handled.
 
+---
+*** The <abbr ...> and <acronym ...> tags are now handled.
+
 ** Htmlfontify
 
 *** The functions 'hfy-color', 'hfy-color-vals' and
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 7fdb3212d4..3af3db637a 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1470,6 +1470,21 @@ shr-tag-a
     (when url
       (shr-urlify (or shr-start start) (shr-expand-url url) title))))
 
+(defun shr-tag-abbr (dom)
+  (let ((title (dom-attr dom 'title))
+	(start (point)))
+    (shr-generic dom)
+    (shr-add-font start (point) 'diary)
+    (add-text-properties
+     start (point)
+     (list
+      'help-echo title
+      'mouse-face 'highlight))))
+
+(defun shr-tag-acronym (dom)
+  ;; `acronym' is deprecated in favor of `abbr'.
+  (shr-tag-abbr dom))
+
 (defun shr-tag-object (dom)
   (unless shr-inhibit-images
     (let ((start (point))
-- 
2.17.1