From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nicholas Drozd Newsgroups: gmane.emacs.bugs Subject: bug#43302: password shows up in shell buffer (27.1) Date: Fri, 12 Feb 2021 14:50:01 -0600 Message-ID: References: <87ft2maojs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43302@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 12 21:51:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAfPL-0002HQ-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Feb 2021 21:51:19 +0100 Original-Received: from localhost ([::1]:41806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAfPK-00006w-Ug for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Feb 2021 15:51:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAfP4-00006n-M5 for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 15:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAfP4-0001xJ-Dk for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 15:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAfP4-00057Z-C2 for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicholas Drozd Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Feb 2021 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43302 X-GNU-PR-Package: emacs Original-Received: via spool by 43302-submit@debbugs.gnu.org id=B43302.161316302319640 (code B ref 43302); Fri, 12 Feb 2021 20:51:02 +0000 Original-Received: (at 43302) by debbugs.gnu.org; 12 Feb 2021 20:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:33091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAfOR-00056h-HL for submit@debbugs.gnu.org; Fri, 12 Feb 2021 15:50:23 -0500 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:37660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAfOP-00056T-EO for 43302@debbugs.gnu.org; Fri, 12 Feb 2021 15:50:22 -0500 Original-Received: by mail-ed1-f43.google.com with SMTP id q2so1325784edi.4 for <43302@debbugs.gnu.org>; Fri, 12 Feb 2021 12:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zc6xKSwgR1xV2SQPP5Loa1n8ny9FXd20bM3thm242V4=; b=av0zIEdvmSgIhMeaYk/THVeGyuXMh1YRfmc0IN4M5w6tjhfTV8+fxsJJj1Gb9YaQbo d0jDcjFxE9nP5wMpLSeGTMe0Jinxaw0vjF7G/qP+HQfkh4HljQEGLz9edu9gVaMl/2Yt redvaepFtpmjy62ECb1j2Vr91xO2+5OaRXSg2xnxB/+21pVz/QwbKgFBq17oBrdjVz8/ BlZezRiSood3lJtbcfEKLTIvNYdl1hwSkRh5+w1A01misAI7zZEQR8UMFxgyUxJOe+eb f2v16qV0NI2fj3E1Sq0+Lcpl69mvQwSfJ5Hvs9yRpKEtGZwQtp37JBcgqWPJCmi3wkOw dbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zc6xKSwgR1xV2SQPP5Loa1n8ny9FXd20bM3thm242V4=; b=ZplLK7J0FSRr836jUtQE8x0rEloNLhNqAuqZqJCQIP786Fk0e47I7IYC5AdbW/u7Yd XJTGrNEtAwsoqNehPBvTqL07gV3KDSUwwNVVDCHG3p6Kq1dNDf4OSdV3NMChn+xsfaJU 68VE2SLixDOJ+qfVfGUi62wvglPbWeHNX9QAqr/TqgSK5XTqItjtQRoz7LHeTFHhM2e/ jOBReDCsmjD2UBX20Qv7HQZAT1KQCx45U0dOXBCZgvipoRDkuhjCruJoq3ODYS1R0fzu YnqSWwtBvy9wJdZ9v3jX1kE+AuNs7t0aMC0N0w5ukKXbI60et3AaVsgi+LLtjNhcx1Up HICw== X-Gm-Message-State: AOAM530FcICMIDOSiP7EGrmRT1NIkpnEyEDqYX4BzjNwbxamqO3GJROi uq8O9BlRXzPEarH8M4E0ZLqmRbwGMmWt3xnBmiI= X-Google-Smtp-Source: ABdhPJz/6jNB+fqe05fsGWzLy001hqaGlVobByc1K2h6JmhAidwMBgyN3N+53WOMaQuEdBtOdoTFSWKbSB/hjgegOM8= X-Received: by 2002:aa7:c64a:: with SMTP id z10mr5178703edr.61.1613163015401; Fri, 12 Feb 2021 12:50:15 -0800 (PST) In-Reply-To: <87ft2maojs.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199884 Archived-At: Your workaround works, but the fact remains that the behavior changed between 26 and 27, and it changed in a way that I as a user found disturbing. I switched to 27, and on my first session I ran a script that queried for a password. Previously Emacs had hid the password as I expected, but in 27 my password was unexpectedly exposed on the screen. It's a bug, and it should be fixed. (I would try to fix it myself, but I have no idea where to start. With a little guidance I could take a crack at it.) Alternatively, it could have been an intentional change in behavior. In that case it should be noted in NEWS. Something like: "shell-mode: Passwords are protected in fewer circumstances." But that sounds more like antinews than news. On Wed, Jan 27, 2021 at 12:20 AM Lars Ingebrigtsen wrote: > > Nicholas Drozd writes: > > > In 27, it looks like this: > > > > #+begin_src > > $ bash password.sh > > Password: > > asdf > > $ > > #+end_src > > > > The password (=asdf=) gets input directly into the shell buffer, unstarred. > > I'm able to reproduce the behaviour in Emacs 27 and 28. However, if you > say this: > > echo -n "Password:" > read -sr password > > Then Emacs will *** the password in the minibuffer, so comint only > triggers the password-reading behaviour if there's no newline there. > > Now, Emacs 26 did handle this... somewhat: > > > That is, it would include the newline in the prompt. > > So... I think basically this works as intended currently: comint only > triggers the password-reading behaviour if the prompt is on the current > line (i.e., without a newline), so I'm closing this bug report. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no