bug#36247: [PATCH] Handle 'code' tag in shr.el

bug#36247: [PATCH] Handle 'code' tag in shr.el

[Nicholas Drozd]

* lisp/net/shr.el: Add 'code' tag handling.

* etc/NEWS: Announce change in shr behavior.
---
 etc/NEWS        | 2 ++
 lisp/net/shr.el | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 723f0a0fb0..5b1191467a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -916,6 +916,8 @@ This attribute is meant to tell screen readers to
ignore a tag.
 ---
 *** 'shr-tag-ol' now respects the ordered list 'start' attribute.

+*** 'code' tag is now handled.
+
 ** Htmlfontify

 *** The functions 'hfy-color', 'hfy-color-vals' and
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index a014c56948..7fdb3212d4 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1401,10 +1401,14 @@ shr-tag-strong
 (defun shr-tag-u (dom)
   (shr-fontize-dom dom 'underline))

-(defun shr-tag-tt (dom)
+(defun shr-tag-code (dom)
   (let ((shr-current-font 'default))
     (shr-generic dom)))

+(defun shr-tag-tt (dom)
+  ;; The `tt' tag is deprecated in favor of `code'.
+  (shr-tag-code dom))
+
 (defun shr-tag-ins (cont)
   (let* ((start (point))
          (color "green")

bug#36247: [PATCH] Handle 'code' tag in shr.el

[Lars Ingebrigtsen]

Nicholas Drozd <nicholasdrozd@gmail.com> writes:

> * lisp/net/shr.el: Add 'code' tag handling.
>
> * etc/NEWS: Announce change in shr behavior.

Looks good, but the patch has been mangled by Gmail and doesn't apply.
Can you resend with the patch in an attachment?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#36247: [PATCH] Handle 'code' tag in shr.el

[Nicholas Drozd]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

Btw Lars, Eww is one of the "but can your editor do this" features I
use to show off Emacs to non-users.

On Sat, Jun 22, 2019 at 6:47 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Nicholas Drozd <nicholasdrozd@gmail.com> writes:
>
> > * lisp/net/shr.el: Add 'code' tag handling.
> >
> > * etc/NEWS: Announce change in shr behavior.
>
> Looks good, but the patch has been mangled by Gmail and doesn't apply.
> Can you resend with the patch in an attachment?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

[-- Attachment #2: 0001-Handle-code-tag-in-shr.el.patch --]
[-- Type: text/x-patch, Size: 1296 bytes --]

From 4895c9a646b3549a84685b22f08eb2aeb028a6a4 Mon Sep 17 00:00:00 2001
From: Nick Drozd <nicholasdrozd@gmail.com>
Date: Sun, 16 Jun 2019 09:41:43 -0500
Subject: [PATCH] Handle 'code' tag in shr.el

* lisp/net/shr.el: Add 'code' tag handling.

* etc/NEWS: Announce change in shr behavior.
---
 etc/NEWS        | 2 ++
 lisp/net/shr.el | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/etc/NEWS b/etc/NEWS
index 723f0a0fb0..5b1191467a 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -916,6 +916,8 @@ This attribute is meant to tell screen readers to ignore a tag.
 ---
 *** 'shr-tag-ol' now respects the ordered list 'start' attribute.
 
+*** 'code' tag is now handled.
+
 ** Htmlfontify
 
 *** The functions 'hfy-color', 'hfy-color-vals' and
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index a014c56948..7fdb3212d4 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1401,10 +1401,14 @@ shr-tag-strong
 (defun shr-tag-u (dom)
   (shr-fontize-dom dom 'underline))
 
-(defun shr-tag-tt (dom)
+(defun shr-tag-code (dom)
   (let ((shr-current-font 'default))
     (shr-generic dom)))
 
+(defun shr-tag-tt (dom)
+  ;; The `tt' tag is deprecated in favor of `code'.
+  (shr-tag-code dom))
+
 (defun shr-tag-ins (cont)
   (let* ((start (point))
          (color "green")
-- 
2.17.1

bug#36247: [PATCH] Handle 'code' tag in shr.el

[Lars Ingebrigtsen]

Nicholas Drozd <nicholasdrozd@gmail.com> writes:

> Btw Lars, Eww is one of the "but can your editor do this" features I
> use to show off Emacs to non-users.

:-)

Thanks for the patch; now applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no