From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Payas Relekar Newsgroups: gmane.emacs.devel Subject: Re: Progress on merging Eglot? Date: Mon, 19 Sep 2022 09:55:58 +0530 Message-ID: References: <8735d1ajxb.fsf@gmail.com> <874jxhaizf.fsf@gmail.com> <87zgf993py.fsf@gmail.com> <87fsgod4ee.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 19 13:37:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaF5v-000AVq-Ck for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 13:37:47 +0200 Original-Received: from localhost ([::1]:55768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaF5u-0004bN-4u for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Sep 2022 07:37:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oa8M7-0005AY-4U for emacs-devel@gnu.org; Mon, 19 Sep 2022 00:26:03 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:38470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oa8M5-0006KP-7c for emacs-devel@gnu.org; Mon, 19 Sep 2022 00:26:02 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id b5so45518993wrr.5 for ; Sun, 18 Sep 2022 21:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date; bh=xs6NNdbNcOqFj8jIOeedlxMxQ1oWfl0LCYE1x7TzNro=; b=lXIMDlNDLp/n+dq8eCWYI6OWKUe0Yne5d4vBLBwSpLuRmTuXjWkxVHd4NFnRmadfWn dkoFwbLiMs3wUYEs2z4dyMXVoZN7IlOJsiQ2l/RSDq6HyViVbX7U1N5JTR+PCtln04at wnbVa40u5dddV0+uMBw0vF608vig2zJLMYeM5VbpvMt5RQTBC7H25Au3QM4bVQpzBJt2 4tWceEM894HT/1diXyoVdXUqfYLKnAup5MkeE3DHztUWeejGLNjeJYV2HVd6ecVZQyRi eZ63xuv9sY8BCYesx7NjC1epFE0h+1qor5/sKl0We+tsrHdfzbX0X7D6ebpOIu7JiqrX eKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=xs6NNdbNcOqFj8jIOeedlxMxQ1oWfl0LCYE1x7TzNro=; b=Y8yPGFCa3MT37uGaM8uJwfASXB1BM2VCk7TPwi/gg/K9/D1vtjzyaTl5nJk+LYpxpK m74BifIN3elD3Ob5y1lSLBk6tjQ2yo/Urjb6KpDx72QScMbB+B5ZmaW4cwHDQHO02wAg b9fGcC58RlWY8/PqkxRBPFDdnOlIldbI3jV7wvoWNpFOWZEsD48kBtdzKBmXogbxxkkR XbX0OUFeWjA+0b1ZwWqs37PnkUsfc2QZP8ibUyB++/mLtZ2ANlwZ/hsr8wcUYeF4kvWN EUwBsqsmi5bsf0IrEsSGY8FsqMr7kjFHnsiL4xMJBOih0sOJ99NA1bgRDF8G6iqTWT5v 06zg== X-Gm-Message-State: ACrzQf2HyQGvSlxt81baqNW/+nZ0X4pqrBhqeGHQK/fM6a/LJBXi5Ic+ XK4WZCDm/7NumKIhLm5nOXnrw8QsCJ8Y41tF4RQ= X-Google-Smtp-Source: AMsMyM6uljHTcYsudclZp9wBf7lXxt4lIcNorGMZTrYW8Yal/7B36e3iTkErzl1U9BMu2HYSuoX6RNLjo6+ppgc+3/E= X-Received: by 2002:a5d:4b84:0:b0:228:7e07:115e with SMTP id b4-20020a5d4b84000000b002287e07115emr9415402wrt.168.1663561559138; Sun, 18 Sep 2022 21:25:59 -0700 (PDT) Original-Received: by 2002:a05:6000:2cb:0:0:0:0 with HTTP; Sun, 18 Sep 2022 21:25:58 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=relekarpayas@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 19 Sep 2022 07:30:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295666 Archived-At: Thank you! Indeed moving to subdirectory makes history apply to correct file and shows up as expected. Was also quite straightforward with git-filter-repo, so here's the updates: Updates gist: https://gist.github.com/bhankas/422c34db2e987d4dc3f243e26ba156a3 Updated repo: https://github.com/bhankas/emacs Updated history: https://github.com/bhankas/emacs/commits/master/lisp/progmodes/eglot.el Now the only remaining issue is commit length. Can someone please advice on how we can go about it? My brute force thinking is to simply add newline where length exceeds, delimited at word boundary, but obviously that's not good enough nor covers sufficient edge cases. Perhaps a Python/Perl wizard has a one/two liner to take that pain away? Thanks, Payas On Mon, 19 Sep, 2022, 08:08 Stefan Monnier, wrot= e: > > > # filter eglot with only eglot.el and find+replace # in commit messages > > git filter-repo --path eglot.el --message-callback ' > >=C2=A0 =C2=A0 =C2=A0 =C2=A0return re.sub(b" #", b" https://github.com/jo= aotavora/eglot/issues/", message) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0return re.sub(b",#", b",https://github.com/jo= aotavora/eglot/issues/", message) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0return re.sub(b"(#", b"(https://github.com/jo= aotavora/eglot/issues/", message) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0return re.sub(b"Fix#", b"Fix: https://github.= com/joaotavora/eglot/issues/", message) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0return re.sub(b"github#", b"Github: https://g= ithub.com/joaotavora/eglot/issues/", message) > > I suspect you can get a slightly better result if you tweak this filter > script so as to rename `eglot.el` to `lisp/progmodes/eglot.el` in each co= mmit. > > Then you can also skip the `git read-tree`. > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan >