* Re: [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend
[not found] ` <20240603195922.72477C1F9E7@vcs2.savannah.gnu.org>
@ 2024-06-03 20:34 ` Stefan Monnier
2024-06-06 7:47 ` Vladimir Kazanov via Emacs development discussions.
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2024-06-03 20:34 UTC (permalink / raw)
To: Vladimir Kazanov; +Cc: Daniele Nicolodi, emacs-devel
> + ;; Pre Emacs-28.1, defclass was used for
> + ;; xref-buffer-location.
> + (pos (if (version< emacs-version "28.1")
> + (oref loc position)
> + (xref-buffer-location-position loc))))
A significantly faster test is (< emacs-major-version 28)
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend
2024-06-03 20:34 ` [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend Stefan Monnier
@ 2024-06-06 7:47 ` Vladimir Kazanov via Emacs development discussions.
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Kazanov via Emacs development discussions. @ 2024-06-06 7:47 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Daniele Nicolodi, emacs-devel
Thanks Stefan!
I'll add a pull request on Github
On Mon, 3 Jun 2024 at 21:34, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > + ;; Pre Emacs-28.1, defclass was used for
> > + ;; xref-buffer-location.
> > + (pos (if (version< emacs-version "28.1")
> > + (oref loc position)
> > + (xref-buffer-location-position loc))))
>
> A significantly faster test is (< emacs-major-version 28)
>
>
> Stefan
>
--
Regards,
Vladimir Kazanov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-06 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171744476130.7473.9271118063901097030@vcs2.savannah.gnu.org>
[not found] ` <20240603195922.72477C1F9E7@vcs2.savannah.gnu.org>
2024-06-03 20:34 ` [nongnu] elpa/beancount bdd71c570d 3/3: Implement xref backend Stefan Monnier
2024-06-06 7:47 ` Vladimir Kazanov via Emacs development discussions.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.