Re: [ELPA] New package: ert-font-lock

[Vladimir Kazanov <vekazanov@gmail.com>]

On Tue, 21 Nov 2023 at 17:05, john muhl <jm@pub.pink> wrote:

>
> https://git.sv.gnu.org/cgit/emacs.git/tree/lisp/progmodes/lua-ts-mode.el
>
> Attached are the tests. They fail against master since some bugs
> were found in the process.
>

Got it, thanks!

Your code uses newcomment.el facilities so ert-font-lock.el's comment
detection code should work just fine. Based on your example I've just
added a way to check comment faces as well, i.e. something like the
following should work now :

// comment
// ^ font-lock-comment-face

or
// comment
    // <- font-lock-comment-face

This means that single line comments having no (leading "^", or "<-")
should be properly testable now as well. Previously this wouldn't work
as the code assumed all comments to be either assertions, or
non-meaningful lines.

Got to look into the multiline comment case now - you have one early
in the patch.

-- 
Regards,

Vladimir Kazanov