From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Accept plists when serializing and parsing JSON Date: Sat, 2 Jun 2018 09:39:16 +0200 Message-ID: References: <87sh6awls5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e9a720056da3cc0d" X-Trace: blaine.gmane.org 1527925084 6381 195.159.176.226 (2 Jun 2018 07:38:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 07:38:04 +0000 (UTC) Cc: emacs-devel To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 02 09:38:00 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP16u-0001ZB-3q for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 09:38:00 +0200 Original-Received: from localhost ([::1]:58614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP18z-0006O4-EF for ged-emacs-devel@m.gmane.org; Sat, 02 Jun 2018 03:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP18M-0006Ng-RH for emacs-devel@gnu.org; Sat, 02 Jun 2018 03:39:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP18L-0007FS-Ri for emacs-devel@gnu.org; Sat, 02 Jun 2018 03:39:30 -0400 Original-Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]:36052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP18L-0007Dp-Jo for emacs-devel@gnu.org; Sat, 02 Jun 2018 03:39:29 -0400 Original-Received: by mail-oi0-x243.google.com with SMTP id 14-v6so16375217oie.3 for ; Sat, 02 Jun 2018 00:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ixH9NnZR2I+EanZoj6mpDH6kLDlue6LlyGyOs6dLTY4=; b=B7amMq+KptYIQAK2Biy+yXUXoLqof2OT7XOyPijGndRxZMkC6pQWK62JMoYE2Dx6p9 IISky5YXaSZ2eNLhbXfD442Fe8qtNQ5g4hzvxMGnWmADOUPi5B7xfEtg+3wPbINHkDIj YQ6YHGMgMv2qS51GujNePwjP8HKO//dtv1H86R/xJ4AephCcBRRyzWbSngCP9tcpaHb3 sYQdgyY2M5qzUTpIt21gPnqjGiam3PtKjnvtb9W+oiCWXZJ74+v86eK84aYi3OyXw3Wg xA+dk+QJ56qKkdwAIkWRV5WgbahPXWbM9Qo3RDArgHVxoSvh/Eo5PPUMwDdKubUmlG0+ 9abw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ixH9NnZR2I+EanZoj6mpDH6kLDlue6LlyGyOs6dLTY4=; b=R6tMAm+RvMWwV3pJP9UIKhNqqGVkFLA4ZvYqNTyFHgPg3wsSgb920yyXU/mZMmN7he 95THcppG5lQFt2gvnYOV+WJ+VptEbBc37Zqgc46+Aj/QFmiJ/+pR9xvAZqo20TdiPpFn XFQ7q6x4+HWgPtvpwiFrJpydBfR+ZwZo2eTG6dUu7rYvvA0h6vDQNcIrf8fxV1NazzHP AJ3KEKrPWMKenniQGIprXqif4V8dZX/G4bAAA7ker5UuAZEy93BflAsD2A2ivkmeNSyE JI8BM1Jfdd7BDWJylz7bLiXK4GjpbSjsTN4/AXtedf0DrPboaQ/lgLfDP2qznN6yOupE cZYA== X-Gm-Message-State: APt69E2Bdk5yGbGMgEr4m6wTRX4QsT7GAARnwYByStdVaqicNSQBDUrm 25GjaezukQK5O+7R7ajrNu3cEn7BRccS/ZeEl+A= X-Google-Smtp-Source: ADUXVKL9O5In35ZRbGBGgQ9pYymd3DA0jecGr8+y2foTc3Yf9jE+RvNYxuSDYAWFRoMKT8bCJHMLxfZScRpFlrLd5hY= X-Received: by 2002:aca:d906:: with SMTP id q6-v6mr7473377oig.349.1527925168512; Sat, 02 Jun 2018 00:39:28 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225912 Archived-At: --000000000000e9a720056da3cc0d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jo=C3=A3o T=C3=A1vora schrieb am Mi., 30. Mai 2018 u= m 00:31 Uhr: > On Tue, May 29, 2018, 22:21 Philipp Stephani > wrote: > >> >> >> Jo=C3=A3o T=C3=A1vora schrieb am Di., 29. Mai 201= 8 um >> 16:59 Uhr: >> >>> >>> I used a global to control json-serialize's interpretation of lists, bu= t >>> it could be an argument as well. >> >> >> Please don't add global state to json.c. It's a low-level library that >> shouldn't rely on global state (and global state should generally be >> avoided in libraries). Not having global state was one of my explicit >> design goals for json.c >> > > Well, it's not really "global state" in the sense I believe you're talkin= g > about, because no part of the library is maintaining any state in global > variables -- it's read-only from json.c. > Every defvar, defcustom, defconst is global mutable state. > > That said, if that's your only objection, consider that duck removed :) > > It's not my only objection, I just didn't have time yet to review the rest of the code, sorry. --000000000000e9a720056da3cc0d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Jo=C3= =A3o T=C3=A1vora <joaotavora@gma= il.com> schrieb am Mi., 30. Mai 2018 um 00:31=C2=A0Uhr:
=
On Tue, May 29, 2018, 22:21 Phi= lipp Stephani <p.stephani2@gmail.com> wrote:


Jo= =C3=A3o T=C3=A1vora <joaotavora@gmail.com> schrieb am Di., 29. = Mai 2018 um 16:59=C2=A0Uhr:

I used a global to control json-serialize's interpretation of lists, bu= t
it could be an argument as well.

Please don= 't add global state to json.c. It's a low-level library that should= n't rely on global state (and global state should generally be avoided = in libraries). Not having global state was one of my explicit design goals = for json.c=C2=A0

Well, it's not re= ally "global state" in the sense I believe you're talking abo= ut, because no part of the library is maintaining any state in global varia= bles -- it's read-only from json.c.=C2=A0
=
Every defvar, defcustom, defconst is global mutable state.
=C2=A0

That said, if that's your only= objection, consider that duck removed :)


It's not= my only objection, I just didn't have time yet to review the rest of t= he code, sorry.=C2=A0
--000000000000e9a720056da3cc0d--