From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 18 Dec 2017 19:55:52 +0000
> Cc: raman@google= .com, emacs-de= vel@gnu.org
>
>=C2=A0 =C2=A0 @defun json-parse-string string &key (object-type @co= de{hash-table})
>
>=C2=A0 ?
>
> If that's the right thing, sure. OTOH, cl.texi uses
> @defun cl-fill seq item @t{&key :start :end}
> so probably we should use that?
No, @t is almost never right, certainly not in code sequences.At least cl.texi uses it consistently, though.=C2=A0
>=C2=A0 >=C2=A0 >=C2=A0 > +The keyword argument OBJECT-TYPE spe= cifies which Lisp type is used to
>=C2=A0 >=C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^^^^^^^^^^^
>=C2=A0 >=C2=A0 >=C2=A0 Shouldn't that be `:object-type' (= including quotes)?
>=C2=A0 >=C2=A0 >
>=C2=A0 >=C2=A0 > Depending on whether we can use &key in a do= cstring in core. If so, then this one is correct, see
>=C2=A0 e.g.
>=C2=A0 >=C2=A0 the
>=C2=A0 >=C2=A0 > docstring of should-error.
>=C2=A0 >
>=C2=A0 >=C2=A0 IMO, the doc string of should-error is no less confus= ing than this
>=C2=A0 >=C2=A0 one, because it expects something like ":type = 39;foo".
>=C2=A0 >
>=C2=A0 > Arguably yes. Though that has been the convention for cl-li= b functions for a while.
>
>=C2=A0 cl-lib enjoyed being in the shadows for too long.=C2=A0 I don= 9;t think we
>=C2=A0 should let that continue any longer, we should fix that.
>
> OK, what's your suggestion?
I thought I wrote that above.I've = attached a new version of the patch.=C2=A0