From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani
Le 17/06/2017 =C3=A0 00:09, Vincent Bela=C3=AFche a =C3=A9crit :
>
> Le 16/06/2017 =C3=A0 21:37, Vincent Bela=C3=AFche a =C3=A9crit :
>>
>> Le 16/06/2017 =C3=A0 21:15, Vincent Bela=C3=AFche a =C3=A9crit : > [...]
>
>>>
>> After some more investigation, I think that the bug is in function=
>> insert-file-contents of fileio.c which is the one that decide and = sets
>> the coding system well before the other local variables are looked= into.
> I have located the bug.
>
> After some more investigation, in the end the find-auto-coding of
> mule.el is what is called to detect the coding.
>
> This function evaluates this expression to find the local variables: >
>=C2=A0 =C2=A0(re-search-forward
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "[\r\n]\\([^[\r\n= ]*\\)[ \t]*Local Variables:[ \t]*\\([^\r\n]*\\)[\r\n]"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tail-end t)
>
> This expression evaluates to nil over file CONTRIBUTING.md
>
> I can make a simple fix if you tell me on which branch to do it.
>
> However I think that the root of the problem is poor code factorizatio= n
> of local variable parsing between mule.el and file.el. A better, more<= br> > futureproof fix would be some unique local variable parser with some > input constrain telling what sort of setting are sought. The output of=
> the parse could be used in file.el and mule.el.
>
>=C2=A0 =C2=A0 Vincent.
>
>
Ooops... my lengthy email of T23:34 was unwantedly sent. A shorter
version with only the conclusion and w/o all the details of my
investigation is above.
Anyway, Philipp's patch is what I had in mind as a quick fix.OK, I've pushed this commit as c3813b2aa8d2f5a6= 25195fdbbfe6a01a602d7735.=C2=A0Although I
don't think that this is a good solution not to factorize code when
possible. Factorizing makes it more maintainable.
Agreed. Note that there's a third plac= e in Emacs that parses a subset of file-local variables: lread.c, to detect= the lexical-binding variable when loading ELisp files. Ideally that would = be merged as well.=C2=A0