From: Philipp Stephani <p.stephani2@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 纪秀峰 <jixiuf@qq.com>, emacs-devel@gnu.org
Subject: Re: make pred customable in auto-save-visited-mode
Date: Sat, 31 Mar 2018 10:23:13 +0000 [thread overview]
Message-ID: <CAArVCkTmCuEumgqg3fR-r_Xsu8sWtFK89g489SYWV+JGMbV-qQ@mail.gmail.com> (raw)
In-Reply-To: <83a7uo8wk5.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]
Eli Zaretskii <eliz@gnu.org> schrieb am Sa., 31. März 2018 um 10:44 Uhr:
> > From: 纪秀峰 <jixiuf@qq.com>
> > Date: Sat, 31 Mar 2018 00:59:19 +0800
> > Feedback-ID: esmtp:qq.com:bgforeign:bgforeign1
> >
> > When I enable auto-save-visited-mode and start an ediff merge session
> > It always prompt me save "*ediff-merge*” to a file.
>
> Why is that a problem? *ediff-merge* is a buffer where you prepare
> the merge, and that merge will eventually be saved to some file,
> right? So it doesn't sound wrong to offer to save it.
>
However, auto-saving should probably not prompt for filenames. That's at
least the intention of the :noprompt argument here.
>
> > (setq auto-save--timer
> > (when auto-save-visited-mode
> > (run-with-idle-timer
> > auto-save-visited-interval :repeat
> > #'save-some-buffers :no-prompt
> > (lambda () ;;<————————————how about make this customable
> > (not (and buffer-auto-save-file-name
> > auto-save-visited-file-name)))))))
>
> Letting users customize a non-trivial function is not the best way of
> affecting this behavior. I think you can have what you want by adding
> a function to ediff-startup-hook, and in that function set
> buffer-auto-save-file-name of the *ediff-merge* buffer to nil.
>
>
I agree that customization isn't the best solution here. However, I'm
suprised that `save-some-buffers' still prompts even if :noprompt is passed.
The issue might be in `save-some-buffers': Its docstring says "If PRED is
t, then certain non-file buffers will also be considered.", but later it
only checks whether PRED is non-nil:
(or
(buffer-file-name buffer)
(with-current-buffer buffer
(or (eq buffer-offer-save 'always)
(and pred buffer-offer-save (> (buffer-size)
0)))))
Maybe instead of `pred' here we should say (eq pred t). Alternative, the
predicate lambda should check whether `buffer-file-name' is non-nil.
[-- Attachment #2: Type: text/html, Size: 2963 bytes --]
next prev parent reply other threads:[~2018-03-31 10:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 16:59 make pred customable in auto-save-visited-mode 纪秀峰
2018-03-31 8:43 ` Eli Zaretskii
2018-03-31 10:23 ` Philipp Stephani [this message]
2018-03-31 10:28 ` Philipp Stephani
2018-03-31 10:45 ` Eli Zaretskii
2018-04-01 17:19 ` Philipp Stephani
2018-04-01 17:35 ` Eli Zaretskii
2018-04-01 19:51 ` Philipp Stephani
2018-04-02 4:44 ` Eli Zaretskii
2018-04-02 10:20 ` Philipp Stephani
2018-03-31 10:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkTmCuEumgqg3fR-r_Xsu8sWtFK89g489SYWV+JGMbV-qQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jixiuf@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.