From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Date: Sat, 17 Dec 2016 21:11:30 +0000 Message-ID: References: <20161212202151.21054.37035@vcs.savannah.gnu.org> <20161212202152.428192201BB@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bb040500eaa4f0543e12218 X-Trace: blaine.gmane.org 1482009154 7227 195.159.176.226 (17 Dec 2016 21:12:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 17 Dec 2016 21:12:34 +0000 (UTC) Cc: Glenn Morris To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 17 22:12:30 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIMHK-0000Ge-HP for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 22:12:26 +0100 Original-Received: from localhost ([::1]:38325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIMHO-0007gc-S8 for ged-emacs-devel@m.gmane.org; Sat, 17 Dec 2016 16:12:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIMGf-0007QG-Bg for emacs-devel@gnu.org; Sat, 17 Dec 2016 16:11:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIMGe-0005et-EI for emacs-devel@gnu.org; Sat, 17 Dec 2016 16:11:45 -0500 Original-Received: from mail-wj0-x234.google.com ([2a00:1450:400c:c01::234]:33545) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cIMGe-0005eN-7j; Sat, 17 Dec 2016 16:11:44 -0500 Original-Received: by mail-wj0-x234.google.com with SMTP id xy5so118502301wjc.0; Sat, 17 Dec 2016 13:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gB9nIsbaIn5Lcukqq7FPmv0LynD5qc9xY8X3wRjf1F4=; b=PNFr7oU9GNhG2QOuLrzJpUbGpW+nCGvjut65mvUXBRM+Faw2NL2SHtUIL5z/dbpOCH CMUq4NODnkBUqZqGaX++ihL6Vne3Ln9i2USh31iVzGK1QBAhO7WF8TIRi65A16ScPNOx rZcKxtaQfbqTbtXy60Q/mV6BZaNqkkK1Ktt3b4/Y9fCx3AEnpztHIetll6xIQl+JFgnF Di9iuu4qlXTSnZJvkh2U+/5xdKfsMfqiS6l4lx48zo2qn7jlPd7nKjABhwl/QdOxRNVJ BfToa/jCmWqW+ZpIJU5UBekrZCIJV9CfP0oL5i/riqCtxmDXiQskpfUFNUnjLsSGyCfp XOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gB9nIsbaIn5Lcukqq7FPmv0LynD5qc9xY8X3wRjf1F4=; b=eTVQZP/m0YVVDbytfy4rVsxY5kSvgQ0VhmJxpPGqsXhPH6RNjDCv5Umf4NAyiwPFZr JpQbio+Kh0ZWNw2tE0E+7rlt25H1uVHIK0gAK+cCVnd+1U9PZbEQM1McD5WLo+7qd6CL YgCb25hFs0rJ4/va5fXh+l/e9OFHqb3c1B4u6rdlk+GIcD1fBk1HUeJIHCIotKz7VOL4 e8pO6dTjF0epVc+AlDh94JUa4TjUWVIkO0wPvxr+VP9/UKM6i6Nnlqeg1mZcHZKLtB6Z duQsA3ovwgZdnGlNOG66PnyLsij905u+UmAB35ppd77G+568nM4499aXbKilNf5aH2fL pfcA== X-Gm-Message-State: AKaTC00ar2s8Rb9jl9mjD53p3JT4llwzUa1PhON6/U7G0XkvjPUHI4PMGCWFoTjQk4NVcSJots5rZbXs5UDyCA== X-Received: by 10.194.95.35 with SMTP id dh3mr8647762wjb.141.1482009101640; Sat, 17 Dec 2016 13:11:41 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c01::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210592 Archived-At: --047d7bb040500eaa4f0543e12218 Content-Type: text/plain; charset=UTF-8 Stefan Monnier schrieb am Di., 13. Dez. 2016 um 14:41 Uhr: > > * lisp/emacs-lisp/advice.el (ad-preactivate-advice): > > Avoid setting the function definition of nil. > > This was happening during bootstrap of org-compat.el, > > apparently due to eager macro expansion of code behind > > a (featurep 'xemacs) test. > > Really, I think this business of "disallow fset of nil" is a big waste > of time and will just lead to more pain than gain. > > There are umpteen different ways for the user to shoot himself in the > foot. This one is not even fatal. > > Should we also disallow (fset 'car nil)? How 'bout (fset 'car #'cdr)? > > Yes, fset for most primitives should be forbidden. --047d7bb040500eaa4f0543e12218 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Stefan= Monnier <monnier@iro.umontr= eal.ca> schrieb am Di., 13. Dez. 2016 um 14:41=C2=A0Uhr:
>=C2=A0 =C2=A0 =C2=A0* lisp/emacs-lisp/advi= ce.el (ad-preactivate-advice):
>=C2=A0 =C2=A0 =C2=A0Avoid setting the function definition of nil.
>=C2=A0 =C2=A0 =C2=A0This was happening during bootstrap of org-compat.e= l,
>=C2=A0 =C2=A0 =C2=A0apparently due to eager macro expansion of code beh= ind
>=C2=A0 =C2=A0 =C2=A0a (featurep 'xemacs) test.

Really, I think this business of "disallow fset of nil" is a big = waste
of time and will just lead to more pain than gain.

There are umpteen different ways for the user to shoot himself in the
foot.=C2=A0 This one is not even fatal.

Should we also disallow (fset 'car nil)?=C2=A0 How 'bout (fset '= ;car #'cdr)?


Yes, fset for most primitives should be fo= rbidden.=C2=A0
--047d7bb040500eaa4f0543e12218--