all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philipp Stephani <p.stephani2@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Cc: Glenn Morris <rgm@gnu.org>
Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix
Date: Sat, 17 Dec 2016 21:11:30 +0000	[thread overview]
Message-ID: <CAArVCkTm419CwEawDtcW=FN6Pjbzfq95tNVzbrVjSObFd0gs9g@mail.gmail.com> (raw)
In-Reply-To: <jwvfulsosoq.fsf-monnier+emacsdiffs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> schrieb am Di., 13. Dez. 2016 um
14:41 Uhr:

> >     * lisp/emacs-lisp/advice.el (ad-preactivate-advice):
> >     Avoid setting the function definition of nil.
> >     This was happening during bootstrap of org-compat.el,
> >     apparently due to eager macro expansion of code behind
> >     a (featurep 'xemacs) test.
>
> Really, I think this business of "disallow fset of nil" is a big waste
> of time and will just lead to more pain than gain.
>
> There are umpteen different ways for the user to shoot himself in the
> foot.  This one is not even fatal.
>
> Should we also disallow (fset 'car nil)?  How 'bout (fset 'car #'cdr)?
>
>
Yes, fset for most primitives should be forbidden.

[-- Attachment #2: Type: text/html, Size: 1369 bytes --]

  parent reply	other threads:[~2016-12-17 21:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161212202151.21054.37035@vcs.savannah.gnu.org>
     [not found] ` <20161212202152.428192201BB@vcs.savannah.gnu.org>
2016-12-13 13:40   ` [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Stefan Monnier
2016-12-14 16:49     ` Glenn Morris
2016-12-14 18:15       ` Stefan Monnier
2016-12-17 21:11     ` Philipp Stephani [this message]
2016-12-17 22:08       ` Stefan Monnier
2016-12-18 19:43         ` Philipp Stephani
2016-12-18 20:15           ` Stefan Monnier
2016-12-23 12:20             ` Philipp Stephani
2016-12-24  1:21               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAArVCkTm419CwEawDtcW=FN6Pjbzfq95tNVzbrVjSObFd0gs9g@mail.gmail.com' \
    --to=p.stephani2@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.