From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Two fixes for module bug when interleaving threads Date: Fri, 27 Nov 2020 21:57:41 +0100 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34293"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 27 21:58:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kikpB-0008pF-92 for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Nov 2020 21:58:37 +0100 Original-Received: from localhost ([::1]:55226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kikpA-00089I-Ba for ged-emacs-devel@m.gmane-mx.org; Fri, 27 Nov 2020 15:58:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kikoW-0007XO-0l for emacs-devel@gnu.org; Fri, 27 Nov 2020 15:57:56 -0500 Original-Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:40455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kikoU-0006MH-IT for emacs-devel@gnu.org; Fri, 27 Nov 2020 15:57:55 -0500 Original-Received: by mail-oi1-x22b.google.com with SMTP id a130so7166398oif.7 for ; Fri, 27 Nov 2020 12:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=zD7vDMGFw52hS4lq9VB+zbijWpUo5pYQ5WiJ/CRNM3I=; b=vZle6BUGmGAVNJhM9Jza+o2Vk9+cFHCChuOt+8QglTSvu4HU3MvYDQtVFB4Cpy8OYK deawDG2lNq3+MrDLKKGCCCL7/7KHfqXHaeAypGi9nH5pjfHHRTRY1dzCCStQOTSRHCvA 9dPkIDeskcwK0UrG73oGeW4i8OE0Z0dyWA/i/rF0N5u3pGe1nKKBeSaRqq2CINuQOApy 5vhI15T372BXo2eDEZ+Obf6bQbwSKdZn89TbMwdbBY5GRQHJ2EbnuQRQBwZaWQHNbkUE jInEVrr+mRGkIvqUo4eO+1nwZAvv/hElVsQM1hyOgWIFywK3NtFNFOzbWaY6bGImOdwP pyIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=zD7vDMGFw52hS4lq9VB+zbijWpUo5pYQ5WiJ/CRNM3I=; b=UvS3XZI2U56sxdem4GqFXCRLxlHUz93TxYuqpDqcvbkoGnDsBnl7favzN40BlQYJ7Z tMzqWgodnM17brm4b12KAArl4ncHs5XFhtNAtVafqq8xxrQaBhHW90cB7jpiZTb+OYXL Lp6gjFDynfwFG0wkFrbV3pkc3KqgQlZZT6Mzssbj9sHBtanS6RPUsDCE4UH3lGEehMXO pjZSI3gm5pv4Mzc8YwUDVPBUkAQPBks2wXk9ySiprUD8B3XmeZdBv66CvZlINF4ouJKr tLWwBqmiMpW7NhCHODOTc4YcZVczwf3aETyqAiSpWPhjx/nXKEZGJTo8GLtJsumiTJnu Ehpw== X-Gm-Message-State: AOAM532X0/Hx1RjQqFCQjV/CLiuGuRO86CdaLbTcGq/mEepEr9yqEXlI /0ox8EphdfCcO1HEGNT3u2qqSbG06dUWkuBaplco4mjDLPk= X-Google-Smtp-Source: ABdhPJxWZrSsOgvQQf4slaUIBghQF0aKJSsJ6ABPCJaoPc/N7WyPRitlzmJx46MtTczyHC3fdArsFOWa8D4E9oDsJ1I= X-Received: by 2002:a05:6808:3af:: with SMTP id n15mr6752727oie.65.1606510673004; Fri, 27 Nov 2020 12:57:53 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::22b; envelope-from=p.stephani2@gmail.com; helo=mail-oi1-x22b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259925 Archived-At: Hi, I just pushed two fixes for the same bug that appears when interleaving module calls in separate threads: cdc632fbe6e149318147a98cccf1b7af191f2ce8 for the release branch and 23974cfa48b9245658667eff81d132b3aecd2618 for master. The intention was that a simpler and more localized fix should go to the release branch, the "proper" fix to master. Now I've realized that arguably the simpler fix is overall better: it's more localized, touches fewer moving pieces, and is probably not significantly slower (though I haven't benchmarked it). Any opinions? If people agree, we can overwrite the fix on master with the fix on the release branch. Thanks, Philipp