From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Clean up a couple of compiler warnings Date: Tue, 23 May 2017 19:21:00 +0000 Message-ID: References: <20170518202450.75747-1-phst@google.com> <7631cb49-7940-7758-9ec3-5530e0ab542e@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113c381cee4096055035e3e7" X-Trace: blaine.gmane.org 1495567282 15280 195.159.176.226 (23 May 2017 19:21:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 May 2017 19:21:22 +0000 (UTC) To: Paul Eggert , Philipp Stephani , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 23 21:21:18 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDFMr-0003qx-Ec for ged-emacs-devel@m.gmane.org; Tue, 23 May 2017 21:21:17 +0200 Original-Received: from localhost ([::1]:51296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDFMx-0000k1-2z for ged-emacs-devel@m.gmane.org; Tue, 23 May 2017 15:21:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDFMn-0000ja-2L for emacs-devel@gnu.org; Tue, 23 May 2017 15:21:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDFMm-0001y1-2n for emacs-devel@gnu.org; Tue, 23 May 2017 15:21:13 -0400 Original-Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:35650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDFMl-0001xr-Tn for emacs-devel@gnu.org; Tue, 23 May 2017 15:21:12 -0400 Original-Received: by mail-oi0-x22b.google.com with SMTP id l18so214547651oig.2 for ; Tue, 23 May 2017 12:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=F5K1DZt/6qaH8M5zW3i4BoQUHpknxCUtCTTixP+wwgU=; b=rIMu1baqIjmoJEBL/nP5XY/sW+5ss88PLvyYOTUesLMfjoteVuzYGTqb0l/hV+7Uz2 Lt/i6Z+joDYmxBfzFyGkNBqiurTDHSCOqJxQtpOhveRuxn90c3oC0KNc7/Kmd1dhwRMO MbBv080knQisRDwqcwtOUoXktdT2lx0hoCv7ns7TJ5gYY7/LSNlFSeNyxQ07gLXnm4yR FNK+17KbmX1DD4Za5Z6k3Kyjs3HkNKyMz1wzFYfTUSc4JI5suAx1eRM61ZeV7O4lGD2C IwsHlOg8dWb2pNh2Zaswq9JpK1LyGbEZzKpxhRprkSCr/0focAViUQ9JpR9QnZ4c7YGE 2WKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=F5K1DZt/6qaH8M5zW3i4BoQUHpknxCUtCTTixP+wwgU=; b=S5xRuUuZLNr5OjdRhbApWnPTjccoBMjmUTXenqZMLzi5gxgyo9wys8y8rKwCdYn2t+ HL+F5MJs0xkmlBrGOEffVQ8YkymUsmOJTHqIq0UkelqbvoUP9pVwJclH1zY2Gi2lxx4M QHnSOGkOZS6EtbqF/DgEOnEr5VjzNXAbCPcovTDgh4sh2EtGfzSnwQP2JZVcNgOZXu+v UoPiqk1CZ7cPWiCKZSNDd8LyUCImWnVQEN2B4WEbMwwPBaI1uuWe5S5rdtypzHifxlWh 47G58qASm7YoYzSyNGjHgn5JMt8sWe/Ow+y2pwlKyRSvGtkP3WJhhQKf0GjrDLU129k6 ISqw== X-Gm-Message-State: AODbwcADymaeo2c6IJn+soJsciI6tKGOcBeDWtBPetUZw/J48KJ5gyBv gLaZzv4s4EnKCXET6dJDH3pxRnBbGA== X-Received: by 10.202.171.200 with SMTP id u191mr13096287oie.75.1495567271082; Tue, 23 May 2017 12:21:11 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215138 Archived-At: --001a113c381cee4096055035e3e7 Content-Type: text/plain; charset="UTF-8" Paul Eggert schrieb am Di., 23. Mai 2017 um 19:36 Uhr: > On 05/23/2017 03:17 AM, Philipp Stephani wrote: > > I haven't tested it, but I'm pretty sure that adding > > -Wno-missing-braces should work. > > I'd feel more comfortable if you tested it and then committed it to master. > Done (cd9c7a0617). > > > it would be more future-proof to explicitly specify -Wno... > > In my experience it's a waste of time to try to future-proof or to > retrofit GCC's warnings, or Clang's for that matter. The warnings are > too flaky and are too mutable from one version to the next. At best we > can arrange for recent GCC to not warn on a few common configurations. > Maybe Clang too, if someone takes the time to do that. > As long as I compile on macOS, I guess I'll be bothered enough to try to keep the warnings at bay. --001a113c381cee4096055035e3e7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Paul E= ggert <eggert@cs.ucla.edu> = schrieb am Di., 23. Mai 2017 um 19:36=C2=A0Uhr:
On 05/23/2017 03:17 AM, Philipp Stephani wrote:
> I haven't tested it, but I'm pretty sure that adding
> -Wno-missing-braces should work.

I'd feel more comfortable if you tested it and then committed it to mas= ter.

Done (cd9c7a0617).
=C2=A0

> it would be more future-proof to explicitly specify -Wno...

In my experience it's a waste of time to try to future-proof or to
retrofit GCC's warnings, or Clang's for that matter. The warnings a= re
too flaky and are too mutable from one version to the next. At best we
can arrange for recent GCC to not warn on a few common configurations.
Maybe Clang too, if someone takes the time to do that.

As long as I compile on macOS, I guess I'll be bothered= enough to try to keep the warnings at bay.
--001a113c381cee4096055035e3e7--