From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unbreak build when building without GMP support. Date: Wed, 24 Apr 2019 21:19:54 +0200 Message-ID: References: <20190424175105.90319-1-phst@google.com> <83tven1c0y.fsf@gnu.org> <83pnpb1avu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179966"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 24 21:35:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJNgN-000kV5-EK for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 21:35:51 +0200 Original-Received: from localhost ([127.0.0.1]:46156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNZi-0006PH-6k for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 15:28:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNZU-0006FJ-Ew for emacs-devel@gnu.org; Wed, 24 Apr 2019 15:28:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJNQx-0006Se-I7 for emacs-devel@gnu.org; Wed, 24 Apr 2019 15:19:56 -0400 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:46318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJNQt-0006I5-SE; Wed, 24 Apr 2019 15:19:51 -0400 Original-Received: by mail-oi1-x234.google.com with SMTP id l12so4308668oie.13; Wed, 24 Apr 2019 12:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=McmNsoxC9k2nwnzpN+KIYD7xtgMq9gJ99aUhEh9wJfI=; b=PDywZWRN9BUBKrDwq+vb3iLaENeR5IWctCP7kRG52RxZZ+QaNuQHRgYyFWoGinz8tG 1HyikE1fv49rBcEKjzdB4bPaszsv05PnYWbZ/YdzT7B6siWPFrkiyuf9M4VQyC6LbQxL AgGJsAi1VHM7Cu45E2nFHKeFBNjm2wPAxSU46omaix+g5LlNAOxmbPmnsX9PR+yJu/Uc xhI95TOKTsaHrh3qNe7XiXIhmtoEFOwBR86f1i0avJIaZJcQoUIGzyW4V8E57PoxFLdx /Q6Xj1erlJuUh0YmpdmkR03YPIwdNsTWZ0xuRohJNF736dMYwBoOAzuy9MjkKPRj0XAS Lh9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=McmNsoxC9k2nwnzpN+KIYD7xtgMq9gJ99aUhEh9wJfI=; b=qpP1TE4TonpBdNRpgYhSVThatEE9QGN9aY4HyI2LVw3SjjdrFudNqTd/f5pemp6grO O7d6d/ruj0tuOX8CVJ7dAI3170JYh3bEKE2ZPD6bQVUQkWh3ZejJc5Vmn8G/w29BN1Tm BeoKXqCQqSKrbdyptrteQrCaw9e1HQONroLJW1Jv+VuXhuBfcd23+ehDS+no1ZImEFnK lVMpdAO28o5k28C6nj5VkzE7aJbld3YR2cMfe6bwUhvF88JtqBzVcXcWRp/1lWgfCZZQ yoN2sMpIxnlcYIT4bGuS5AsSADOfxNMp93yTn5GU/WwKVZ/VTju/b+I12ZJ2FhIp6H+A QbNQ== X-Gm-Message-State: APjAAAW4WfOqcVTPcgKyVQIV91N7HLE87eywf1kQpmmM6cN19hWj8eU2 fXva1b/jdYqliixvpX2Q/0Brpci9IumQ0wvwiZ7Fxg== X-Google-Smtp-Source: APXvYqycxl6sPIpHw1/oWS4HyZsyDCXmomERA63hs3baFwLM74xbuErxHGKYUXnZk0bbBOALYiukT6119yjpycn5TK8= X-Received: by 2002:aca:d90a:: with SMTP id q10mr484567oig.65.1556133589756; Wed, 24 Apr 2019 12:19:49 -0700 (PDT) In-Reply-To: <83pnpb1avu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235877 Archived-At: Am Mi., 24. Apr. 2019 um 21:06 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Wed, 24 Apr 2019 20:49:34 +0200 > > Cc: Emacs developers , Philipp Stephani > > > > > Btw, why are we including emacs-module.h in lisp.h? IME, this usually > > > causes trouble, so it is best to avoid that. > > > > lisp.h needs types from emacs-module.h to define Lisp_Module_Function. > > A single data type? I'd rather move XMODULE_FUNCTION to > emacs-module.c, and the data type definition and all the other related > stuff to emacs-module.h. It isn't worth the hassle. We shouldn't move anything to emacs-module.h because it's a public header, to be used outside of Emacs. What hassle are you talking about? There is no hassle. We have been including emacs-module.h in lisp.h for years, and there was never any problem.