From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master 2e090da: Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. Date: Sat, 31 Oct 2020 16:07:35 +0100 Message-ID: References: <20201025101403.1168.4440@vcs0.savannah.gnu.org> <20201025101404.7EBE2204DA@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 31 16:08:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYsUo-00024e-MS for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Oct 2020 16:08:46 +0100 Original-Received: from localhost ([::1]:38244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYsUn-0004bb-Mu for ged-emacs-devel@m.gmane-mx.org; Sat, 31 Oct 2020 11:08:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYsTx-0003el-L1 for emacs-devel@gnu.org; Sat, 31 Oct 2020 11:07:55 -0400 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:42225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYsTt-0005vm-Dt for emacs-devel@gnu.org; Sat, 31 Oct 2020 11:07:52 -0400 Original-Received: by mail-ot1-x332.google.com with SMTP id h62so8372358oth.9 for ; Sat, 31 Oct 2020 08:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5m6uoz2uzLPz0JeLDTAWSDCqBlCMElO84m7UogHSakE=; b=eBViUKWE5jHxk8W39205outqToYnEvdtfkXoSvLIW4FX3D3co3Fk3Rwvl/6gTlgaA+ 3ddPB0XQY5Qq3reWTMuUt8TqIV7ru9T7q3b33GErRie5BlZlO1x9Yu6Yxy2fU8gMJDcj E388jdul4Hcx1O4wQm7+KWpJ89MwGm9Vlet/6R1ns1t8vtC0uaQAdRob2+muphvRhclU LvgIDnIPKuyuUT0GnVsWxrK+6uEGJnrc7cBKmwXiJYxSa3988TFN/r9ZsOEn3qslwzbN B6dkKD8C20Ul3kAk5UGxTHEFxjr/8Re0qWVviw02fE132ZSdb78brFjtK8IwbBQhZEnw 7MWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5m6uoz2uzLPz0JeLDTAWSDCqBlCMElO84m7UogHSakE=; b=HDBsGLuVxTqOUysDZaQ0pQ3l2NsNoYzaKk+l3qE5KNBBzbvUE2A2PTLkI9ptAzMTy+ i8XEzsMY5e75PXt7h0xmkY2z1ZTqN0DnOIRbfUz8iSWhHNe/AeKD7gPvMQqXxyTLwNaH NM8bvLbioAsqf8QXljndYx0bhzH8UAojC15/sGDlz4ZRz20rp5SMzB4vGVRpu2Nv80vA wDGyr6IMAF7W3E48eSbhB+ZyKcuuPYv+i34ioT9i87Dv1BhhoBenfelSxovU3V+3ASXA SqJRWX0HyS6aN5uCP0G7mc0XoUmOS2KkzxXbBtdOV9KeWRu/wTJdj2i0/L33ICTEBAO0 Tp0g== X-Gm-Message-State: AOAM532Qht8zOIHbsUbmJW4quoVioAUdq2SaMBJHtCmAKS3nzoFB+8+9 Ft1aSI2cxhrWG8CjmF1xTgCB3J/efmTTCnKuUY8= X-Google-Smtp-Source: ABdhPJySuEIaIGFY5ymjlKS/gADnm/bKsURHwgDwc4puP0jN8Z6s7mo3R0B4cY7afFEZp54yccwvK9/CdR6PIjSHcro= X-Received: by 2002:a9d:12f3:: with SMTP id g106mr5423589otg.149.1604156866719; Sat, 31 Oct 2020 08:07:46 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258582 Archived-At: Am So., 25. Okt. 2020 um 14:59 Uhr schrieb Stefan Monnier : > > > Revert commit 1f44a776729adf9c6468a76f8310616fde62eeaa for Flymake. > > Flymake supports all Emacs versions back to 26.1, so it can=E2=80= =99t use > > =E2=80=98ert-resource-file=E2=80=99. > > * test/lisp/progmodes/flymake-tests.el (flymake-tests-data-director= y): > > Recreate. > > (flymake-tests--call-with-fixture): Stop using =E2=80=98ert-resourc= e-file=E2=80=99. > > It's common for a package to say "require Emacs version NN.MM" but to > provide extra features on more recent Emacsen. And the tests can > definitely fall into the category of extra features. > I disagree, the tests are a core part of the code, and it's crucial that they can be run against any supported Emacs version. This implies that the tests themselves need to be compatible with all supported Emacs versions. We should really run the tests of such packages against all supported versions on the CI system to avoid such breakages.