From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: master 8dcb19f 4/4: Add a unit test testing interaction between threads and processes. Date: Sat, 23 Jan 2021 21:34:28 +0100 Message-ID: References: <83k0s34eo1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philipp Stephani , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 21:36:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3PeS-0007Yq-N4 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 21:36:56 +0100 Original-Received: from localhost ([::1]:37698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3PeR-0002H9-Ny for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 15:36:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3PcK-0007dr-Bj for emacs-devel@gnu.org; Sat, 23 Jan 2021 15:34:44 -0500 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:37871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3PcH-0004zc-D7; Sat, 23 Jan 2021 15:34:44 -0500 Original-Received: by mail-ot1-x332.google.com with SMTP id h14so8794226otr.4; Sat, 23 Jan 2021 12:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l/s6IGIJCnQeVw/msctWzlII1dCDFJTqoz8DBGeBkso=; b=qedVwksYFyBtThqMV5glgOfndDnsYftf6ewQWzaGoY6UTZdlaiMwg19x4FbtxpJURC E8Xpsdy8K209XYs8pbCivLT+pe0SJUYUWYbGmVZ0EzVzVb0X3HEuUrJdprMozV95tksx 63NePjdv0s3kPu9Yk3QLBHLfjwVM5fCsl13bZrcF97lKCjPO0e7T0kPsNLd4lrpR5cil MaIC7um3qPd59fnv9hna420FZ6Kj7RcWPIL5uDxLSZKuYRLJOK+qajFJ8AfhluSqv506 uLGdeQjL5lL5eJ49rKrCte9+e4XDSiK1G8EgiIhIIyPNNut74tmSBL9QyIkNOr0FszS+ N09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l/s6IGIJCnQeVw/msctWzlII1dCDFJTqoz8DBGeBkso=; b=Umk6KdvbHu8ibM0Rmh7yIcQshi4y7NVBGKx0OphNPnelhXCVED2B0PJyND+EmfoRI+ xf/sbMApnwj81kNZ2GkPUCtoHLfpesfKY4jKTc1CaoX05mawzqSXJxq5X51RY8HTElaG RlsxBDHxEEHgbVmq9ys3L1BCWOdRUpCkwMV6wvbTI/4/UMQpWw5m4kbkV15hzPGgFW7X uyKeMG14SokqWMfXLDnWDrfIGuilfbLwAEhqaZ6n4idXfcxqRsT39S52Chj8ePGmCkZ9 boRTu/iO7Iigo0Ucr/J6x/NkhVtfzA/1PnJxn4aed0BaVqVARkcKN+1fcJ8IXPA5T4aZ HB1w== X-Gm-Message-State: AOAM5310aujWrGD/kv9b85zAtvCMOTTEfh6RUceBsTpOmJ33xXLQNYOz 6vKEfaL+XTQgYv6RhSx9hJepIZYjez6pUVGYemlgJV8Fwxw= X-Google-Smtp-Source: ABdhPJwpeas2uG88vBAgqxtgpsRnSMshO8GCd+UR/t88WFElmC2erQe87p3uRCcPI3lNbzgcfIFmQTPFhxRt7FXrwcs= X-Received: by 2002:a9d:4e8d:: with SMTP id v13mr7836667otk.12.1611434079620; Sat, 23 Jan 2021 12:34:39 -0800 (PST) In-Reply-To: <83k0s34eo1.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=p.stephani2@gmail.com; helo=mail-ot1-x332.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263321 Archived-At: Am Sa., 23. Jan. 2021 um 20:49 Uhr schrieb Eli Zaretskii : > > This additional test fails on MS-Windows: > > Test process-tests/multiple-threads-waiting backtrace: > signal(ert-test-failed (((should (eql (process-exit-status process) > ert-fail(((should (eql (process-exit-status process) 0)) :form (eql > (if (unwind-protect (setq value-344 (apply fn-342 args-343)) (setq f > (let (form-description-346) (if (unwind-protect (setq value-344 (app > (let ((value-344 'ert-form-evaluation-aborted-345)) (let (form-descr > (let* ((fn-342 #'eql) (args-343 (condition-case err (let ((signal-ho > (while (and (consp --cl-var--) (consp --cl-var--)) (progn (setq proc > (let ((--cl-var-- processes) (process nil) (--cl-var-- threads) (thr > (let ((threads nil) (cat (executable-find "cat"))) (let ((value-335 > (unwind-protect (let ((threads nil) (cat (executable-find "cat"))) ( > (let ((processes nil)) (unwind-protect (let ((threads nil) (cat (exe > (progn (let ((processes nil)) (unwind-protect (let ((threads nil) (c > (unwind-protect (progn (let ((processes nil)) (unwind-protect (let ( > (let* ((-with-timeout-timer- (run-with-timer 60 nil #'(lambda nil (t > (catch 'timeout (let* ((-with-timeout-timer- (run-with-timer 60 nil > (let ((-with-timeout-value- (catch 'timeout (let* ((-with-timeout-ti > (closure (t) nil (let* ((fn-330 #'fboundp) (args-331 (condition-case > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name process-tests/multiple-threads-waitin > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type > ert-run-tests-batch((not (tag :unstable))) > ert-run-tests-batch-and-exit((not (tag :unstable))) > eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) > command-line-1(("-L" ";." "-l" "ert" "-l" "src/process-tests.el" "-- > command-line() > normal-top-level() > Test process-tests/multiple-threads-waiting condition: > (ert-test-failed > ((should > (eql > (process-exit-status process) > 0)) > :form > (eql 1 0) > :value nil)) > FAILED 21/26 process-tests/multiple-threads-waiting (8.859375 sec) > > I did verify that process-send-eof does cause 'cat' to exit, so the > problem is likely in some issue related to threads and what the test > assumes regarding what should happen here. What's surprising here is that "cat" exited with an exit status of 1, shouldn't that be normally impossible?