From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30745: 26.0.91; ert should macros nest strangely Date: Sun, 29 Nov 2020 11:35:43 +0100 Message-ID: References: <874llr4lk1.fsf@russet.org.uk> <87r2ov1l46.fsf@gmail.com> <87sh9blzfy.fsf@russet.org.uk> <87lg98xxpi.fsf@gmail.com> <87tvcesiib.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 24402@debbugs.gnu.org, 30745@debbugs.gnu.org, Phillip Lord To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 11:37:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjK4u-0003OX-5m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 11:37:12 +0100 Original-Received: from localhost ([::1]:50612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjK4s-0003UZ-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 05:37:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjK4l-0003UL-9K for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 05:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38257) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjK4l-00073f-2l for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 05:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjK4l-0003Kt-03 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 05:37:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 10:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30745-submit@debbugs.gnu.org id=B30745.160664616312666 (code B ref 30745); Sun, 29 Nov 2020 10:37:02 +0000 Original-Received: (at 30745) by debbugs.gnu.org; 29 Nov 2020 10:36:03 +0000 Original-Received: from localhost ([127.0.0.1]:49797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjK3m-0003ID-L1 for submit@debbugs.gnu.org; Sun, 29 Nov 2020 05:36:02 -0500 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:33832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjK3j-0003He-Q2; Sun, 29 Nov 2020 05:36:00 -0500 Original-Received: by mail-ot1-f41.google.com with SMTP id h19so8689331otr.1; Sun, 29 Nov 2020 02:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xbx0xmAY36ozktBMFyIOtqj+MVifM0OdN1igaGEX4yo=; b=V+ZbHswFdAJTbzkAZ1itKRnAFUnsHaXLdloOX1RL2ABkA933qmq2CrUOA+icAD/fAN o9x3FF1k4ho0k2W0Q7avQMuZE+7nHS70Ktneqgo5X372eA62+0eQsgSNJFvvl7INgIKk F67XMAtTJENyKATIst7fAGk49s82lfnSwkDOpTB+VspzjNZZZORO0KzQ9Q1qno/Nh812 sPi6daLDvzOsI8Q79Ps4rfyM8mHN+Cd+DhqkjhXtOLnknpZoumc3OuzY3izKLguhftvs JB4alPXzF5BUyjXFH4zClsFTX2hFFmYoW9HT9sc2wXQyslyRE8dMKlkxHdhmjl+pWiCY I+Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xbx0xmAY36ozktBMFyIOtqj+MVifM0OdN1igaGEX4yo=; b=plRPrnL40OH3TeVn9tiNTCg3iFD4ZKYOoUeQOmzqC6Ez0nBn54nk/CracJVUBpoadE UWCo4nUs5nWsn4+lTwgb/KBrcve9nYtuHJnfdsTNjxDmKwQW2TdX7FQn+PfkzVOfYue8 FkOJrlSuoJnT2sFB6yo+FpPcF0W50x00EDKJUr0ezY9Eq+SgxyRMo3gyb/8rUDAuGxnC R21gpbqvA0aawKgeXtvFWceroJc8EAuzQYnEStNpnzF07LY4nThD0BJfFmJez5RbOYUy 5/j5DcjD6vKKhPqoVVGJ5cMYkaXU3jrROt9w2t6YpPMS+m2iBlvVahYuxT2k+o3gTsUX MEcA== X-Gm-Message-State: AOAM533DUc4vhJILs75ZizrjMtbK17AMqa0TUUAnQC+YOI3KzwuTj6BM QF68XrbDjjGa+jvHlgK//uflRcLv/50vEyC0Urk= X-Google-Smtp-Source: ABdhPJxOK3LEAWH0N6r0Ta9bBmHUHSC3ifLgfTXabcA1rdNOCYpXO79pzT2raU7wvgRm8If4f2rt6ibVGsEilCkvA5E= X-Received: by 2002:a9d:72c4:: with SMTP id d4mr12631138otk.149.1606646154010; Sun, 29 Nov 2020 02:35:54 -0800 (PST) In-Reply-To: <87tvcesiib.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194540 Archived-At: Am Di., 25. Juni 2019 um 00:54 Uhr schrieb Noam Postavsky : > > Lars Ingebrigtsen writes: > > > Noam Postavsky writes: > > > >> I have a patch for ert which removes it's (ab)use of the debugger, it > >> seems to fix this case (and also Bug#11218). Note that it relies on my > >> patch in #24618 for a catch-all condition-case handler clause. > > > > #24618 was fixed a few weeks later, but this patch was never applied? > > The main blocker for this is the other thing: > > >> But it bumps into another bug lurking in process.c, which just happened > >> to work okay previously because ert would bind debug-on-error while > >> running tests. > How many tests (besides the jsonrpc one) do we expect to be broken due to this? It seems that tests relying on such a bug are inherently brittle, so maybe we can bite the bullet and apply the patch nevertheless? Or introduce another hack in process.c that treats ERT tests specially, as if debug-on-error were bound?