From: Philipp Stephani <p.stephani2@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
24402@debbugs.gnu.org, 30745@debbugs.gnu.org,
Phillip Lord <phillip.lord@russet.org.uk>
Subject: bug#30745: 26.0.91; ert should macros nest strangely
Date: Sun, 29 Nov 2020 11:35:43 +0100 [thread overview]
Message-ID: <CAArVCkT5UGeX8DkH+QXTk0dh2yh-SWwfx5it0351gkBT3MPLvQ@mail.gmail.com> (raw)
In-Reply-To: <87tvcesiib.fsf@gmail.com>
Am Di., 25. Juni 2019 um 00:54 Uhr schrieb Noam Postavsky <npostavs@gmail.com>:
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Noam Postavsky <npostavs@gmail.com> writes:
> >
> >> I have a patch for ert which removes it's (ab)use of the debugger, it
> >> seems to fix this case (and also Bug#11218). Note that it relies on my
> >> patch in #24618 for a catch-all condition-case handler clause.
> >
> > #24618 was fixed a few weeks later, but this patch was never applied?
>
> The main blocker for this is the other thing:
>
> >> But it bumps into another bug lurking in process.c, which just happened
> >> to work okay previously because ert would bind debug-on-error while
> >> running tests.
>
How many tests (besides the jsonrpc one) do we expect to be broken due
to this? It seems that tests relying on such a bug are inherently
brittle, so maybe we can bite the bullet and apply the patch
nevertheless? Or introduce another hack in process.c that treats ERT
tests specially, as if debug-on-error were bound?
next prev parent reply other threads:[~2020-11-29 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 21:34 bug#30745: 26.0.91; ert should macros nest strangely Phillip Lord
2018-03-07 22:24 ` Phillip Lord
2018-03-08 14:49 ` bug#24402: " Phillip Lord
2018-03-08 0:12 ` Noam Postavsky
2018-03-08 8:54 ` Phillip Lord
2018-08-15 0:47 ` Noam Postavsky
2019-06-24 18:54 ` Lars Ingebrigtsen
2019-06-24 22:53 ` Noam Postavsky
2019-06-28 3:06 ` Noam Postavsky
2020-11-29 10:35 ` Philipp Stephani [this message]
2021-07-22 13:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAArVCkT5UGeX8DkH+QXTk0dh2yh-SWwfx5it0351gkBT3MPLvQ@mail.gmail.com \
--to=p.stephani2@gmail.com \
--cc=24402@debbugs.gnu.org \
--cc=30745@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=npostavs@gmail.com \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.