From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Date: Sat, 4 Jan 2020 20:56:37 +0100 Message-ID: References: <20191226000417.69183-1-phst@google.com> <83v9psgz1x.fsf@gnu.org> <83sgkwguxm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71743"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30373@debbugs.gnu.org, Samir Jindel To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 04 20:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inpXq-000IXv-LJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jan 2020 20:57:10 +0100 Original-Received: from localhost ([::1]:36456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inpXp-0008RH-DU for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jan 2020 14:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46270) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inpXj-0008R8-25 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 14:57:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inpXi-0002fX-11 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 14:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inpXh-0002f0-Sx for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 14:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inpXh-0003vJ-Qe for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2020 14:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2020 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30373 X-GNU-PR-Package: emacs Original-Received: via spool by 30373-submit@debbugs.gnu.org id=B30373.157816781715067 (code B ref 30373); Sat, 04 Jan 2020 19:57:01 +0000 Original-Received: (at 30373) by debbugs.gnu.org; 4 Jan 2020 19:56:57 +0000 Original-Received: from localhost ([127.0.0.1]:43422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpXc-0003uv-PT for submit@debbugs.gnu.org; Sat, 04 Jan 2020 14:56:56 -0500 Original-Received: from mail-ot1-f51.google.com ([209.85.210.51]:34116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inpXb-0003uk-Lo for 30373@debbugs.gnu.org; Sat, 04 Jan 2020 14:56:55 -0500 Original-Received: by mail-ot1-f51.google.com with SMTP id a15so65826022otf.1 for <30373@debbugs.gnu.org>; Sat, 04 Jan 2020 11:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9USAdSsavzgs5KLlUCfRbXP94MEtZ7lJwS5pFq/eg6k=; b=fWscZxdJj3gc5/lh9XWTuDCOH7S4UbMl2jw98AzW4RRT0mn3VL85cdb8Lppe1+L4ix 4qdQ1yNJvVKlVRR338T6SqDSxIjJUfio46XXY1izApAeT7zE3EMxQUrUneML2fn84XsI qMAZfEHL6DNF4BdGaxt5k5h9xnvGxI2a9Zu/k7NxirhvfE4T7vc6VpfaV75UxSQBNZzW rc0zvAzAqsej7++lqQd1JYxNmfVVu/LRPk3KEamh8DuthQg6FvRGPrcDRQqyQBe/AGVT ygXPJ8s7kHlgskS6CSRCfkjAoBgfncfVKWqD7Qnn0topAqeNOmQProfZ86d5D/nK3rby 2AVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9USAdSsavzgs5KLlUCfRbXP94MEtZ7lJwS5pFq/eg6k=; b=A+s5/hY159nIC+BdmTVbT4+PpotANvppAOHiHkXrl3eb0ZrHBwFfE4dacULm9BQxn1 fTdmRLb8LjD+KS4pMmzMWgFhk5cQyrVjP0zxlOFjIcCd1SXG18MPw2MSu5e7uGJ8MECj 0lOEqiLrcuPyYteNaQFL31/ZcTV6/B+i4DfAjawYMltVw8bj94oz9CEtIZ7tAJTD22UQ 0BE+Y7W1jozWnhhzRXKFNy+pAUECGPyQ9HAxFdcejD4Zl6K11QkNye5Gcc5KV8HfX6AP ao2srIfIBJo82YxUNljwghI6m9OwfjCTgmQTNn2aV2H+HNQBIv0eMny71tKv/lJMvuzm FgpA== X-Gm-Message-State: APjAAAUR2/MbPfmAc9o4XDqCmX4lQtrX6jVTkXNe5IunU0doRi5r5Lf3 tqN7DKLw3/R6Tb9z6cBi8Bl/xgQhaAnz7YCVFvo= X-Google-Smtp-Source: APXvYqy7gV1MShYuahahfHv6m52LWsSOgyPYVXtAB26rMb0LCltG1JdIgpZWwpXJ9ey726KT6zS6v7/k+ClsF9ocwtM= X-Received: by 2002:a05:6830:ce:: with SMTP id x14mr93917212oto.105.1578167809866; Sat, 04 Jan 2020 11:56:49 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174176 Archived-At: Am Fr., 3. Jan. 2020 um 21:50 Uhr schrieb Pip Cet : > > On Fri, Jan 3, 2020 at 8:13 PM Eli Zaretskii wrote: > > > From: Pip Cet > > > Date: Fri, 3 Jan 2020 18:53:46 +0000 > > > Cc: Philipp Stephani , 30373@debbugs.gnu.org, sjindel@google.com > > > > > > If I'm reading the test correctly, it depends on garbage-collect > > > actually collecting an unreferenced vector; since our GC's > > > conservative, that might not be working for you, if a word that > > > happens to look like a reference to the vector is still on the stack. > > > (Or it might be something else entirely, but I don't think the test as > > > it stands is correct). > > > > You are probably right, because I see the same failure on GNU/Linux, > > in an x86_64 unoptimized build: > > I see it too. Fprogn keeps the value of the first sub-form alive while > evaluating the second one. > > We can "fix" Fprogn to discard val early in unoptimized builds, and > that might make GC behavior slightly less surprising. > > But it won't properly fix this test. Ah yeah, looks like the test was too brittle. (For some reason, it worked fine on macOS.) I've now installed a patch that creates 100 dangling functions; hopefully that increases the likelihood of at least one getting garbage-collected.