From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#24359: Patch for byte compilation bugs Date: Sun, 11 Sep 2016 16:05:27 +0000 Message-ID: References: <878tv79xw6.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1146a152e836c6053c3d8c26 X-Trace: blaine.gmane.org 1473609998 30621 195.159.176.226 (11 Sep 2016 16:06:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2016 16:06:38 +0000 (UTC) Cc: 24359@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 11 18:06:34 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj7Gs-0005lb-4q for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2016 18:06:18 +0200 Original-Received: from localhost ([::1]:38231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj7Gp-0001zq-45 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2016 12:06:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj7Gi-0001zY-NI for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 12:06:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bj7Gc-0005UL-MZ for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 12:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bj7Gc-0005UE-Ic for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 12:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bj7Gc-00027V-9H for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2016 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2016 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24359-submit@debbugs.gnu.org id=B24359.14736099458122 (code B ref 24359); Sun, 11 Sep 2016 16:06:02 +0000 Original-Received: (at 24359) by debbugs.gnu.org; 11 Sep 2016 16:05:45 +0000 Original-Received: from localhost ([127.0.0.1]:56587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj7GL-00026w-4U for submit@debbugs.gnu.org; Sun, 11 Sep 2016 12:05:45 -0400 Original-Received: from mail-wm0-f54.google.com ([74.125.82.54]:35875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bj7GJ-00026i-T7 for 24359@debbugs.gnu.org; Sun, 11 Sep 2016 12:05:44 -0400 Original-Received: by mail-wm0-f54.google.com with SMTP id b187so101681809wme.1 for <24359@debbugs.gnu.org>; Sun, 11 Sep 2016 09:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r7H+45vZuVr1nGmWCT51rm9GAwHHIaWysSsx540fD0Q=; b=b4lb+HdGWmhJkA3EbScywWyCyI70xNCNZs+EZYP91uoPQQqmOn7ydXyH65RO8Os2NN QBgY9jDLpxZb0WodgxhsHl9v4PEinBRC8st67GEDTe/2W4qpIFqiwYdrgpt9HTJxEH47 7wQ2tCOrp9Jkh+sp4yRFo9/m6SQx/shDNjdz4hhZ27JI3B5o+hr4qnLqmPKrmFsPLExY IUOQUG7gJQhNf9OxnP+U9xCF71veWRDEkgDMyVFnHeTqj6XUZQlGazLrMXaxI1a7ltN0 onb602v3S9FxMxSk+3Z7IXilrWIGdR1eI2spDkbInTRJwHxImL5o6lgFQkgJncKWul80 nDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r7H+45vZuVr1nGmWCT51rm9GAwHHIaWysSsx540fD0Q=; b=iPEYZm5DV3J/xP6+Xa53mAXpzXkbgd4jOnlNkj/Xl7cewIMzi87Az5ocLALhXhZzyM hX9IbFuNxjICx7yRc9JtpA/+zZcFWeAh5bhFgbHJrypGWPTdiureNxYHqLo44WbDXXfU EYwaAANhsgiqwfakdVb4MfuxczoLf5DpzUKMgn1Ub+QEXI1Xy9vbazgTm6JZ8CkW08p7 u89dgTXREQt7x0Nv5Jn+5rARBMzE+NCkzwKQfgsYUqrN7DoQB8JRstpaC/njrMtSPnL0 n9BNp10RHTMOYhdLmgDm5Xr2Z0Q0Xhm/+IpmHhq2d9poLm3+XNuEXoKqDwbatWX/MiDR W0ww== X-Gm-Message-State: AE9vXwNoMyOX8lwr+a63AELkp5EBH+3Ccvpw+wwcgZamrL4VnzOgsCN/2qqp0Vzf6iQ9lxF9TN7zdX1Wz69lDg== X-Received: by 10.28.232.71 with SMTP id f68mr7101512wmh.55.1473609938250; Sun, 11 Sep 2016 09:05:38 -0700 (PDT) In-Reply-To: <878tv79xw6.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123177 Archived-At: --001a1146a152e836c6053c3d8c26 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable schrieb am So., 4. Sep. 2016 um 23:07 Uhr: > > There was some suggestion in #23495 (to which I've merged this bug) that > it may have been on purpose, but no confirmation of that, and it doesn't > really make sense to me, so I think your patch is a good idea. > Thanks. Since nobody complained or provided arguments for the current behavior, I've pushed it to master. > > Philipp Stephani writes: > > > > * lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled) > > (macroexp--warn-and-return): Use =E2=80=98byte-compile-warn=E2=80=99 in= stead of > > =E2=80=98byte-compile-log-warning=E2=80=99. > > > > * lisp/emacs-lisp/bytecomp.el (byte-compile-form, > byte-compile-unfold-bcf) > > (byte-compile-setq, byte-compile-funcall): Use > > =E2=80=98byte-compile-report-error=E2=80=99 instead of =E2=80=98byte-co= mpile-log-warning=E2=80=99. > [...] > > * lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use) > > (cconv--analyze-function, cconv-analyze-form): Use > > =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-lo= g-warning=E2=80=99. > > > > * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Use > > =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-lo= g-warning=E2=80=99. > > > > * lisp/subr.el (add-to-list): Use =E2=80=98byte-compile-report-error=E2= =80=99 instead > > of =E2=80=98byte-compile-log-warning=E2=80=99. > > (do-after-load-evaluation): Use =E2=80=98byte-compile-warn=E2=80=99 ins= tead of > > =E2=80=98byte-compile-log-warning=E2=80=99. > > I think you can combine all these into one entry. > I wouldn't know how, as they are for different files, and AFAIK the changelog format doesn't allow combining messages across files. > > > (defun byte-compile-log-warning (string &optional fill level) > > + "Log a message STRING in `byte-compile-log-buffer'. > > +Also log the current function and file if not already done. If > > +FILL is non-nil, set =E2=80=98warning-fill-prefix=E2=80=99 to four spa= ces. LEVEL > > Docstrings should use `', which will be converted to =E2=80=98=E2=80=99 u= pon display. > Done. --001a1146a152e836c6053c3d8c26 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


<npostavs@users.sourceforge.= net> schrieb am So., 4. Sep. 2016 um 23:07=C2=A0Uhr:

There was some suggestion in #23495 (to which I've merged this bug) tha= t
it may have been on purpose, but no confirmation of that, and it doesn'= t
really make sense to me, so I think your patch is a good idea.

Thanks. Since nobody complained= or provided arguments for the current behavior, I've pushed it to mast= er.
=C2=A0

Philipp Stephani <p.stephani2@gmail.com> writes:
>
> * lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled)
> (macroexp--warn-and-return): Use =E2=80=98byte-compile-warn=E2=80=99 i= nstead of
> =E2=80=98byte-compile-log-warning=E2=80=99.
>
> * lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-= bcf)
> (byte-compile-setq, byte-compile-funcall): Use
> =E2=80=98byte-compile-report-error=E2=80=99 instead of =E2=80=98byte-c= ompile-log-warning=E2=80=99.
[...]
> * lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use)
> (cconv--analyze-function, cconv-analyze-form): Use
> =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-l= og-warning=E2=80=99.
>
> * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Use
> =E2=80=98byte-compile-warn=E2=80=99 instead of =E2=80=98byte-compile-l= og-warning=E2=80=99.
>
> * lisp/subr.el (add-to-list): Use =E2=80=98byte-compile-report-error= =E2=80=99 instead
> of =E2=80=98byte-compile-log-warning=E2=80=99.
> (do-after-load-evaluation): Use =E2=80=98byte-compile-warn=E2=80=99 in= stead of
> =E2=80=98byte-compile-log-warning=E2=80=99.

I think you can combine all these into one entry.

I wouldn't know how, as they are for dif= ferent files, and AFAIK the changelog format doesn't allow combining me= ssages across files.
=C2=A0

>=C2=A0 (defun byte-compile-log-warning (string &optional fill level= )
> +=C2=A0 "Log a message STRING in `byte-compile-log-buffer'. > +Also log the current function and file if not already done.=C2=A0 If<= br class=3D"gmail_msg"> > +FILL is non-nil, set =E2=80=98warning-fill-prefix=E2=80=99 to four sp= aces.=C2=A0 LEVEL

Docstrings should use `', which will be converted to =E2=80=98=E2=80=99= upon display.

Done= .=C2=A0
--001a1146a152e836c6053c3d8c26--