From: Philipp Stephani <p.stephani2@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
Philipp Stephani <phst@google.com>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Clean up a couple of compiler warnings
Date: Sun, 21 May 2017 20:00:11 +0000 [thread overview]
Message-ID: <CAArVCkT3G85=otipybsd_E14QFWHnr5W3w-ZVHJy82VQbeuD9g@mail.gmail.com> (raw)
In-Reply-To: <c3033bed-ef38-98f9-7eff-10a0ebfddb49@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
Paul Eggert <eggert@cs.ucla.edu> schrieb am So., 21. Mai 2017 um 08:07 Uhr:
> On 05/19/2017 02:31 AM, Philipp Stephani wrote:
> > Apparently on some systems mbstate_t is a nested struct, and the compiler
> > warns about missing braces. Note that memset to initialize a mbstate_t is
> > explicitly recommended in the libc manual:
>
> Yes, of course memset works (which is all that the glibc manual really
> says).
> It's just that it's verbose and the verbosity isn't needed.
>
> I guess the problem here is that clang's -Wmissing-braces option generates
> false
> alarms. The Clang folks may fix that someday. In the meantime I installed
> the
> first attached patch, to turn off that option for Clang.
>
This apparently hasn't worked, at least I still get the warning, and
there's no -Wno-missing-braces in WARN_CFLAGS.
For Clang, it'd probably be better to use -Weverything and then disable
individual warnings with -Wno... instead of checking for the existence of
every warning flag. That would make configure runs faster and the command
line shorter.
[-- Attachment #2: Type: text/html, Size: 1400 bytes --]
next prev parent reply other threads:[~2017-05-21 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 20:24 [PATCH] Clean up a couple of compiler warnings Philipp Stephani
2017-05-18 20:40 ` Eli Zaretskii
2017-05-19 3:48 ` Paul Eggert
2017-05-19 6:53 ` Eli Zaretskii
2017-05-19 6:55 ` Paul Eggert
2017-05-19 9:31 ` Philipp Stephani
2017-05-21 6:07 ` Paul Eggert
2017-05-21 20:00 ` Philipp Stephani [this message]
2017-05-21 20:33 ` Paul Eggert
2017-05-23 10:17 ` Philipp Stephani
2017-05-23 17:36 ` Paul Eggert
2017-05-23 19:19 ` Eli Zaretskii
2017-05-23 19:21 ` Philipp Stephani
2017-05-21 20:47 ` Perry E. Metzger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkT3G85=otipybsd_E14QFWHnr5W3w-ZVHJy82VQbeuD9g@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.